)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"721ba8d2184eefbbee6171934b2a111cdbbe457f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"attaching or detaching volumes, the driver searches for host groups or"},{"line_number":12,"context_line":"iSCSI targets that are already connected to the host."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"If this option is set to True, the driver checks only host groups or"},{"line_number":15,"context_line":"iSCSI targets that are most likely to be connected to the host."},{"line_number":16,"context_line":"If this option is set to False, the driver checks other host groups or"},{"line_number":17,"context_line":"iSCSI targets as well."},{"line_number":18,"context_line":"Setting this option to True may improve the performance of attaching or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a3905b3_8ecd1368","line":15,"range":{"start_line":14,"start_character":31,"end_line":15,"end_character":63},"updated":"2017-01-24 11:13:11.000000000","message":"-1: How does the driver defines which HG/target are more likely to be connected? If the driver does not find the IQN/WWN in those HG/targets what happens? Error?","commit_id":"c795f675561249adc905f3c72557a54c736dadd2"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"fd614ca4f229c361c062b4cbee94cbd5de0effd1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"attaching or detaching volumes, the driver searches for host groups or"},{"line_number":12,"context_line":"iSCSI targets that are already connected to the host."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"If this option is set to True, the driver checks only host groups or"},{"line_number":15,"context_line":"iSCSI targets that are most likely to be connected to the host."},{"line_number":16,"context_line":"If this option is set to False, the driver checks other host groups or"},{"line_number":17,"context_line":"iSCSI targets as well."},{"line_number":18,"context_line":"Setting this option to True may improve the performance of attaching or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a3905b3_378efc27","line":15,"range":{"start_line":14,"start_character":31,"end_line":15,"end_character":63},"in_reply_to":"5a3905b3_515aebf2","updated":"2017-01-25 09:12:43.000000000","message":"I mistaked the host group name.\nThe driver defines the host group named as HBSD-\u003cWWN name\u003e or HBSD-\u003cIP address of the controller node or the compute node\u003e are more likely to be connected.","commit_id":"c795f675561249adc905f3c72557a54c736dadd2"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"e89e6a5cab2c21d33846357444208ddaa0c0dba6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"attaching or detaching volumes, the driver searches for host groups or"},{"line_number":12,"context_line":"iSCSI targets that are already connected to the host."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"If this option is set to True, the driver checks only host groups or"},{"line_number":15,"context_line":"iSCSI targets that are most likely to be connected to the host."},{"line_number":16,"context_line":"If this option is set to False, the driver checks other host groups or"},{"line_number":17,"context_line":"iSCSI targets as well."},{"line_number":18,"context_line":"Setting this option to True may improve the performance of attaching or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a3905b3_515aebf2","line":15,"range":{"start_line":14,"start_character":31,"end_line":15,"end_character":63},"in_reply_to":"5a3905b3_8ecd1368","updated":"2017-01-24 12:37:21.000000000","message":"The driver defines the host group named as VSP-\u003cWWN name\u003e or VSP-\u003cIP address for compute node\u003e are more likely to be connected. If the driver does not find the IQN/WWN in those HG/targets, the driver creates a new host group.","commit_id":"c795f675561249adc905f3c72557a54c736dadd2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"721ba8d2184eefbbee6171934b2a111cdbbe457f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"iSCSI targets that are most likely to be connected to the host."},{"line_number":16,"context_line":"If this option is set to False, the driver checks other host groups or"},{"line_number":17,"context_line":"iSCSI targets as well."},{"line_number":18,"context_line":"Setting this option to True may improve the performance of attaching or"},{"line_number":19,"context_line":"detaching volumes. The default is False."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a3905b3_0e076382","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":31},"updated":"2017-01-24 11:13:11.000000000","message":"-1: May? Can you specify what cases the performace will be improved?","commit_id":"c795f675561249adc905f3c72557a54c736dadd2"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"e89e6a5cab2c21d33846357444208ddaa0c0dba6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"iSCSI targets that are most likely to be connected to the host."},{"line_number":16,"context_line":"If this option is set to False, the driver checks other host groups or"},{"line_number":17,"context_line":"iSCSI targets as well."},{"line_number":18,"context_line":"Setting this option to True may improve the performance of attaching or"},{"line_number":19,"context_line":"detaching volumes. The default is False."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a3905b3_9170d373","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":31},"in_reply_to":"5a3905b3_0e076382","updated":"2017-01-24 12:37:21.000000000","message":"First of all, VSP drivers use what is called a host group for the connection between server and storage. By registering WWN information and volume number in the host group, the VM can recognize the target volume.\n\nWhen initialize_connection was called, the driver needs to search the host group had the wwn for the compute node. But It can\u0027t be searched the appropriate host group from WWN by executing only a single command. The driver needs to get each host group information one by one. \n\nIf this parameter is false, the driver gets all of the host group information registered on storage.It takes long times to get all of the host group information.\n\nIf this parameter is true, the driver gets only the host group information named as VSP-\u003cWWN name\u003e or VSP-\u003cIP address for compute node\u003e. If the driver does not find the WWN in these host group, the driver creates a new host group. But if the host group for the compute node exist and have different name, initialize_connection error will happen.\n\nI wrote \"May\" because the performance is the same if the driver got the suitable host group in the first command. I think it is vague, too. I deleted \"May\".","commit_id":"c795f675561249adc905f3c72557a54c736dadd2"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"fd614ca4f229c361c062b4cbee94cbd5de0effd1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"iSCSI targets that are most likely to be connected to the host."},{"line_number":16,"context_line":"If this option is set to False, the driver checks other host groups or"},{"line_number":17,"context_line":"iSCSI targets as well."},{"line_number":18,"context_line":"Setting this option to True may improve the performance of attaching or"},{"line_number":19,"context_line":"detaching volumes. The default is False."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a3905b3_f7f1d496","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":31},"in_reply_to":"5a3905b3_9170d373","updated":"2017-01-25 09:12:43.000000000","message":"Please let me correct comments.\n\nIf this parameter is false, the driver gets the information of all host groups starting with the name \"HBSD-\". If there are a lot of host groups in the storage, it takes long times to get host groups information.\nIf this parameter is true, the driver gets only the host group information named as HBSD-\u003cWWN name\u003e or HBSD-\u003cIP address of the controller node or the compute node\u003e. If the driver does not find the WWN in these host groups, the driver creates a new host group. But the users need to\nuse be careful with the host group name.","commit_id":"c795f675561249adc905f3c72557a54c736dadd2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"aa414144f6839d0d6cb2d4b85c19190867ffdb96","unresolved":false,"context_lines":[{"line_number":15,"context_line":"iSCSI targets that are most likely to be connected to the host."},{"line_number":16,"context_line":"If this option is set to False, the driver checks other host groups or"},{"line_number":17,"context_line":"iSCSI targets as well."},{"line_number":18,"context_line":"Setting this option to True may improve the performance of attaching or"},{"line_number":19,"context_line":"detaching volumes. The default is False."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a461143_166ae080","line":18,"range":{"start_line":18,"start_character":28,"end_line":18,"end_character":31},"in_reply_to":"5a3905b3_f7f1d496","updated":"2017-01-26 01:28:46.000000000","message":"Hum, ok its much clear now. Im trying to understand what other options we could possibly have. Can you tell me if this is possible (or why not) these options to improve the performance:\n\nOption A:\n 1 - The driver always first search HBSD-\u003cWWN name\u003e\n 2 - If the driver does not find the HG, the driver then proceeds trying to other HBSD-* groups\n 3 - No new option would be required\n\nOption B:\n 1 - On driver initialization get the information of the ports and HGs used by the driver\n 2 - After a successful set/create command in the storage,   also change in the driver cache yo reflect what is in the storage (Im considering that the driver should be the only one changing HBSD-* HG and ports connected to Compute/Controllers. Is this a fair restriction? To require users not to touch resources managed by the driver?)\n 3 - Before issue a get command, get it from the cache\n 4 - If the driver is shutdown, all information is re-loaded in the initialization. \n\nThoughts?","commit_id":"c795f675561249adc905f3c72557a54c736dadd2"}],"cinder/volume/drivers/hitachi/vsp_horcm.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"721ba8d2184eefbbee6171934b2a111cdbbe457f","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        default\u003dFalse,"},{"line_number":216,"context_line":"        help\u003d\u0027If True, the driver checks only host groups or iSCSI targets \u0027"},{"line_number":217,"context_line":"             \u0027that are most likely to be connected to the host. \u0027"},{"line_number":218,"context_line":"             \u0027Setting this option to True may improve the performance of \u0027"},{"line_number":219,"context_line":"             \u0027attaching or detaching volumes.\u0027),"},{"line_number":220,"context_line":"    cfg.ListOpt("},{"line_number":221,"context_line":"        \u0027vsp_horcm_pair_target_ports\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_ae6baf1c","line":218,"range":{"start_line":218,"start_character":36,"end_line":218,"end_character":48},"updated":"2017-01-24 11:13:11.000000000","message":"-1: Again, this is too vague. The user needs to know what are the situations that he/she can expect the performance to be improved.","commit_id":"c795f675561249adc905f3c72557a54c736dadd2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"aa414144f6839d0d6cb2d4b85c19190867ffdb96","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        default\u003dFalse,"},{"line_number":216,"context_line":"        help\u003d\u0027If True, the driver checks only host groups or iSCSI targets \u0027"},{"line_number":217,"context_line":"             \u0027that are most likely to be connected to the host. \u0027"},{"line_number":218,"context_line":"             \u0027Setting this option to True may improve the performance of \u0027"},{"line_number":219,"context_line":"             \u0027attaching or detaching volumes.\u0027),"},{"line_number":220,"context_line":"    cfg.ListOpt("},{"line_number":221,"context_line":"        \u0027vsp_horcm_pair_target_ports\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_362c3c4a","line":218,"range":{"start_line":218,"start_character":36,"end_line":218,"end_character":48},"in_reply_to":"5a3905b3_11c0634f","updated":"2017-01-26 01:28:46.000000000","message":"Ok.","commit_id":"c795f675561249adc905f3c72557a54c736dadd2"},{"author":{"_account_id":16373,"name":"Kazumasa Nomura","email":"kazumasa.nomura.rx@hitachi.com","username":"knomura"},"change_message_id":"e89e6a5cab2c21d33846357444208ddaa0c0dba6","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        default\u003dFalse,"},{"line_number":216,"context_line":"        help\u003d\u0027If True, the driver checks only host groups or iSCSI targets \u0027"},{"line_number":217,"context_line":"             \u0027that are most likely to be connected to the host. \u0027"},{"line_number":218,"context_line":"             \u0027Setting this option to True may improve the performance of \u0027"},{"line_number":219,"context_line":"             \u0027attaching or detaching volumes.\u0027),"},{"line_number":220,"context_line":"    cfg.ListOpt("},{"line_number":221,"context_line":"        \u0027vsp_horcm_pair_target_ports\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_11c0634f","line":218,"range":{"start_line":218,"start_character":36,"end_line":218,"end_character":48},"in_reply_to":"5a3905b3_ae6baf1c","updated":"2017-01-24 12:37:21.000000000","message":"Same as commit message.","commit_id":"c795f675561249adc905f3c72557a54c736dadd2"}]}