)]}'
{"cinder/objects/snapshot.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1712f792ea873266a7f3ee4c7e2637a3b837dd0c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            volume \u003d objects.Volume(context)"},{"line_number":139,"context_line":"            volume._from_db_object(context, volume, db_snapshot[\u0027volume\u0027])"},{"line_number":140,"context_line":"            snapshot.volume \u003d volume"},{"line_number":141,"context_line":"        if \u0027cgsnapshot\u0027 in expected_attrs:"},{"line_number":142,"context_line":"            cgsnapshot \u003d objects.CGSnapshot(context)"},{"line_number":143,"context_line":"            cgsnapshot._from_db_object(context, cgsnapshot,"},{"line_number":144,"context_line":"                                       db_snapshot[\u0027cgsnapshot\u0027])"},{"line_number":145,"context_line":"            snapshot.cgsnapshot \u003d cgsnapshot"},{"line_number":146,"context_line":"        if \u0027group_snapshot\u0027 in expected_attrs:"},{"line_number":147,"context_line":"            group_snapshot \u003d objects.GroupSnapshot(context)"},{"line_number":148,"context_line":"            group_snapshot._from_db_object(context, group_snapshot,"},{"line_number":149,"context_line":"                                           db_snapshot[\u0027group_snapshot\u0027])"},{"line_number":150,"context_line":"            snapshot.group_snapshot \u003d group_snapshot"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        if \u0027metadata\u0027 in expected_attrs:"},{"line_number":153,"context_line":"            metadata \u003d db_snapshot.get(\u0027snapshot_metadata\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_f0759f31","line":150,"range":{"start_line":141,"start_character":0,"end_line":150,"end_character":52},"updated":"2017-01-18 10:19:47.000000000","message":"This needs similar handling as well. We should simply check if db_snapshot[\u0027cgsnapshot\u0027] is None before doing anything.","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"9c2184205adaf15961cfca0ae76c231f096d7497","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            volume \u003d objects.Volume(context)"},{"line_number":139,"context_line":"            volume._from_db_object(context, volume, db_snapshot[\u0027volume\u0027])"},{"line_number":140,"context_line":"            snapshot.volume \u003d volume"},{"line_number":141,"context_line":"        if \u0027cgsnapshot\u0027 in expected_attrs:"},{"line_number":142,"context_line":"            cgsnapshot \u003d objects.CGSnapshot(context)"},{"line_number":143,"context_line":"            cgsnapshot._from_db_object(context, cgsnapshot,"},{"line_number":144,"context_line":"                                       db_snapshot[\u0027cgsnapshot\u0027])"},{"line_number":145,"context_line":"            snapshot.cgsnapshot \u003d cgsnapshot"},{"line_number":146,"context_line":"        if \u0027group_snapshot\u0027 in expected_attrs:"},{"line_number":147,"context_line":"            group_snapshot \u003d objects.GroupSnapshot(context)"},{"line_number":148,"context_line":"            group_snapshot._from_db_object(context, group_snapshot,"},{"line_number":149,"context_line":"                                           db_snapshot[\u0027group_snapshot\u0027])"},{"line_number":150,"context_line":"            snapshot.group_snapshot \u003d group_snapshot"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        if \u0027metadata\u0027 in expected_attrs:"},{"line_number":153,"context_line":"            metadata \u003d db_snapshot.get(\u0027snapshot_metadata\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_de721a7c","line":150,"range":{"start_line":141,"start_character":0,"end_line":150,"end_character":52},"in_reply_to":"7a3c09a3_9a2399bc","updated":"2017-01-19 22:09:38.000000000","message":"Done","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d4ef45413a67790b8558297fd32bc1918c624c0","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            volume \u003d objects.Volume(context)"},{"line_number":139,"context_line":"            volume._from_db_object(context, volume, db_snapshot[\u0027volume\u0027])"},{"line_number":140,"context_line":"            snapshot.volume \u003d volume"},{"line_number":141,"context_line":"        if \u0027cgsnapshot\u0027 in expected_attrs:"},{"line_number":142,"context_line":"            cgsnapshot \u003d objects.CGSnapshot(context)"},{"line_number":143,"context_line":"            cgsnapshot._from_db_object(context, cgsnapshot,"},{"line_number":144,"context_line":"                                       db_snapshot[\u0027cgsnapshot\u0027])"},{"line_number":145,"context_line":"            snapshot.cgsnapshot \u003d cgsnapshot"},{"line_number":146,"context_line":"        if \u0027group_snapshot\u0027 in expected_attrs:"},{"line_number":147,"context_line":"            group_snapshot \u003d objects.GroupSnapshot(context)"},{"line_number":148,"context_line":"            group_snapshot._from_db_object(context, group_snapshot,"},{"line_number":149,"context_line":"                                           db_snapshot[\u0027group_snapshot\u0027])"},{"line_number":150,"context_line":"            snapshot.group_snapshot \u003d group_snapshot"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        if \u0027metadata\u0027 in expected_attrs:"},{"line_number":153,"context_line":"            metadata \u003d db_snapshot.get(\u0027snapshot_metadata\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_9a2399bc","line":150,"range":{"start_line":141,"start_character":0,"end_line":150,"end_character":52},"in_reply_to":"7a3c09a3_f0759f31","updated":"2017-01-18 10:46:01.000000000","message":"-1: I agree, and it should be enough checking the group_snapshot_id and cgsnapshot_id and letting obj_load_attr do the assignment:\n \n if snapshot.cgsnapshot_id and \u0027cgsnapshot\u0027 in expected_attrs:\n     cgsnapshot \u003d objects.CGSnapshot(context)\n     cgsnapshot._from_db_object(context, cgsnapshot,\n                                db_snapshot[\u0027cgsnapshot\u0027])\n     snapshot.group_snapshot \u003d group_snapshot","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d4ef45413a67790b8558297fd32bc1918c624c0","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                                                   self.volume_id)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if attrname \u003d\u003d \u0027cgsnapshot\u0027:"},{"line_number":233,"context_line":"            try:"},{"line_number":234,"context_line":"                self.cgsnapshot \u003d objects.CGSnapshot.get_by_id("},{"line_number":235,"context_line":"                    self._context, self.cgsnapshot_id)"},{"line_number":236,"context_line":"            except exception.CgSnapshotNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_1a888970","line":233,"updated":"2017-01-18 10:46:01.000000000","message":"-1: This is not the right approach, as it would hide cases where cgsnapshot_id has an invalid value.  The right approach would be to do like I did in the services OVO for the cluster field [1] and check if cgsnapshot_id is None:\n\n if self.cgsnapshot_id:\n     self.cgsnapshot \u003d objects.CGSnapshot.get_by_id(\n         self._context, self.cgsnapshot_id)\n else:\n     self.cgsnapshot \u003d None\n\nThis will also save us from an unnecessary DB query.\n\n[1] https://github.com/openstack/cinder/blob/6f72616c55a5e63d00c822d2dad9b6962080da75/cinder/objects/service.py#L116","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"9c2184205adaf15961cfca0ae76c231f096d7497","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                                                   self.volume_id)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if attrname \u003d\u003d \u0027cgsnapshot\u0027:"},{"line_number":233,"context_line":"            try:"},{"line_number":234,"context_line":"                self.cgsnapshot \u003d objects.CGSnapshot.get_by_id("},{"line_number":235,"context_line":"                    self._context, self.cgsnapshot_id)"},{"line_number":236,"context_line":"            except exception.CgSnapshotNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_de205a4c","line":233,"in_reply_to":"7a3c09a3_1a888970","updated":"2017-01-19 22:09:38.000000000","message":"Done","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d4ef45413a67790b8558297fd32bc1918c624c0","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        if attrname \u003d\u003d \u0027group_snapshot\u0027:"},{"line_number":240,"context_line":"            try:"},{"line_number":241,"context_line":"                self.group_snapshot \u003d objects.GroupSnapshot.get_by_id("},{"line_number":242,"context_line":"                    self._context,"},{"line_number":243,"context_line":"                    self.group_snapshot_id)"},{"line_number":244,"context_line":"            except exception.GroupSnapshotNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_3a7b857c","line":241,"updated":"2017-01-18 10:46:01.000000000","message":"-1: Same here","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"9c2184205adaf15961cfca0ae76c231f096d7497","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        if attrname \u003d\u003d \u0027group_snapshot\u0027:"},{"line_number":240,"context_line":"            try:"},{"line_number":241,"context_line":"                self.group_snapshot \u003d objects.GroupSnapshot.get_by_id("},{"line_number":242,"context_line":"                    self._context,"},{"line_number":243,"context_line":"                    self.group_snapshot_id)"},{"line_number":244,"context_line":"            except exception.GroupSnapshotNotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_fe1d1610","line":241,"in_reply_to":"7a3c09a3_3a7b857c","updated":"2017-01-19 22:09:38.000000000","message":"Done","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b671c5ca1d1ae5fab9790d661fbca9c8d60a92bf","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                                                   self.volume_id)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if attrname \u003d\u003d \u0027cgsnapshot\u0027:"},{"line_number":233,"context_line":"            if self.cgsnapshot_id is None:"},{"line_number":234,"context_line":"                self.cgsnapshot \u003d None"},{"line_number":235,"context_line":"            else:"},{"line_number":236,"context_line":"                self.cgsnapshot \u003d objects.CGSnapshot.get_by_id("}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_47f2c4d3","line":233,"updated":"2017-01-20 09:53:25.000000000","message":"nit: I usually prefer to check how I mention on previous patch or use `not self.cgsnapshot_id` just in case we end up with an empty string in the field.","commit_id":"e0aff5b117fb94b9c9c715f49cf0dc109cce78c4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b671c5ca1d1ae5fab9790d661fbca9c8d60a92bf","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                self.cgsnapshot \u003d objects.CGSnapshot.get_by_id("},{"line_number":237,"context_line":"                    self._context, self.cgsnapshot_id)"},{"line_number":238,"context_line":"        if attrname \u003d\u003d \u0027group_snapshot\u0027:"},{"line_number":239,"context_line":"            if self.group_snapshot_id is None:"},{"line_number":240,"context_line":"                self.group_snapshot \u003d None"},{"line_number":241,"context_line":"            else:"},{"line_number":242,"context_line":"                self.group_snapshot \u003d objects.GroupSnapshot.get_by_id("}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_e7b730f3","line":239,"updated":"2017-01-20 09:53:25.000000000","message":"ditto","commit_id":"e0aff5b117fb94b9c9c715f49cf0dc109cce78c4"}],"cinder/objects/volume.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1712f792ea873266a7f3ee4c7e2637a3b837dd0c","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                objects.VolumeAttachment,"},{"line_number":282,"context_line":"                db_volume.get(\u0027volume_attachment\u0027))"},{"line_number":283,"context_line":"            volume.volume_attachment \u003d attachments"},{"line_number":284,"context_line":"        if \u0027consistencygroup\u0027 in expected_attrs:"},{"line_number":285,"context_line":"            consistencygroup \u003d objects.ConsistencyGroup(context)"},{"line_number":286,"context_line":"            consistencygroup._from_db_object(context,"},{"line_number":287,"context_line":"                                             consistencygroup,"},{"line_number":288,"context_line":"                                             db_volume[\u0027consistencygroup\u0027])"},{"line_number":289,"context_line":"            volume.consistencygroup \u003d consistencygroup"},{"line_number":290,"context_line":"        if \u0027snapshots\u0027 in expected_attrs:"},{"line_number":291,"context_line":"            snapshots \u003d base.obj_make_list("},{"line_number":292,"context_line":"                context, objects.SnapshotList(context),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_10bf8baa","line":289,"range":{"start_line":284,"start_character":0,"end_line":289,"end_character":54},"updated":"2017-01-18 10:19:47.000000000","message":"Same here, we should add same check as in line 271.","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d4ef45413a67790b8558297fd32bc1918c624c0","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                objects.VolumeAttachment,"},{"line_number":282,"context_line":"                db_volume.get(\u0027volume_attachment\u0027))"},{"line_number":283,"context_line":"            volume.volume_attachment \u003d attachments"},{"line_number":284,"context_line":"        if \u0027consistencygroup\u0027 in expected_attrs:"},{"line_number":285,"context_line":"            consistencygroup \u003d objects.ConsistencyGroup(context)"},{"line_number":286,"context_line":"            consistencygroup._from_db_object(context,"},{"line_number":287,"context_line":"                                             consistencygroup,"},{"line_number":288,"context_line":"                                             db_volume[\u0027consistencygroup\u0027])"},{"line_number":289,"context_line":"            volume.consistencygroup \u003d consistencygroup"},{"line_number":290,"context_line":"        if \u0027snapshots\u0027 in expected_attrs:"},{"line_number":291,"context_line":"            snapshots \u003d base.obj_make_list("},{"line_number":292,"context_line":"                context, objects.SnapshotList(context),"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_9dad53eb","line":289,"range":{"start_line":284,"start_character":0,"end_line":289,"end_character":54},"in_reply_to":"7a3c09a3_10bf8baa","updated":"2017-01-18 10:46:01.000000000","message":"-1: I think it\u0027s better to check the ids, as I mention in the snapshot file, as it\u0027s cleaner.","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"9c2184205adaf15961cfca0ae76c231f096d7497","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                objects.VolumeAttachment,"},{"line_number":282,"context_line":"                db_volume.get(\u0027volume_attachment\u0027))"},{"line_number":283,"context_line":"            volume.volume_attachment \u003d attachments"},{"line_number":284,"context_line":"        if \u0027consistencygroup\u0027 in expected_attrs:"},{"line_number":285,"context_line":"            consistencygroup \u003d objects.ConsistencyGroup(context)"},{"line_number":286,"context_line":"            consistencygroup._from_db_object(context,"},{"line_number":287,"context_line":"                                             consistencygroup,"},{"line_number":288,"context_line":"                                             db_volume[\u0027consistencygroup\u0027])"},{"line_number":289,"context_line":"            volume.consistencygroup \u003d consistencygroup"},{"line_number":290,"context_line":"        if \u0027snapshots\u0027 in expected_attrs:"},{"line_number":291,"context_line":"            snapshots \u003d base.obj_make_list("},{"line_number":292,"context_line":"                context, objects.SnapshotList(context),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_fef6f6d5","line":289,"range":{"start_line":284,"start_character":0,"end_line":289,"end_character":54},"in_reply_to":"7a3c09a3_9dad53eb","updated":"2017-01-19 22:09:38.000000000","message":"Done","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1712f792ea873266a7f3ee4c7e2637a3b837dd0c","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                                                db_cluster)"},{"line_number":304,"context_line":"            else:"},{"line_number":305,"context_line":"                volume.cluster \u003d None"},{"line_number":306,"context_line":"        if \u0027group\u0027 in expected_attrs:"},{"line_number":307,"context_line":"            group \u003d objects.Group(context)"},{"line_number":308,"context_line":"            group._from_db_object(context,"},{"line_number":309,"context_line":"                                  group,"},{"line_number":310,"context_line":"                                  db_volume[\u0027group\u0027])"},{"line_number":311,"context_line":"            volume.group \u003d group"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        volume._context \u003d context"},{"line_number":314,"context_line":"        volume.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_30e007cd","line":311,"range":{"start_line":306,"start_character":0,"end_line":311,"end_character":32},"updated":"2017-01-18 10:19:47.000000000","message":"ditto","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d4ef45413a67790b8558297fd32bc1918c624c0","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                                                db_cluster)"},{"line_number":304,"context_line":"            else:"},{"line_number":305,"context_line":"                volume.cluster \u003d None"},{"line_number":306,"context_line":"        if \u0027group\u0027 in expected_attrs:"},{"line_number":307,"context_line":"            group \u003d objects.Group(context)"},{"line_number":308,"context_line":"            group._from_db_object(context,"},{"line_number":309,"context_line":"                                  group,"},{"line_number":310,"context_line":"                                  db_volume[\u0027group\u0027])"},{"line_number":311,"context_line":"            volume.group \u003d group"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        volume._context \u003d context"},{"line_number":314,"context_line":"        volume.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_ddb8bb13","line":311,"range":{"start_line":306,"start_character":0,"end_line":311,"end_character":32},"in_reply_to":"7a3c09a3_30e007cd","updated":"2017-01-18 10:46:01.000000000","message":"-1: I believe we have more OVOs suffering from this problem, but it would be good to fix at least this cases for now.","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"9c2184205adaf15961cfca0ae76c231f096d7497","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                                                db_cluster)"},{"line_number":304,"context_line":"            else:"},{"line_number":305,"context_line":"                volume.cluster \u003d None"},{"line_number":306,"context_line":"        if \u0027group\u0027 in expected_attrs:"},{"line_number":307,"context_line":"            group \u003d objects.Group(context)"},{"line_number":308,"context_line":"            group._from_db_object(context,"},{"line_number":309,"context_line":"                                  group,"},{"line_number":310,"context_line":"                                  db_volume[\u0027group\u0027])"},{"line_number":311,"context_line":"            volume.group \u003d group"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        volume._context \u003d context"},{"line_number":314,"context_line":"        volume.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_1e04a2be","line":311,"range":{"start_line":306,"start_character":0,"end_line":311,"end_character":32},"in_reply_to":"7a3c09a3_ddb8bb13","updated":"2017-01-19 22:09:38.000000000","message":"Done","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d4ef45413a67790b8558297fd32bc1918c624c0","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                self._context, self.id)"},{"line_number":424,"context_line":"            self.volume_attachment \u003d attachments"},{"line_number":425,"context_line":"        elif attrname \u003d\u003d \u0027consistencygroup\u0027:"},{"line_number":426,"context_line":"            try:"},{"line_number":427,"context_line":"                consistencygroup \u003d objects.ConsistencyGroup.get_by_id("},{"line_number":428,"context_line":"                    self._context, self.consistencygroup_id)"},{"line_number":429,"context_line":"                self.consistencygroup \u003d consistencygroup"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_7d16e74c","line":426,"range":{"start_line":426,"start_character":14,"end_line":426,"end_character":15},"updated":"2017-01-18 10:46:01.000000000","message":"-1: Same as in snapshot OVO","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"9c2184205adaf15961cfca0ae76c231f096d7497","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                self._context, self.id)"},{"line_number":424,"context_line":"            self.volume_attachment \u003d attachments"},{"line_number":425,"context_line":"        elif attrname \u003d\u003d \u0027consistencygroup\u0027:"},{"line_number":426,"context_line":"            try:"},{"line_number":427,"context_line":"                consistencygroup \u003d objects.ConsistencyGroup.get_by_id("},{"line_number":428,"context_line":"                    self._context, self.consistencygroup_id)"},{"line_number":429,"context_line":"                self.consistencygroup \u003d consistencygroup"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_5e054ac0","line":426,"range":{"start_line":426,"start_character":14,"end_line":426,"end_character":15},"in_reply_to":"7a3c09a3_7d16e74c","updated":"2017-01-19 22:09:38.000000000","message":"Done","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d4ef45413a67790b8558297fd32bc1918c624c0","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            else:"},{"line_number":442,"context_line":"                self.cluster \u003d None"},{"line_number":443,"context_line":"        elif attrname \u003d\u003d \u0027group\u0027:"},{"line_number":444,"context_line":"            try:"},{"line_number":445,"context_line":"                group \u003d objects.Group.get_by_id("},{"line_number":446,"context_line":"                    self._context, self.group_id)"},{"line_number":447,"context_line":"                self.group \u003d group"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_9d11d354","line":444,"updated":"2017-01-18 10:46:01.000000000","message":"-1: Same as in snapshot OVO","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"9c2184205adaf15961cfca0ae76c231f096d7497","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            else:"},{"line_number":442,"context_line":"                self.cluster \u003d None"},{"line_number":443,"context_line":"        elif attrname \u003d\u003d \u0027group\u0027:"},{"line_number":444,"context_line":"            try:"},{"line_number":445,"context_line":"                group \u003d objects.Group.get_by_id("},{"line_number":446,"context_line":"                    self._context, self.group_id)"},{"line_number":447,"context_line":"                self.group \u003d group"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_be146ef5","line":444,"in_reply_to":"7a3c09a3_9d11d354","updated":"2017-01-19 22:09:38.000000000","message":"Done","commit_id":"2a0f305aa1f7bfc9604db2ba4e56e148aa47a7f2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b671c5ca1d1ae5fab9790d661fbca9c8d60a92bf","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                self._context, self.id)"},{"line_number":424,"context_line":"            self.volume_attachment \u003d attachments"},{"line_number":425,"context_line":"        elif attrname \u003d\u003d \u0027consistencygroup\u0027:"},{"line_number":426,"context_line":"            if self.consistencygroup_id is None:"},{"line_number":427,"context_line":"                self.consistencygroup \u003d None"},{"line_number":428,"context_line":"            else:"},{"line_number":429,"context_line":"                consistencygroup \u003d objects.ConsistencyGroup.get_by_id("}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_a7e0c8cd","line":426,"updated":"2017-01-20 09:53:25.000000000","message":"same here","commit_id":"e0aff5b117fb94b9c9c715f49cf0dc109cce78c4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b671c5ca1d1ae5fab9790d661fbca9c8d60a92bf","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            else:"},{"line_number":442,"context_line":"                self.cluster \u003d None"},{"line_number":443,"context_line":"        elif attrname \u003d\u003d \u0027group\u0027:"},{"line_number":444,"context_line":"            if self.group_id is None:"},{"line_number":445,"context_line":"                self.group \u003d None"},{"line_number":446,"context_line":"            else:"},{"line_number":447,"context_line":"                group \u003d objects.Group.get_by_id("}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_07d27c00","line":444,"updated":"2017-01-20 09:53:25.000000000","message":"and here","commit_id":"e0aff5b117fb94b9c9c715f49cf0dc109cce78c4"}]}