)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d72b5a149e2d9864a285711e32dd81d0c2adcb86","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhao Liqiang \u003czhaoliqiang@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-13 11:33:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RBD: get replication flags from \u0027diff\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are two types of volume_type, it can be an instance of"},{"line_number":10,"context_line":"VolumeType or dictionary, because the cinder api or volume"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff0f0b1f_a65e0be7","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":39},"updated":"2017-05-26 00:13:49.000000000","message":"Summary lines don\u0027t need a \u0027.\u0027 at the end of the line","commit_id":"a091ebe0640e86386806ea0e35b3309da6daa6f3"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d72b5a149e2d9864a285711e32dd81d0c2adcb86","unresolved":false,"context_lines":[{"line_number":10,"context_line":"VolumeType or dictionary, because the cinder api or volume"},{"line_number":11,"context_line":"manager get it by using different database api. When retyping a"},{"line_number":12,"context_line":"volume, the manager gets the new volume_type by using volume_type"},{"line_number":13,"context_line":"id, and the database api converts the qeury result to dictionary."},{"line_number":14,"context_line":"In other cases, if volume_type is just a part of a volume, we get"},{"line_number":15,"context_line":"it at the same time when getting the volume from database by using"},{"line_number":16,"context_line":"volume_id, and the database api will not convert the result to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff0f0b1f_06f497ce","line":13,"range":{"start_line":13,"start_character":38,"end_line":13,"end_character":43},"updated":"2017-05-26 00:13:49.000000000","message":"s/qeury/query","commit_id":"a091ebe0640e86386806ea0e35b3309da6daa6f3"}],"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"258493a74694a401027810d944187405d7f82f17","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"        diff \u003d {\u0027encryption\u0027: {}, \u0027qos_specs\u0027: {},"},{"line_number":1399,"context_line":"                \u0027extra_specs\u0027: {\u0027replication_enabled\u0027:"},{"line_number":1400,"context_line":"                                (old_replicated, new_replicated)}}"},{"line_number":1401,"context_line":"        res \u003d self.driver.retype(self.context, self.volume_a, new_type, diff,"},{"line_number":1402,"context_line":"                                 None)"},{"line_number":1403,"context_line":"        self.assertEqual((True, update), res)"},{"line_number":1404,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_8de7c145","line":1401,"updated":"2017-01-24 17:23:03.000000000","message":"This fixes the existing test to not break, but I think it would be good to have an additional test to verify the new _is_replicated_type() logic so that we can catch a regression if it\u0027s introduced in the future.","commit_id":"8c277f1385c2cea89dbeac85d111265677cef605"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"258493a74694a401027810d944187405d7f82f17","unresolved":false,"context_lines":[{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        if replicated_diff:"},{"line_number":882,"context_line":"            old_vol_replicated \u003d bool(replicated_diff[0])"},{"line_number":883,"context_line":"            new_vol_replicated \u003d bool(replicated_diff[1])"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"        if old_vol_replicated and not new_vol_replicated:"},{"line_number":886,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_6d47f54b","line":883,"updated":"2017-01-24 17:23:03.000000000","message":"Have you considered including this logic in _is_replicated_type() instead?  I think that would be a better place for this logic.","commit_id":"8c277f1385c2cea89dbeac85d111265677cef605"}]}