)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"8ead43b7c6b487cd6ab71190bccf59209570217f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vijay Ladani \u003cvijay.ladani@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-25 06:51:51 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"rally test create-volume-from-snapshot fails"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Rally test executes below steps"},{"line_number":10,"context_line":"1. create snapshot (successful)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a461143_2831ff05","line":7,"updated":"2017-01-27 07:13:11.000000000","message":"prepend this with 3PAR\n\notherwise reviewers think this patch is for cinder in general.","commit_id":"322bca12f318f6b70ef7637fca9c6d1f29e92d04"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"5113ee7d4d7fa5bb96593d48ed96ff059b1cd0d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vijay Ladani \u003cvijay.ladani@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-25 06:51:51 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"rally test create-volume-from-snapshot fails"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Rally test executes below steps"},{"line_number":10,"context_line":"1. create snapshot (successful)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a461143_d19d825a","line":7,"in_reply_to":"3a461143_2831ff05","updated":"2017-01-27 09:11:31.000000000","message":"Done","commit_id":"322bca12f318f6b70ef7637fca9c6d1f29e92d04"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3db2a1a8a5d13cd49e5569ea69970db81762e577","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"3par driver creates child and parent relationship"},{"line_number":16,"context_line":"while creating volume from snapshot. Proposed code"},{"line_number":17,"context_line":"change will create indipendent volume from snapshot."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Modified unit tests according to driver code change."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a461143_7b16cbf2","line":17,"range":{"start_line":17,"start_character":19,"end_line":17,"end_character":30},"updated":"2017-02-01 14:49:32.000000000","message":"nit: independent","commit_id":"2406b7a59eb41ed5c1a28e78999443bafed0ec12"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"8ead43b7c6b487cd6ab71190bccf59209570217f","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"            if growth_size \u003e 0:"},{"line_number":2213,"context_line":"                try:"},{"line_number":2214,"context_line":"                    LOG.debug(\u0027Converting to base volume type: %s.\u0027,"},{"line_number":2215,"context_line":"                              volume[\u0027id\u0027])"},{"line_number":2216,"context_line":"                    growth_size_mib \u003d growth_size * units.Gi / units.Mi"},{"line_number":2217,"context_line":"                    LOG.debug(\u0027Growing volume: %(id)s by %(size)s GiB.\u0027,"},{"line_number":2218,"context_line":"                              {\u0027id\u0027: volume[\u0027id\u0027], \u0027size\u0027: growth_size})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_881cb378","line":2215,"updated":"2017-01-27 07:13:11.000000000","message":"you are converting to base volume on line 2210, but yet you left the logging of that action here.","commit_id":"322bca12f318f6b70ef7637fca9c6d1f29e92d04"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"5113ee7d4d7fa5bb96593d48ed96ff059b1cd0d3","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"            if growth_size \u003e 0:"},{"line_number":2213,"context_line":"                try:"},{"line_number":2214,"context_line":"                    LOG.debug(\u0027Converting to base volume type: %s.\u0027,"},{"line_number":2215,"context_line":"                              volume[\u0027id\u0027])"},{"line_number":2216,"context_line":"                    growth_size_mib \u003d growth_size * units.Gi / units.Mi"},{"line_number":2217,"context_line":"                    LOG.debug(\u0027Growing volume: %(id)s by %(size)s GiB.\u0027,"},{"line_number":2218,"context_line":"                              {\u0027id\u0027: volume[\u0027id\u0027], \u0027size\u0027: growth_size})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_b1b1d6e3","line":2215,"in_reply_to":"3a461143_881cb378","updated":"2017-01-27 09:11:31.000000000","message":"You are right Walt. Done the required changes. Thanks!","commit_id":"322bca12f318f6b70ef7637fca9c6d1f29e92d04"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3db2a1a8a5d13cd49e5569ea69970db81762e577","unresolved":false,"context_lines":[{"line_number":2237,"context_line":"            # Convert snapshot volume to base volume type"},{"line_number":2238,"context_line":"            LOG.debug(\u0027Converting to base volume type: %s.\u0027,"},{"line_number":2239,"context_line":"                      volume[\u0027id\u0027])"},{"line_number":2240,"context_line":"            model_update \u003d self._convert_to_base_volume(volume)"},{"line_number":2241,"context_line":""},{"line_number":2242,"context_line":"            # Grow the snapshot if needed"},{"line_number":2243,"context_line":"            growth_size \u003d volume[\u0027size\u0027] - snapshot[\u0027volume_size\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_bb63d340","line":2240,"updated":"2017-02-01 14:49:32.000000000","message":"So you moved this code from inside the \"if growth_size \u003e 0\" block to here, so that this will be called for all cases.  The commit message didn\u0027t explain this.  Can you add this to the commit message?","commit_id":"2406b7a59eb41ed5c1a28e78999443bafed0ec12"}]}