)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"847fe915d9c13634e6164cc1218711edbdd67b60","unresolved":false,"context_lines":[{"line_number":15,"context_line":"getting the extra_specs information to the related type,"},{"line_number":16,"context_line":"but extra_specs is only avaiable in admin context."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-on: I5e977ed412cf4a1614d7728ffe7898435291fcc3"},{"line_number":19,"context_line":"Change-Id: Id9f39ddab3a3648b8721b711ecf78c18c8293451"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a3905b3_bc153f9c","line":18,"updated":"2017-01-20 09:38:59.000000000","message":"nit: You should remove this, it should not be used for same project dependencies.","commit_id":"485b6f1851be632b10c25c069fd18f0c456f76bc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"847fe915d9c13634e6164cc1218711edbdd67b60","unresolved":false,"context_lines":[{"line_number":16,"context_line":"but extra_specs is only avaiable in admin context."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-on: I5e977ed412cf4a1614d7728ffe7898435291fcc3"},{"line_number":19,"context_line":"Change-Id: Id9f39ddab3a3648b8721b711ecf78c18c8293451"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a3905b3_dc5a0b83","line":19,"updated":"2017-01-20 09:38:59.000000000","message":"-1: Missing\n\n Closes-bug: #1657806\n\nAnd you should update the bug to assign it to you to avoid somebody else working on it.","commit_id":"485b6f1851be632b10c25c069fd18f0c456f76bc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"662a22f846a8da2979a9d75c3cd1ba0d3a830e52","unresolved":false,"context_lines":[{"line_number":16,"context_line":"but extra_specs is only avaiable in admin context."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-bug: #1657806"},{"line_number":19,"context_line":"Depends-on: I5e977ed412cf4a1614d7728ffe7898435291fcc3"},{"line_number":20,"context_line":"Change-Id: Id9f39ddab3a3648b8721b711ecf78c18c8293451"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a3905b3_8e722eac","line":19,"updated":"2017-01-25 12:34:46.000000000","message":"nit: Please remove this depends on, since we shouldn\u0027t use it for in-project dependencies.","commit_id":"623a1886edeb08579f42d01f17d0e25b25676c3c"}],"cinder/tests/unit/test_volume.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"662a22f846a8da2979a9d75c3cd1ba0d3a830e52","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    snap \u003d objects.Snapshot(ctxt or context.get_admin_context())"},{"line_number":104,"context_line":"    snap.volume_size \u003d size"},{"line_number":105,"context_line":"    snap.user_id \u003d kwargs.get(\u0027user\u0027, fake.USER_ID)"},{"line_number":106,"context_line":"    snap.project_id \u003d kwargs.get(\u0027project\u0027, fake.PROJECT_ID)"},{"line_number":107,"context_line":"    snap.volume_id \u003d volume_id"},{"line_number":108,"context_line":"    snap.status \u003d \"creating\""},{"line_number":109,"context_line":"    if metadata is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_6e56e207","line":106,"range":{"start_line":106,"start_character":34,"end_line":106,"end_character":41},"updated":"2017-01-25 12:34:46.000000000","message":"nit: project_id","commit_id":"623a1886edeb08579f42d01f17d0e25b25676c3c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"662a22f846a8da2979a9d75c3cd1ba0d3a830e52","unresolved":false,"context_lines":[{"line_number":5546,"context_line":"        volume.save()"},{"line_number":5547,"context_line":"        if snap:"},{"line_number":5548,"context_line":"            create_snapshot(volume.id, size\u003dvolume.size,"},{"line_number":5549,"context_line":"                            user\u003dself.context.user_id,"},{"line_number":5550,"context_line":"                            project\u003dself.context.project_id,"},{"line_number":5551,"context_line":"                            ctxt\u003dself.user_context)"},{"line_number":5552,"context_line":"        if driver or diff_equal:"},{"line_number":5553,"context_line":"            host_obj \u003d {\u0027host\u0027: CONF.host, \u0027capabilities\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_ee1c926c","line":5550,"range":{"start_line":5549,"start_character":27,"end_line":5550,"end_character":60},"updated":"2017-01-25 12:34:46.000000000","message":"-1: We should use self.user_context here instead, right?","commit_id":"623a1886edeb08579f42d01f17d0e25b25676c3c"}],"cinder/tests/unit/volume/__init__.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"662a22f846a8da2979a9d75c3cd1ba0d3a830e52","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.user_context \u003d context.RequestContext(user_id\u003dfake.USER_ID,"},{"line_number":61,"context_line":"                                                   project_id\u003dself.project_id,"},{"line_number":62,"context_line":"                                                   is_admin\u003dFalse)"},{"line_number":63,"context_line":"        self.context.user_id \u003d fake.USER_ID"},{"line_number":64,"context_line":"        self.context.project_id \u003d self.project_id"},{"line_number":65,"context_line":"        self.volume_params \u003d {"},{"line_number":66,"context_line":"            \u0027status\u0027: \u0027creating\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_331c4777","line":63,"updated":"2017-01-25 12:34:46.000000000","message":"nit: Please don\u0027t move this line and leave it were it was","commit_id":"623a1886edeb08579f42d01f17d0e25b25676c3c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"16092f4c0be5275fdef7cefdfc42751e4f1ba3e0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # assertions with the notification code, it\u0027s part of an"},{"line_number":57,"context_line":"        # elastic-recheck query so don\u0027t remove it or change it."},{"line_number":58,"context_line":"        self.project_id \u003d \u00277f265bd4-3a85-465e-a899-5dc4854a86d3\u0027"},{"line_number":59,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":60,"context_line":"        self.user_context \u003d context.RequestContext(user_id\u003dfake.USER_ID,"},{"line_number":61,"context_line":"                                                   project_id\u003dself.project_id,"},{"line_number":62,"context_line":"                                                   is_admin\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a461143_a268ff88","line":59,"updated":"2017-02-01 17:39:05.000000000","message":"nit: I still believe this should not be moved from where it was.","commit_id":"730e5d2e625417af026fc4fb7915a1bbbb6b6842"}],"cinder/tests/unit/volume/test_volume_migration.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d81c5909d05765b5cf2c78ec764607aed16633b8","unresolved":false,"context_lines":[{"line_number":753,"context_line":"                mock.patch.object(context.RequestContext, \u0027elevated\u0027) as _ctx:"},{"line_number":754,"context_line":"            _vget.return_value \u003d volume"},{"line_number":755,"context_line":"            _retype.return_value \u003d driver"},{"line_number":756,"context_line":"            _ctx.return_value \u003d self.context"},{"line_number":757,"context_line":"            returned_diff \u003d {"},{"line_number":758,"context_line":"                \u0027encryption\u0027: {},"},{"line_number":759,"context_line":"                \u0027qos_specs\u0027: {},"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa31d9ce_5e8caed9","line":756,"updated":"2017-02-15 20:06:40.000000000","message":"nit: We should be checking that this is actually being called.","commit_id":"7aecdf919c16a4e06389c1354a531d55057e2566"}],"cinder/volume/manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"37db536d5c3d80986059fff8a7c220d29f48c8fc","unresolved":false,"context_lines":[{"line_number":2332,"context_line":"                new_type \u003d volume_types.get_volume_type(context.elevated(),"},{"line_number":2333,"context_line":"                                                        new_type_id)"},{"line_number":2334,"context_line":"                ret \u003d self.driver.retype(context,"},{"line_number":2335,"context_line":"                                         volume,"},{"line_number":2336,"context_line":"                                         new_type,"},{"line_number":2337,"context_line":"                                         diff,"},{"line_number":2338,"context_line":"                                         host)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a430d35_2d55924f","line":2335,"updated":"2017-02-06 13:09:27.000000000","message":"-1: This breaks with the RBD driver because in it we are checking the extra specs for the type of the volume to see if the source is replicated, so we need to pass the elevated volume here as well.","commit_id":"0fe5ca622903a7bf1fde8eee592668e42b7222e0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4f015c8fd4ba1632be798294cade9051e86d191b","unresolved":false,"context_lines":[{"line_number":2332,"context_line":"                new_type \u003d volume_types.get_volume_type(context.elevated(),"},{"line_number":2333,"context_line":"                                                        new_type_id)"},{"line_number":2334,"context_line":"                ret \u003d self.driver.retype(context,"},{"line_number":2335,"context_line":"                                         volume,"},{"line_number":2336,"context_line":"                                         new_type,"},{"line_number":2337,"context_line":"                                         diff,"},{"line_number":2338,"context_line":"                                         host)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a430d35_67c30dee","line":2335,"in_reply_to":"1a430d35_1ff9c54d","updated":"2017-02-07 09:46:31.000000000","message":"It was thanks to the experimental job that I noticed the issue.  :-)","commit_id":"0fe5ca622903a7bf1fde8eee592668e42b7222e0"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"56cd96ac12607e859a08572a0ad46c1b7174e660","unresolved":false,"context_lines":[{"line_number":2332,"context_line":"                new_type \u003d volume_types.get_volume_type(context.elevated(),"},{"line_number":2333,"context_line":"                                                        new_type_id)"},{"line_number":2334,"context_line":"                ret \u003d self.driver.retype(context,"},{"line_number":2335,"context_line":"                                         volume,"},{"line_number":2336,"context_line":"                                         new_type,"},{"line_number":2337,"context_line":"                                         diff,"},{"line_number":2338,"context_line":"                                         host)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a430d35_1ff9c54d","line":2335,"in_reply_to":"1a430d35_2d55924f","updated":"2017-02-06 20:29:09.000000000","message":"Good pick! Done.","commit_id":"0fe5ca622903a7bf1fde8eee592668e42b7222e0"}]}