)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"76486326b1fc463506f4dc05e1a6a767108d282c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VNX: Update sg cache if it already existed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This can avoid redundant sg creation during volume attachment, thus belifiting"},{"line_number":10,"context_line":"the overall driver performance."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I1d96468248d512b59f77ab93d486efb3ff29d6ca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a3905b3_cea6da52","line":9,"updated":"2017-01-20 04:20:18.000000000","message":"Are you trying to say \"benefiting\"?  Also please wrap at 72 chars.","commit_id":"9b5fca8fac856737ac832be1eacb4cf17b17d033"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"374eae3cbc461724e079913eb9ced8ff1b8555e9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VNX: Update sg cache if it already existed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This can avoid redundant sg creation during volume attachment, thus belifiting"},{"line_number":10,"context_line":"the overall driver performance."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I1d96468248d512b59f77ab93d486efb3ff29d6ca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a3905b3_1162c7ad","line":9,"in_reply_to":"5a3905b3_cea6da52","updated":"2017-01-20 04:41:27.000000000","message":"Yeah...fix above typos.","commit_id":"9b5fca8fac856737ac832be1eacb4cf17b17d033"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"76486326b1fc463506f4dc05e1a6a767108d282c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This can avoid redundant sg creation during volume attachment, thus belifiting"},{"line_number":10,"context_line":"the overall driver performance."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I1d96468248d512b59f77ab93d486efb3ff29d6ca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a3905b3_4e710ae0","line":11,"updated":"2017-01-20 04:20:18.000000000","message":"Can you open a bug to track this and reference it here, especially if it is a critical issue?","commit_id":"9b5fca8fac856737ac832be1eacb4cf17b17d033"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"374eae3cbc461724e079913eb9ced8ff1b8555e9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This can avoid redundant sg creation during volume attachment, thus belifiting"},{"line_number":10,"context_line":"the overall driver performance."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I1d96468248d512b59f77ab93d486efb3ff29d6ca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a3905b3_515c4fed","line":11,"in_reply_to":"5a3905b3_4e710ae0","updated":"2017-01-20 04:41:27.000000000","message":"Done","commit_id":"9b5fca8fac856737ac832be1eacb4cf17b17d033"}],"cinder/volume/drivers/dell_emc/vnx/client.py":[{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"5e7c7ca48dfb238efe951301cd5c7bef40ff35ef","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            LOG.warning(_LW(\u0027Storage group %(name)s already exists. \u0027"},{"line_number":405,"context_line":"                            \u0027Message: %(msg)s\u0027),"},{"line_number":406,"context_line":"                        {\u0027name\u0027: name, \u0027msg\u0027: ex.message})"},{"line_number":407,"context_line":"            self.sg_cache[name] \u003d self.vnx.get_sg(name\u003dname)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"            return self.sg_cache[name]"},{"line_number":410,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_1a5bc188","line":407,"updated":"2017-01-20 03:40:39.000000000","message":"Should the cache be updated as well when creating the storage group successfully?","commit_id":"9b5fca8fac856737ac832be1eacb4cf17b17d033"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"374eae3cbc461724e079913eb9ced8ff1b8555e9","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            LOG.warning(_LW(\u0027Storage group %(name)s already exists. \u0027"},{"line_number":405,"context_line":"                            \u0027Message: %(msg)s\u0027),"},{"line_number":406,"context_line":"                        {\u0027name\u0027: name, \u0027msg\u0027: ex.message})"},{"line_number":407,"context_line":"            self.sg_cache[name] \u003d self.vnx.get_sg(name\u003dname)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"            return self.sg_cache[name]"},{"line_number":410,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_91f5d7cc","line":407,"in_reply_to":"5a3905b3_1a5bc188","updated":"2017-01-20 04:41:27.000000000","message":"Add to cache after creation done.","commit_id":"9b5fca8fac856737ac832be1eacb4cf17b17d033"}]}
