)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"fd051251ca47712b1e5a605927725beb439450ff","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangsong \u003czhangsong@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-20 18:17:28 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move RBDVolume calls to a separate threads"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RBD is a python binding for librados which isn\u0027t patched by eventlet."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a3905b3_95f0ad68","line":7,"updated":"2017-01-24 17:15:44.000000000","message":"Not a big deal, but I like to prefix the subject with \u0027RBD: \u0027, it makes it easier to spot in a list or changelog.","commit_id":"de564787f8de20a9f34cc3b358fe78e6c997c6c6"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"fd051251ca47712b1e5a605927725beb439450ff","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            self.volume \u003d driver.rbd.Image(ioctx,"},{"line_number":117,"context_line":"                                           utils.convert_str(name),"},{"line_number":118,"context_line":"                                           snapshot\u003dsnapshot,"},{"line_number":119,"context_line":"                                           read_only\u003dread_only)"},{"line_number":120,"context_line":"        except driver.rbd.Error:"},{"line_number":121,"context_line":"            LOG.exception(_LE(\"error opening rbd image %s\"), name)"},{"line_number":122,"context_line":"            driver._disconnect_from_rados(client, ioctx)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_f58491d3","line":119,"updated":"2017-01-24 17:15:44.000000000","message":"I think it would be more readable to enclose the Image here, instead of a later assignment.","commit_id":"de564787f8de20a9f34cc3b358fe78e6c997c6c6"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"f638b58d0e57be682033b1d20678503622935ed0","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            snapshot \u003d utils.convert_str(snapshot)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            self.volume \u003d driver.rbd.Image(ioctx,"},{"line_number":117,"context_line":"                                           utils.convert_str(name),"},{"line_number":118,"context_line":"                                           snapshot\u003dsnapshot,"},{"line_number":119,"context_line":"                                           read_only\u003dread_only)"},{"line_number":120,"context_line":"            self.volume \u003d tpool.Proxy(self.volume)"},{"line_number":121,"context_line":"        except driver.rbd.Error:"},{"line_number":122,"context_line":"            LOG.exception(_LE(\"error opening rbd image %s\"), name)"},{"line_number":123,"context_line":"            driver._disconnect_from_rados(client, ioctx)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_493b8a9c","line":120,"range":{"start_line":116,"start_character":0,"end_line":120,"end_character":50},"updated":"2017-03-09 08:43:00.000000000","message":"Could those be merged as one?","commit_id":"8f2b7f4f20727d35d0dce25fddb5a879f26c9614"},{"author":{"_account_id":18967,"name":"zhangsong","email":"zhangsong@cmss.chinamobile.com","username":"zhangsong"},"change_message_id":"fa9094965c4bc5cf05ab794fe70ff4ff47268d16","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            snapshot \u003d utils.convert_str(snapshot)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            self.volume \u003d driver.rbd.Image(ioctx,"},{"line_number":117,"context_line":"                                           utils.convert_str(name),"},{"line_number":118,"context_line":"                                           snapshot\u003dsnapshot,"},{"line_number":119,"context_line":"                                           read_only\u003dread_only)"},{"line_number":120,"context_line":"            self.volume \u003d tpool.Proxy(self.volume)"},{"line_number":121,"context_line":"        except driver.rbd.Error:"},{"line_number":122,"context_line":"            LOG.exception(_LE(\"error opening rbd image %s\"), name)"},{"line_number":123,"context_line":"            driver._disconnect_from_rados(client, ioctx)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_cf4ab154","line":120,"range":{"start_line":116,"start_character":0,"end_line":120,"end_character":50},"in_reply_to":"9a30ddce_493b8a9c","updated":"2017-03-13 07:17:27.000000000","message":"I don\u0027t think we need to merge it, because it may lead to poor readability.","commit_id":"8f2b7f4f20727d35d0dce25fddb5a879f26c9614"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"53a10952a4f801da24c4a54043f8ee550219f6d6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            snapshot \u003d utils.convert_str(snapshot)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            self.volume \u003d driver.rbd.Image(ioctx,"},{"line_number":117,"context_line":"                                           utils.convert_str(name),"},{"line_number":118,"context_line":"                                           snapshot\u003dsnapshot,"},{"line_number":119,"context_line":"                                           read_only\u003dread_only)"},{"line_number":120,"context_line":"            self.volume \u003d tpool.Proxy(self.volume)"},{"line_number":121,"context_line":"        except driver.rbd.Error:"},{"line_number":122,"context_line":"            LOG.exception(_LE(\"error opening rbd image %s\"), name)"},{"line_number":123,"context_line":"            driver._disconnect_from_rados(client, ioctx)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_ef705542","line":120,"range":{"start_line":116,"start_character":0,"end_line":120,"end_character":50},"in_reply_to":"9a30ddce_cf4ab154","updated":"2017-03-13 07:42:16.000000000","message":"Well, I don\u0027t want to insist this to change,  although that will not make it poor readability I think.","commit_id":"8f2b7f4f20727d35d0dce25fddb5a879f26c9614"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"47da602bc9d31cd7cb39e9f3f45db20ab26b5eb9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            snapshot \u003d utils.convert_str(snapshot)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            self.volume \u003d driver.rbd.Image(ioctx,"},{"line_number":117,"context_line":"                                           utils.convert_str(name),"},{"line_number":118,"context_line":"                                           snapshot\u003dsnapshot,"},{"line_number":119,"context_line":"                                           read_only\u003dread_only)"},{"line_number":120,"context_line":"            self.volume \u003d tpool.Proxy(self.volume)"},{"line_number":121,"context_line":"        except driver.rbd.Error:"},{"line_number":122,"context_line":"            LOG.exception(_LE(\"error opening rbd image %s\"), name)"},{"line_number":123,"context_line":"            driver._disconnect_from_rados(client, ioctx)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_f171bc45","line":120,"range":{"start_line":116,"start_character":0,"end_line":120,"end_character":50},"in_reply_to":"9a30ddce_ef705542","updated":"2017-05-12 11:46:09.000000000","message":"This does look a little odd to me doing it like this. But should be fine.","commit_id":"8f2b7f4f20727d35d0dce25fddb5a879f26c9614"}]}