)]}'
{"cinder/backup/drivers/ceph.py":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"0fa878494de4b1e873a8efdc5e2a95238c4a1c2b","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        If no --conf is provided, rbd will look in the default locations e.g."},{"line_number":198,"context_line":"        /etc/ceph/ceph.conf"},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        # Make sure user arg is valid since rbd command may not fail if"},{"line_number":202,"context_line":"        # invalid/no user provided, resulting in unexpected behaviour."},{"line_number":203,"context_line":"        if not self._validate_string_args(user):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_64571526","line":200,"updated":"2017-01-24 16:32:02.000000000","message":"Ceph will use client.admin as the default user if none is specified.  Why not only append \u0027--id $user\u0027 if it is present and allow ceph to assign its default preference.  That seems cleaner to me.","commit_id":"146caef40bcd7e6b533e0e23e3a6e5136e8ee730"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b3faf5ac7f7ad057c37474caff77e58df3fc7c18","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        If no --conf is provided, rbd will look in the default locations e.g."},{"line_number":198,"context_line":"        /etc/ceph/ceph.conf"},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        # Make sure user arg is valid since rbd command may not fail if"},{"line_number":202,"context_line":"        # invalid/no user provided, resulting in unexpected behaviour."},{"line_number":203,"context_line":"        if not self._validate_string_args(user):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_97c72f97","line":200,"in_reply_to":"1a430d35_18e829b4","updated":"2017-10-13 19:06:52.000000000","message":"Or just check for None and don\u0027t call it and don\u0027t append --id based on that.","commit_id":"146caef40bcd7e6b533e0e23e3a6e5136e8ee730"},{"author":{"_account_id":24741,"name":"Zhao Liqiang","email":"zhaoliqiang@cmss.chinamobile.com","username":"zhaoliqiang"},"change_message_id":"2e29983e9e661365f0186a46c01a2c6af09e3d55","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        If no --conf is provided, rbd will look in the default locations e.g."},{"line_number":198,"context_line":"        /etc/ceph/ceph.conf"},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        # Make sure user arg is valid since rbd command may not fail if"},{"line_number":202,"context_line":"        # invalid/no user provided, resulting in unexpected behaviour."},{"line_number":203,"context_line":"        if not self._validate_string_args(user):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_64e362a4","line":200,"in_reply_to":"5a3905b3_64571526","updated":"2017-02-04 08:33:46.000000000","message":"I see. But if user passed to this function is None, \u0027self._validate_string_args(user)\u0027 will return false, and an exception will be thrown.","commit_id":"146caef40bcd7e6b533e0e23e3a6e5136e8ee730"},{"author":{"_account_id":24741,"name":"Zhao Liqiang","email":"zhaoliqiang@cmss.chinamobile.com","username":"zhaoliqiang"},"change_message_id":"d5ed9acdb36b8aa277d2a9a5097b6ce9ed79cf24","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        If no --conf is provided, rbd will look in the default locations e.g."},{"line_number":198,"context_line":"        /etc/ceph/ceph.conf"},{"line_number":199,"context_line":"        \"\"\""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        # Make sure user arg is valid since rbd command may not fail if"},{"line_number":202,"context_line":"        # invalid/no user provided, resulting in unexpected behaviour."},{"line_number":203,"context_line":"        if not self._validate_string_args(user):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_18e829b4","line":200,"in_reply_to":"5a3905b3_64571526","updated":"2017-02-13 03:04:57.000000000","message":"We must ensure \u0027user\u0027 is not None, or it will not go ahead.","commit_id":"146caef40bcd7e6b533e0e23e3a6e5136e8ee730"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c4cba1b70b8531a2f91f0a5404ab4ba9dd34ad88","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        # Make sure user arg is valid since rbd command may not fail if"},{"line_number":202,"context_line":"        # invalid/no user provided, resulting in unexpected behaviour."},{"line_number":203,"context_line":"        if not self._validate_string_args(user):"},{"line_number":204,"context_line":"            raise exception.BackupInvalidCephArgs(_(\"invalid user \u0027%s\u0027\") %"},{"line_number":205,"context_line":"                                                  user)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        args \u003d [\u0027--id\u0027, user]"},{"line_number":208,"context_line":"        if conf:"},{"line_number":209,"context_line":"            args.extend([\u0027--conf\u0027, conf])"},{"line_number":210,"context_line":"        if pool:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_25f44dcf","line":207,"range":{"start_line":203,"start_character":0,"end_line":207,"end_character":29},"updated":"2018-01-19 12:55:48.000000000","message":"I agree:\n\n args \u003d [\u0027--id\u0027, user] if user else []\n if user and not self._validate_string_args(user):\n     raise exception.BackupInvalidCephArgs(_(\"invalid user \u0027%s\u0027\") %\n                                           user)","commit_id":"146caef40bcd7e6b533e0e23e3a6e5136e8ee730"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"0fa878494de4b1e873a8efdc5e2a95238c4a1c2b","unresolved":false,"context_lines":[{"line_number":539,"context_line":"            src_user \u003d \u0027admin\u0027"},{"line_number":540,"context_line":"        if not dest_user:"},{"line_number":541,"context_line":"            dest_user \u003d \u0027admin\u0027"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        src_ceph_args \u003d self._ceph_args(src_user, src_conf, pool\u003dsrc_pool)"},{"line_number":544,"context_line":"        dest_ceph_args \u003d self._ceph_args(dest_user, dest_conf, pool\u003ddest_pool)"},{"line_number":545,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_043d71dc","line":542,"updated":"2017-01-24 16:32:02.000000000","message":"See comment above.","commit_id":"146caef40bcd7e6b533e0e23e3a6e5136e8ee730"}]}