)]}'
{"cinder/volume/drivers/huawei/rest_client.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7928db7c723d2607c324ee6bb5d53e4dda9bc394","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            if method:"},{"line_number":82,"context_line":"                req.get_method \u003d lambda: method"},{"line_number":83,"context_line":"            res \u003d urllib.request.urlopen(req).read().decode(\"utf-8\")  # nosec"},{"line_number":84,"context_line":"            # unsupported driver"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            if \"xx/sessions\" not in url:"},{"line_number":87,"context_line":"                LOG.info(_LI(\u0027\\n\\n\\n\\nRequest URL: %(url)s\\n\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_aa2b7693","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":32},"updated":"2017-01-24 21:46:51.000000000","message":"Remove this line.\n\nActually Huawei driver was just added back.\n\nhttps://review.openstack.org/#/c/423306/","commit_id":"6d3a96c6064615462f7007a7a5ba739ca3016563"},{"author":{"_account_id":23674,"name":"Rohan Arora","email":"ra271w@att.com","username":"rarora"},"change_message_id":"7df38da0699e0f4b96271eb27a80cd98f71d8bcd","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            if method:"},{"line_number":82,"context_line":"                req.get_method \u003d lambda: method"},{"line_number":83,"context_line":"            res \u003d urllib.request.urlopen(req).read().decode(\"utf-8\")  # nosec"},{"line_number":84,"context_line":"            # unsupported driver"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            if \"xx/sessions\" not in url:"},{"line_number":87,"context_line":"                LOG.info(_LI(\u0027\\n\\n\\n\\nRequest URL: %(url)s\\n\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_16ecb9c6","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":32},"in_reply_to":"5a3905b3_aa2b7693","updated":"2017-01-25 16:00:10.000000000","message":"Done","commit_id":"6d3a96c6064615462f7007a7a5ba739ca3016563"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bf899131409b1a0f5ffbe3c42899a931a9782c30","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            if method:"},{"line_number":82,"context_line":"                req.get_method \u003d lambda: method"},{"line_number":83,"context_line":"            res \u003d urllib.request.urlopen(req).read().decode(\"utf-8\")  # nosec"},{"line_number":84,"context_line":"            # all URLs begin with hardcoded values"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            if \"xx/sessions\" not in url:"},{"line_number":87,"context_line":"                LOG.info(_LI(\u0027\\n\\n\\n\\nRequest URL: %(url)s\\n\\n\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_33b8d8e5","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":50},"updated":"2017-02-01 22:10:02.000000000","message":"Can you move this to before line 83?","commit_id":"75e3bb13a7bfa4cd064c6abf06d8a98f8ee16291"}],"cinder/volume/drivers/xio.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bf899131409b1a0f5ffbe3c42899a931a9782c30","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        req.get_method \u003d lambda: method"},{"line_number":249,"context_line":"        try:"},{"line_number":250,"context_line":"            resp \u003d urllib.request.urlopen(req)  # nosec"},{"line_number":251,"context_line":"            # IP addr formed from code and cinder.conf so URL can be trusted"},{"line_number":252,"context_line":"        except urllib.error.HTTPError as err:"},{"line_number":253,"context_line":"            # HTTP error. Return HTTP status and content and let caller"},{"line_number":254,"context_line":"            # handle retries."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_53e64417","line":251,"updated":"2017-02-01 22:10:02.000000000","message":"Can you move this to before line 250?","commit_id":"75e3bb13a7bfa4cd064c6abf06d8a98f8ee16291"}],"cinder/volume/drivers/zfssa/restclient.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7928db7c723d2607c324ee6bb5d53e4dda9bc394","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                                                      # be used will be http or"},{"line_number":291,"context_line":"                                                      # https if it is given in"},{"line_number":292,"context_line":"                                                      # the path variable, or"},{"line_number":293,"context_line":"                                                      # the the path will begin"},{"line_number":294,"context_line":"                                                      # with the rest API"},{"line_number":295,"context_line":"                                                      # location meaning"},{"line_number":296,"context_line":"                                                      # invalid or unwanted"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_ea349efc","line":293,"range":{"start_line":293,"start_character":56,"end_line":293,"end_character":63},"updated":"2017-01-24 21:46:51.000000000","message":"duplicate \"the\".","commit_id":"6d3a96c6064615462f7007a7a5ba739ca3016563"},{"author":{"_account_id":23674,"name":"Rohan Arora","email":"ra271w@att.com","username":"rarora"},"change_message_id":"7df38da0699e0f4b96271eb27a80cd98f71d8bcd","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                                                      # be used will be http or"},{"line_number":291,"context_line":"                                                      # https if it is given in"},{"line_number":292,"context_line":"                                                      # the path variable, or"},{"line_number":293,"context_line":"                                                      # the the path will begin"},{"line_number":294,"context_line":"                                                      # with the rest API"},{"line_number":295,"context_line":"                                                      # location meaning"},{"line_number":296,"context_line":"                                                      # invalid or unwanted"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_96d8a91f","line":293,"range":{"start_line":293,"start_character":56,"end_line":293,"end_character":63},"in_reply_to":"5a3905b3_ea349efc","updated":"2017-01-25 16:00:10.000000000","message":"Done","commit_id":"6d3a96c6064615462f7007a7a5ba739ca3016563"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"5db8b4f3aa8f58961b1da3c61194ba2931fecc18","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                                                      # with the rest API"},{"line_number":295,"context_line":"                                                      # location meaning"},{"line_number":296,"context_line":"                                                      # invalid or unwanted"},{"line_number":297,"context_line":"                                                      # schemes cannot be used"},{"line_number":298,"context_line":"                                                      timeout\u003dself.timeout,"},{"line_number":299,"context_line":"                                                      context\u003dcontext)"},{"line_number":300,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_88cbd31d","line":297,"updated":"2017-01-27 07:02:39.000000000","message":"this comment inline with the params seems excessive","commit_id":"56a979443f90eb49ca1da1d210a92fbbb22e8300"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"23920993a0ed732bf64a4e6d9f8491c9f6198289","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                                                      # with the rest API"},{"line_number":295,"context_line":"                                                      # location meaning"},{"line_number":296,"context_line":"                                                      # invalid or unwanted"},{"line_number":297,"context_line":"                                                      # schemes cannot be used"},{"line_number":298,"context_line":"                                                      timeout\u003dself.timeout,"},{"line_number":299,"context_line":"                                                      context\u003dcontext)"},{"line_number":300,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_474a0d29","line":297,"in_reply_to":"3a461143_1c542cfd","updated":"2017-02-01 17:05:17.000000000","message":"yah I agree with that.   I think the #nosec is required to disable the bandit complaints, but the reason for the #nosec should be above to make it more readable.   Does bandit require that comment to be where it is?  That would suck.","commit_id":"56a979443f90eb49ca1da1d210a92fbbb22e8300"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2c7099e8389095fecf17e796070b41d7a55fdc9a","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                                                      # with the rest API"},{"line_number":295,"context_line":"                                                      # location meaning"},{"line_number":296,"context_line":"                                                      # invalid or unwanted"},{"line_number":297,"context_line":"                                                      # schemes cannot be used"},{"line_number":298,"context_line":"                                                      timeout\u003dself.timeout,"},{"line_number":299,"context_line":"                                                      context\u003dcontext)"},{"line_number":300,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_1c542cfd","line":297,"in_reply_to":"3a461143_34030911","updated":"2017-01-30 20:31:58.000000000","message":"I would suggest move the comments to before the line 288.  This way you have more room for the comments and don\u0027t have to take so many lines.  What do you think, Walt?","commit_id":"56a979443f90eb49ca1da1d210a92fbbb22e8300"},{"author":{"_account_id":23674,"name":"Rohan Arora","email":"ra271w@att.com","username":"rarora"},"change_message_id":"73b0b11b8531d78347e16c0da064cdf68f8bcbfe","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                                                      # with the rest API"},{"line_number":295,"context_line":"                                                      # location meaning"},{"line_number":296,"context_line":"                                                      # invalid or unwanted"},{"line_number":297,"context_line":"                                                      # schemes cannot be used"},{"line_number":298,"context_line":"                                                      timeout\u003dself.timeout,"},{"line_number":299,"context_line":"                                                      context\u003dcontext)"},{"line_number":300,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_471f6d09","line":297,"in_reply_to":"3a461143_474a0d29","updated":"2017-02-01 17:08:06.000000000","message":"I believe Bandit just pays attention to where the actual \"#nosec\" comment is, so having the rest before it should be fine. I\u0027ll get to fixing that!","commit_id":"56a979443f90eb49ca1da1d210a92fbbb22e8300"},{"author":{"_account_id":23674,"name":"Rohan Arora","email":"ra271w@att.com","username":"rarora"},"change_message_id":"7d194c2fa1a056ea98f89c1417c0d4ed24990931","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                                                      # with the rest API"},{"line_number":295,"context_line":"                                                      # location meaning"},{"line_number":296,"context_line":"                                                      # invalid or unwanted"},{"line_number":297,"context_line":"                                                      # schemes cannot be used"},{"line_number":298,"context_line":"                                                      timeout\u003dself.timeout,"},{"line_number":299,"context_line":"                                                      context\u003dcontext)"},{"line_number":300,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_34030911","line":297,"in_reply_to":"3a461143_88cbd31d","updated":"2017-01-27 14:18:06.000000000","message":"I agree... however I chose this format as that is what is specified by pep8. The other option would be to make it so that the functions arguments are not aligned with the parentheses so I could write the comments with normal indentation but I had chosen to keep it this way as it follows the formatting of all of the other functions in the file. I could perhaps try to shorten my comment though?","commit_id":"56a979443f90eb49ca1da1d210a92fbbb22e8300"}],"cinder/volume/drivers/zfssa/webdavclient.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bf899131409b1a0f5ffbe3c42899a931a9782c30","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        while retry \u003c maxretries:"},{"line_number":109,"context_line":"            try:"},{"line_number":110,"context_line":"                response \u003d urllib.request.urlopen(  # nosec"},{"line_number":111,"context_line":"                    # URLs are prepended with self.https_path which is safe"},{"line_number":112,"context_line":"                    # meaning that the URL will either be safe or nonexistant"},{"line_number":113,"context_line":"                    request, timeout\u003dNone)"},{"line_number":114,"context_line":"            except urllib.error.HTTPError as err:"},{"line_number":115,"context_line":"                LOG.error(_LE(\u0027WebDAV returned with %(code)s error during \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_d3d15431","line":112,"range":{"start_line":111,"start_character":0,"end_line":112,"end_character":77},"updated":"2017-02-01 22:10:02.000000000","message":"Can you move these to before line 110?","commit_id":"75e3bb13a7bfa4cd064c6abf06d8a98f8ee16291"}],"cinder/volume/drivers/zte/zte_ks.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bf899131409b1a0f5ffbe3c42899a931a9782c30","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            req \u003d urllib.request.Request(self.url, data, headers)"},{"line_number":118,"context_line":"            req.get_method \u003d lambda: \u0027POST\u0027"},{"line_number":119,"context_line":"            response \u003d urllib.request.urlopen(req,  # nosec"},{"line_number":120,"context_line":"                                              # self.url used for req is coded"},{"line_number":121,"context_line":"                                              # to always use the HTTPS scheme"},{"line_number":122,"context_line":"                                              timeout\u003d"},{"line_number":123,"context_line":"                                              zte_pub.ZTE_DEFAULT_TIMEOUT"},{"line_number":124,"context_line":"                                              ).read()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_b31688ef","line":121,"range":{"start_line":120,"start_character":46,"end_line":121,"end_character":78},"updated":"2017-02-01 22:10:02.000000000","message":"Can you move these to before line 119?","commit_id":"75e3bb13a7bfa4cd064c6abf06d8a98f8ee16291"}]}