)]}'
{"cinder/tests/unit/volume/drivers/nexenta/test_nexenta5_nfs.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"a72722119330a2a412d7ead8c307f4cc4e8f06c1","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    TEST_VOLUME \u003d fake_volume_obj(None, **{"},{"line_number":41,"context_line":"        \u0027name\u0027: TEST_VOLUME_NAME,"},{"line_number":42,"context_line":"        \u0027id\u0027: \u00271\u0027,"},{"line_number":43,"context_line":"        \u0027size\u0027: 1,"},{"line_number":44,"context_line":"        \u0027status\u0027: \u0027available\u0027,"},{"line_number":45,"context_line":"        \u0027provider_location\u0027: TEST_SHARE"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_3634a6dc","line":42,"range":{"start_line":42,"start_character":14,"end_line":42,"end_character":17},"updated":"2017-02-24 12:07:11.000000000","message":"Are these changes necessary?","commit_id":"2fa75dab76ad27b82bc7e972b471c6ef24df4227"}],"cinder/volume/drivers/nexenta/ns5/zfs_garbage_collector.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b82ca77691ec9bfb4ba18616e02f9fa7389c3c8e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations\r"},{"line_number":14,"context_line":"#    under the License.\r"},{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"from cinder import exception\r"},{"line_number":17,"context_line":"from oslo_log import log as logging\r"},{"line_number":18,"context_line":"\r"},{"line_number":19,"context_line":"LOG \u003d logging.getLogger(__name__)\r"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_7bcbff1d","line":16,"updated":"2017-03-30 20:25:19.000000000","message":"Local (cinder) imports should be grouped separately from third party (oslo) imports below.","commit_id":"6bf22795d78a715e2d1b06778bb1d5240416eaf9"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@ddn.com","username":"Alexey"},"change_message_id":"7e6cac942f927a40eaeb0c53693e5efd63d99a95","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations\r"},{"line_number":14,"context_line":"#    under the License.\r"},{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"from cinder import exception\r"},{"line_number":17,"context_line":"from oslo_log import log as logging\r"},{"line_number":18,"context_line":"\r"},{"line_number":19,"context_line":"LOG \u003d logging.getLogger(__name__)\r"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_767af688","line":16,"in_reply_to":"dfeb2761_7bcbff1d","updated":"2017-03-30 20:39:11.000000000","message":"Done","commit_id":"6bf22795d78a715e2d1b06778bb1d5240416eaf9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d7f2c0c2aa51876b5b4a7eb70c1d6de840039d85","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"from cinder import exception\r"},{"line_number":17,"context_line":"\r"},{"line_number":18,"context_line":"from oslo_log import log as logging\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)\r"},{"line_number":21,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_36b6aedb","line":18,"updated":"2017-03-30 20:50:12.000000000","message":"Sorry, guess I wasn\u0027t too clear. It should be system imports, third party imports, then local imports. So these two should just be switched.","commit_id":"37557331de47ccf2de54b930b2d518f82d542b37"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@ddn.com","username":"Alexey"},"change_message_id":"762b7056a113e9bfa095ab6226a96dc1f438d9f5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"from cinder import exception\r"},{"line_number":17,"context_line":"\r"},{"line_number":18,"context_line":"from oslo_log import log as logging\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)\r"},{"line_number":21,"context_line":"\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_d620a2fa","line":18,"in_reply_to":"dfeb2761_36b6aedb","updated":"2017-03-30 20:53:28.000000000","message":"fixed","commit_id":"37557331de47ccf2de54b930b2d518f82d542b37"}],"releasenotes/notes/nexenta-ns5-zfs-cleanup-0633d3f9c5cb11df.yaml":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"a72722119330a2a412d7ead8c307f4cc4e8f06c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - ZFS clone from snapshot operation creates a dependency between the clone"},{"line_number":4,"context_line":"    and original dataset. Therefore cleanup operation cannot delete volumes"},{"line_number":5,"context_line":"    that have dependencies. Those will be automatically cleaned up when"},{"line_number":6,"context_line":"    dependencies no longer exist. Cleanup was added to both NFS and iSCSI"},{"line_number":7,"context_line":"    drivers for NexentaStor 5."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da36d5c6_9b1e5b6e","line":7,"range":{"start_line":2,"start_character":0,"end_line":7,"end_character":30},"updated":"2017-02-24 12:07:11.000000000","message":"-1\nI think, it can be shorter. You can just left the last sentence and it will be enough. \n\n\"Add cleanup for deleted volume with dependencies to both NFS and iSCSI drivers for NexentaStor 5.\" or something like this.","commit_id":"2fa75dab76ad27b82bc7e972b471c6ef24df4227"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b82ca77691ec9bfb4ba18616e02f9fa7389c3c8e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add cleanup for deleted volume with dependencies to both NFS and"},{"line_number":4,"context_line":"    iSCSI drivers for NexentaStor 5.\" or something like this."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfeb2761_3bee9788","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":61},"updated":"2017-03-30 20:25:19.000000000","message":"Remove this part. The rest looks fine to me.","commit_id":"6bf22795d78a715e2d1b06778bb1d5240416eaf9"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@ddn.com","username":"Alexey"},"change_message_id":"7e6cac942f927a40eaeb0c53693e5efd63d99a95","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add cleanup for deleted volume with dependencies to both NFS and"},{"line_number":4,"context_line":"    iSCSI drivers for NexentaStor 5.\" or something like this."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfeb2761_b6463e4f","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":61},"in_reply_to":"dfeb2761_3bee9788","updated":"2017-03-30 20:39:11.000000000","message":"my bad, not sure how this ended up here...","commit_id":"6bf22795d78a715e2d1b06778bb1d5240416eaf9"}]}