)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"9e67d152efbad13f931bbc1d7d33717447fa535e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Qos for clone for Nimble Storage Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the Qos is set only for the create volume."},{"line_number":10,"context_line":"The attribute needs to be overriden by the clone"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic30c1f386ee902333260fe23d57954ea021c24a4"},{"line_number":13,"context_line":"Closes-Bug: #1659165"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a461143_c2124862","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"updated":"2017-01-26 10:33:58.000000000","message":"Can you give an elaborated explanation of the problem and how you are trying to solve it? This sort message makes hard to understand you you really is trying to do.","commit_id":"fdf682b31eb5cb2cdb8b35a08f18c7fe84b8aadf"},{"author":{"_account_id":16668,"name":"Raunak Kumar","email":"rkumar@nimblestorage.com","username":"rkumar"},"change_message_id":"b44e934b311aab1a34313dd2043a2bb8697ec81b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Qos for clone for Nimble Storage Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the Qos is set only for the create volume."},{"line_number":10,"context_line":"The attribute needs to be overriden by the clone"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic30c1f386ee902333260fe23d57954ea021c24a4"},{"line_number":13,"context_line":"Closes-Bug: #1659165"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a461143_2ba67210","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":48},"in_reply_to":"3a461143_c2124862","updated":"2017-01-26 17:52:57.000000000","message":"Sure. Will add more context.","commit_id":"fdf682b31eb5cb2cdb8b35a08f18c7fe84b8aadf"}],"cinder/volume/drivers/nimble.py":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"21ac8dda79ba50eb669f52b2e1c7687be30790a6","unresolved":false,"context_lines":[{"line_number":1539,"context_line":"        if iops_limit is not None:"},{"line_number":1540,"context_line":"            if not iops_limit.isdigit() or ("},{"line_number":1541,"context_line":"               int(iops_limit) \u003c MIN_IOPS) or (int(iops_limit) \u003e MAX_IOPS):"},{"line_number":1542,"context_line":"                raise NimbleAPIException(_(\"Please set valid IOPS limit\""},{"line_number":1543,"context_line":"                                         \" in the range [%(min)s, %(max)s]\") %"},{"line_number":1544,"context_line":"                                         {\u0027min\u0027: MIN_IOPS,"},{"line_number":1545,"context_line":"                                          \u0027max\u0027: MAX_IOPS})"},{"line_number":1546,"context_line":"            data[\u0027data\u0027][\u0027limit_iops\u0027] \u003d iops_limit"},{"line_number":1547,"context_line":""},{"line_number":1548,"context_line":"        LOG.debug(\"Volume metadata :%s\", volume.metadata)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_202cf0aa","line":1545,"range":{"start_line":1542,"start_character":0,"end_line":1545,"end_character":59},"updated":"2017-01-25 10:25:10.000000000","message":"mark","commit_id":"c6ef9e61875887ebf1aeda2dc65a9b6d6b14bec4"},{"author":{"_account_id":16668,"name":"Raunak Kumar","email":"rkumar@nimblestorage.com","username":"rkumar"},"change_message_id":"67d9b036c37b6ae9414c6b8e8a55c08c371f3451","unresolved":false,"context_lines":[{"line_number":1539,"context_line":"        if iops_limit is not None:"},{"line_number":1540,"context_line":"            if not iops_limit.isdigit() or ("},{"line_number":1541,"context_line":"               int(iops_limit) \u003c MIN_IOPS) or (int(iops_limit) \u003e MAX_IOPS):"},{"line_number":1542,"context_line":"                raise NimbleAPIException(_(\"Please set valid IOPS limit\""},{"line_number":1543,"context_line":"                                         \" in the range [%(min)s, %(max)s]\") %"},{"line_number":1544,"context_line":"                                         {\u0027min\u0027: MIN_IOPS,"},{"line_number":1545,"context_line":"                                          \u0027max\u0027: MAX_IOPS})"},{"line_number":1546,"context_line":"            data[\u0027data\u0027][\u0027limit_iops\u0027] \u003d iops_limit"},{"line_number":1547,"context_line":""},{"line_number":1548,"context_line":"        LOG.debug(\"Volume metadata :%s\", volume.metadata)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_08dd6a14","line":1545,"range":{"start_line":1542,"start_character":0,"end_line":1545,"end_character":59},"in_reply_to":"5a3905b3_202cf0aa","updated":"2017-01-25 21:19:36.000000000","message":"Done","commit_id":"c6ef9e61875887ebf1aeda2dc65a9b6d6b14bec4"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"21ac8dda79ba50eb669f52b2e1c7687be30790a6","unresolved":false,"context_lines":[{"line_number":1550,"context_line":"            LOG.debug(\"Key %(key)s Value %(value)s\","},{"line_number":1551,"context_line":"                      {\u0027key\u0027: key, \u0027value\u0027: value})"},{"line_number":1552,"context_line":"            if key \u003d\u003d EXTRA_SPEC_IOPS_LIMIT and value.isdigit():"},{"line_number":1553,"context_line":"                if type(value) \u003d\u003d int or int(value) \u003c MIN_IOPS or ("},{"line_number":1554,"context_line":"                   int(value) \u003e MAX_IOPS):"},{"line_number":1555,"context_line":"                    raise NimbleAPIException(_(\"Please enter valid IOPS \""},{"line_number":1556,"context_line":"                                               \"limit in the range [\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_e073c8e5","line":1553,"range":{"start_line":1553,"start_character":16,"end_line":1553,"end_character":37},"updated":"2017-01-25 10:25:10.000000000","message":"I can\u0027t understand why we need here this check. \u0027int\u0027 type doesn\u0027t have such an attribute like \u0027isdigit\u0027, so i think, that it is senseless.\nOr if the value has integer type, it will raise an exception at value.isdigit() place.","commit_id":"c6ef9e61875887ebf1aeda2dc65a9b6d6b14bec4"},{"author":{"_account_id":16668,"name":"Raunak Kumar","email":"rkumar@nimblestorage.com","username":"rkumar"},"change_message_id":"67d9b036c37b6ae9414c6b8e8a55c08c371f3451","unresolved":false,"context_lines":[{"line_number":1550,"context_line":"            LOG.debug(\"Key %(key)s Value %(value)s\","},{"line_number":1551,"context_line":"                      {\u0027key\u0027: key, \u0027value\u0027: value})"},{"line_number":1552,"context_line":"            if key \u003d\u003d EXTRA_SPEC_IOPS_LIMIT and value.isdigit():"},{"line_number":1553,"context_line":"                if type(value) \u003d\u003d int or int(value) \u003c MIN_IOPS or ("},{"line_number":1554,"context_line":"                   int(value) \u003e MAX_IOPS):"},{"line_number":1555,"context_line":"                    raise NimbleAPIException(_(\"Please enter valid IOPS \""},{"line_number":1556,"context_line":"                                               \"limit in the range [\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_88ca3a4e","line":1553,"range":{"start_line":1553,"start_character":16,"end_line":1553,"end_character":37},"in_reply_to":"5a3905b3_e073c8e5","updated":"2017-01-25 21:19:36.000000000","message":"Agree. Will remove it.","commit_id":"c6ef9e61875887ebf1aeda2dc65a9b6d6b14bec4"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"21ac8dda79ba50eb669f52b2e1c7687be30790a6","unresolved":false,"context_lines":[{"line_number":1552,"context_line":"            if key \u003d\u003d EXTRA_SPEC_IOPS_LIMIT and value.isdigit():"},{"line_number":1553,"context_line":"                if type(value) \u003d\u003d int or int(value) \u003c MIN_IOPS or ("},{"line_number":1554,"context_line":"                   int(value) \u003e MAX_IOPS):"},{"line_number":1555,"context_line":"                    raise NimbleAPIException(_(\"Please enter valid IOPS \""},{"line_number":1556,"context_line":"                                               \"limit in the range [\""},{"line_number":1557,"context_line":"                                               \"%(min)s, %(max)s]\") %"},{"line_number":1558,"context_line":"                                             {\u0027min\u0027: MIN_IOPS,"},{"line_number":1559,"context_line":"                                              \u0027max\u0027: MAX_IOPS})"},{"line_number":1560,"context_line":"                LOG.debug(\"IOPS Limit %s\", value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_002ff4a1","line":1557,"range":{"start_line":1555,"start_character":46,"end_line":1557,"end_character":69},"updated":"2017-01-25 10:25:10.000000000","message":"And why do you have different messages in NimbleAPIException here and before, at the mark comment?","commit_id":"c6ef9e61875887ebf1aeda2dc65a9b6d6b14bec4"},{"author":{"_account_id":16668,"name":"Raunak Kumar","email":"rkumar@nimblestorage.com","username":"rkumar"},"change_message_id":"67d9b036c37b6ae9414c6b8e8a55c08c371f3451","unresolved":false,"context_lines":[{"line_number":1552,"context_line":"            if key \u003d\u003d EXTRA_SPEC_IOPS_LIMIT and value.isdigit():"},{"line_number":1553,"context_line":"                if type(value) \u003d\u003d int or int(value) \u003c MIN_IOPS or ("},{"line_number":1554,"context_line":"                   int(value) \u003e MAX_IOPS):"},{"line_number":1555,"context_line":"                    raise NimbleAPIException(_(\"Please enter valid IOPS \""},{"line_number":1556,"context_line":"                                               \"limit in the range [\""},{"line_number":1557,"context_line":"                                               \"%(min)s, %(max)s]\") %"},{"line_number":1558,"context_line":"                                             {\u0027min\u0027: MIN_IOPS,"},{"line_number":1559,"context_line":"                                              \u0027max\u0027: MAX_IOPS})"},{"line_number":1560,"context_line":"                LOG.debug(\"IOPS Limit %s\", value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_e8c1fe2f","line":1557,"range":{"start_line":1555,"start_character":46,"end_line":1557,"end_character":69},"in_reply_to":"5a3905b3_002ff4a1","updated":"2017-01-25 21:19:36.000000000","message":"Will make them identical. Thanks","commit_id":"c6ef9e61875887ebf1aeda2dc65a9b6d6b14bec4"}]}