)]}'
{"cinder/volume/drivers/ibm/ibm_storage/ds8k_helper.py":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"c7adee39430ce5e8e5a30149a12486b509024a67","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cinder import exception"},{"line_number":27,"context_line":"from cinder.i18n import _, _LI, _LW, _LE"},{"line_number":28,"context_line":"from cinder.objects import fields as obj_fields"},{"line_number":29,"context_line":"import cinder.volume.drivers.ibm.ibm_storage as storage"},{"line_number":30,"context_line":"from cinder.volume.drivers.ibm.ibm_storage import cryptish"},{"line_number":31,"context_line":"from cinder.volume.drivers.ibm.ibm_storage import ds8k_restclient as restclient"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_dbb5ff7e","line":28,"range":{"start_line":28,"start_character":33,"end_line":28,"end_character":47},"updated":"2017-01-25 14:53:28.000000000","message":"it is definitely legitimate, but I wonder why you changes fields to obj_fields?","commit_id":"488a380d8f74ef4f2f3b16fea43190697dfbe067"},{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"31552d0bf1a321f76040bac74ef95b14dd35409d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cinder import exception"},{"line_number":27,"context_line":"from cinder.i18n import _, _LI, _LW, _LE"},{"line_number":28,"context_line":"from cinder.objects import fields as obj_fields"},{"line_number":29,"context_line":"import cinder.volume.drivers.ibm.ibm_storage as storage"},{"line_number":30,"context_line":"from cinder.volume.drivers.ibm.ibm_storage import cryptish"},{"line_number":31,"context_line":"from cinder.volume.drivers.ibm.ibm_storage import ds8k_restclient as restclient"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_166be3b7","line":28,"range":{"start_line":28,"start_character":33,"end_line":28,"end_character":47},"in_reply_to":"3a461143_dbb5ff7e","updated":"2017-02-01 12:11:48.000000000","message":"Thanks Alon for your review,\n\nI change fileds to obj_fields because REST has a keyword fields, although it is a local one in the code, and doesn\u0027t affect the global one. but in order to distinguish them, I think it may be better to change the global one here.","commit_id":"488a380d8f74ef4f2f3b16fea43190697dfbe067"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"c7adee39430ce5e8e5a30149a12486b509024a67","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                return self._get_location(pool_ids, lss_ids_0, lss_ids_1)"},{"line_number":273,"context_line":"            else:"},{"line_number":274,"context_line":"                if not find_new_pid:"},{"line_number":275,"context_line":"                    msg \u003d _(\u0027All LSS/LCU IDs for configured pools do not \u0027"},{"line_number":276,"context_line":"                            \u0027have enough slots\u0027)"},{"line_number":277,"context_line":"                    raise restclient.LssIDExhaustError(message\u003dmsg)"},{"line_number":278,"context_line":"        return self.find_biggest_pool_and_lss(excluded_lss, require_slots)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    @proxy.logger"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_9b8e1726","line":277,"range":{"start_line":275,"start_character":19,"end_line":277,"end_character":67},"updated":"2017-01-25 14:53:28.000000000","message":"move text into exception","commit_id":"488a380d8f74ef4f2f3b16fea43190697dfbe067"},{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"31552d0bf1a321f76040bac74ef95b14dd35409d","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                return self._get_location(pool_ids, lss_ids_0, lss_ids_1)"},{"line_number":273,"context_line":"            else:"},{"line_number":274,"context_line":"                if not find_new_pid:"},{"line_number":275,"context_line":"                    msg \u003d _(\u0027All LSS/LCU IDs for configured pools do not \u0027"},{"line_number":276,"context_line":"                            \u0027have enough slots\u0027)"},{"line_number":277,"context_line":"                    raise restclient.LssIDExhaustError(message\u003dmsg)"},{"line_number":278,"context_line":"        return self.find_biggest_pool_and_lss(excluded_lss, require_slots)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    @proxy.logger"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_d63f9b84","line":277,"range":{"start_line":275,"start_character":19,"end_line":277,"end_character":67},"in_reply_to":"3a461143_9b8e1726","updated":"2017-02-01 12:11:48.000000000","message":"Thanks Alon, in the guideline it shows an example like below.\n\nmsg \u003d _(\"An error occurred\")\nraise HTTPBadRequest(explanation\u003dmsg)\n\nI will not change it if it is really needed to changed.","commit_id":"488a380d8f74ef4f2f3b16fea43190697dfbe067"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"c7adee39430ce5e8e5a30149a12486b509024a67","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            if total_slots \u003e\u003d require_slots:"},{"line_number":315,"context_line":"                return location"},{"line_number":316,"context_line":"            require_slots -\u003d total_slots"},{"line_number":317,"context_line":"        msg \u003d _LE(\"All LSS/LCU IDs for configured pools are exhausted.\")"},{"line_number":318,"context_line":"        raise restclient.LssIDExhaustError(message\u003dmsg)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @proxy.logger"},{"line_number":321,"context_line":"    def _find_lss(self, node, excluded_lss, require_slots):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_bb1673a5","line":318,"range":{"start_line":317,"start_character":8,"end_line":318,"end_character":55},"updated":"2017-01-25 14:53:28.000000000","message":"move text into exception. should be _()","commit_id":"488a380d8f74ef4f2f3b16fea43190697dfbe067"},{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"31552d0bf1a321f76040bac74ef95b14dd35409d","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            if total_slots \u003e\u003d require_slots:"},{"line_number":315,"context_line":"                return location"},{"line_number":316,"context_line":"            require_slots -\u003d total_slots"},{"line_number":317,"context_line":"        msg \u003d _LE(\"All LSS/LCU IDs for configured pools are exhausted.\")"},{"line_number":318,"context_line":"        raise restclient.LssIDExhaustError(message\u003dmsg)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    @proxy.logger"},{"line_number":321,"context_line":"    def _find_lss(self, node, excluded_lss, require_slots):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_164e833a","line":318,"range":{"start_line":317,"start_character":8,"end_line":318,"end_character":55},"in_reply_to":"3a461143_bb1673a5","updated":"2017-02-01 12:11:48.000000000","message":"thank you very much, done","commit_id":"488a380d8f74ef4f2f3b16fea43190697dfbe067"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"c7adee39430ce5e8e5a30149a12486b509024a67","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                    else:"},{"line_number":373,"context_line":"                        lss_ids.update({lss[\u0027id\u0027]: require_slots})"},{"line_number":374,"context_line":"                        break"},{"line_number":375,"context_line":"        msg \u003d _LI(\u0027_choose_lss_ids, LSS IDs choosed are %s.\u0027)"},{"line_number":376,"context_line":"        LOG.info(msg, \u0027,\u0027.join(lss_ids.keys()))"},{"line_number":377,"context_line":"        return lss_ids"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def _find_from_unexisting_lss(self, node, existing_lss, require_slots,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_1b6dc732","line":376,"range":{"start_line":375,"start_character":4,"end_line":376,"end_character":47},"updated":"2017-01-25 14:53:28.000000000","message":"move message into LOG. also applies to other places in the file","commit_id":"488a380d8f74ef4f2f3b16fea43190697dfbe067"},{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"31552d0bf1a321f76040bac74ef95b14dd35409d","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                    else:"},{"line_number":373,"context_line":"                        lss_ids.update({lss[\u0027id\u0027]: require_slots})"},{"line_number":374,"context_line":"                        break"},{"line_number":375,"context_line":"        msg \u003d _LI(\u0027_choose_lss_ids, LSS IDs choosed are %s.\u0027)"},{"line_number":376,"context_line":"        LOG.info(msg, \u0027,\u0027.join(lss_ids.keys()))"},{"line_number":377,"context_line":"        return lss_ids"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def _find_from_unexisting_lss(self, node, existing_lss, require_slots,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_9607d3c8","line":376,"range":{"start_line":375,"start_character":4,"end_line":376,"end_character":47},"in_reply_to":"3a461143_1b6dc732","updated":"2017-02-01 12:11:48.000000000","message":"check the comment above, thanks","commit_id":"488a380d8f74ef4f2f3b16fea43190697dfbe067"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"c7adee39430ce5e8e5a30149a12486b509024a67","unresolved":false,"context_lines":[{"line_number":491,"context_line":"            paths \u003d self.get_pprc_paths()"},{"line_number":492,"context_line":"        except restclient.APIException as e:"},{"line_number":493,"context_line":"            paths \u003d []"},{"line_number":494,"context_line":"            LOG.exception(_LE(\"Can not get the LSS\"), e)"},{"line_number":495,"context_line":"        lss_ids \u003d set(p[\u0027source_lss_id\u0027] for p in paths)"},{"line_number":496,"context_line":"        msg \u003d _LI(\u0027LSS in PPRC paths are: %s.\u0027)"},{"line_number":497,"context_line":"        LOG.info(msg, \u0027,\u0027.join(lss_ids))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_9bc61715","line":494,"range":{"start_line":494,"start_character":27,"end_line":494,"end_character":30},"updated":"2017-01-25 14:53:28.000000000","message":"should be _()","commit_id":"488a380d8f74ef4f2f3b16fea43190697dfbe067"},{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"31552d0bf1a321f76040bac74ef95b14dd35409d","unresolved":false,"context_lines":[{"line_number":491,"context_line":"            paths \u003d self.get_pprc_paths()"},{"line_number":492,"context_line":"        except restclient.APIException as e:"},{"line_number":493,"context_line":"            paths \u003d []"},{"line_number":494,"context_line":"            LOG.exception(_LE(\"Can not get the LSS\"), e)"},{"line_number":495,"context_line":"        lss_ids \u003d set(p[\u0027source_lss_id\u0027] for p in paths)"},{"line_number":496,"context_line":"        msg \u003d _LI(\u0027LSS in PPRC paths are: %s.\u0027)"},{"line_number":497,"context_line":"        LOG.info(msg, \u0027,\u0027.join(lss_ids))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_d624fb60","line":494,"range":{"start_line":494,"start_character":27,"end_line":494,"end_character":30},"in_reply_to":"3a461143_9bc61715","updated":"2017-02-01 12:11:48.000000000","message":"Thanks Alon, I think I need to remove \u0027e\u0027 here, but not change _LE, because in the guidelines, it says:\n\nLOG.exception creates an ERROR level log, so when a marker function is used (see below) _LE() should be used","commit_id":"488a380d8f74ef4f2f3b16fea43190697dfbe067"}]}