)]}'
{"cinder/volume/drivers/dell/dell_storagecenter_api.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"bdc2dd696168abd57cd4b5be10e96a29b02909a6","unresolved":false,"context_lines":[{"line_number":1285,"context_line":"        :returns: Boolean indicating success or failure."},{"line_number":1286,"context_line":"        \"\"\""},{"line_number":1287,"context_line":"        vol \u003d self.find_volume(name, provider_id)"},{"line_number":1288,"context_line":"        provider_id \u003d None if not vol else self._get_id(vol)"},{"line_number":1289,"context_line":""},{"line_number":1290,"context_line":"        # If we have an id then delete the volume."},{"line_number":1291,"context_line":"        if provider_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_e61b54c8","line":1288,"range":{"start_line":1288,"start_character":56,"end_line":1288,"end_character":59},"updated":"2017-01-30 18:23:46.000000000","message":"Isn\u0027t this a problem if the find_volume above returns None?","commit_id":"0a36a89bc8caac67777eda8dbbe344c52dc424c3"}],"cinder/volume/drivers/dell/dell_storagecenter_common.py":[{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"71d7fdd0b36d4071ab120718554db43aa2a94ab5","unresolved":false,"context_lines":[{"line_number":766,"context_line":"                  {\u0027current\u0027: current_name,"},{"line_number":767,"context_line":"                   \u0027original\u0027: original_volume_name})"},{"line_number":768,"context_line":"        if original_volume_name:"},{"line_number":769,"context_line":"            with self._client.open_connection() as api:"},{"line_number":770,"context_line":"                # todo(tswanson): Delete old volume repliations/live volumes"},{"line_number":771,"context_line":"                # todo(tswanson): delete old volume?"},{"line_number":772,"context_line":"                scvolume \u003d api.find_volume(current_name, provider_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_3f7bd38d","line":769,"updated":"2017-01-27 21:35:22.000000000","message":"Is there anything you want to implement for these TODOs in this change?","commit_id":"0a36a89bc8caac67777eda8dbbe344c52dc424c3"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"d132506f33a4a437b14a953643f3473cd4011963","unresolved":false,"context_lines":[{"line_number":766,"context_line":"                  {\u0027current\u0027: current_name,"},{"line_number":767,"context_line":"                   \u0027original\u0027: original_volume_name})"},{"line_number":768,"context_line":"        if original_volume_name:"},{"line_number":769,"context_line":"            with self._client.open_connection() as api:"},{"line_number":770,"context_line":"                # todo(tswanson): Delete old volume repliations/live volumes"},{"line_number":771,"context_line":"                # todo(tswanson): delete old volume?"},{"line_number":772,"context_line":"                scvolume \u003d api.find_volume(current_name, provider_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_bfe6e312","line":769,"in_reply_to":"3a461143_3f7bd38d","updated":"2017-01-27 21:44:09.000000000","message":"Not for this change. This would move where this stuff is done which might not be appropriate.","commit_id":"0a36a89bc8caac67777eda8dbbe344c52dc424c3"}]}