)]}'
{"cinder/tests/unit/volume/flows/test_manage_snapshot_flow.py":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"922b6b9f27dd83dbb1cd294cc3b5c9a24dc27ea3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    @mock.patch(\u0027cinder.objects.base.CinderPersistentObject.get_by_id\u0027)"},{"line_number":36,"context_line":"    def test_manage_snapshot_after_volume_extending(self, _get_by_id,"},{"line_number":37,"context_line":"                                                    _snapshot_get):"},{"line_number":38,"context_line":"        \"\"\"Test case checkes snapshot volume_size value after it is manage.\"\"\""},{"line_number":39,"context_line":"        fake_size \u003d 3"},{"line_number":40,"context_line":"        fake_snap \u003d fake_snapshot.fake_snapshot_obj(self.ctxt,"},{"line_number":41,"context_line":"                                                    volume_size\u003dfake_size)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_f713805a","line":38,"range":{"start_line":38,"start_character":21,"end_line":38,"end_character":28},"updated":"2017-02-10 18:35:20.000000000","message":"s/checkes/checks","commit_id":"c2a40dcfb9af1cefc983e24ed4c17eb99ef2be1f"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"922b6b9f27dd83dbb1cd294cc3b5c9a24dc27ea3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    @mock.patch(\u0027cinder.objects.base.CinderPersistentObject.get_by_id\u0027)"},{"line_number":36,"context_line":"    def test_manage_snapshot_after_volume_extending(self, _get_by_id,"},{"line_number":37,"context_line":"                                                    _snapshot_get):"},{"line_number":38,"context_line":"        \"\"\"Test case checkes snapshot volume_size value after it is manage.\"\"\""},{"line_number":39,"context_line":"        fake_size \u003d 3"},{"line_number":40,"context_line":"        fake_snap \u003d fake_snapshot.fake_snapshot_obj(self.ctxt,"},{"line_number":41,"context_line":"                                                    volume_size\u003dfake_size)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_7726b0bb","line":38,"range":{"start_line":38,"start_character":68,"end_line":38,"end_character":74},"updated":"2017-02-10 18:35:20.000000000","message":"s/manage/managed","commit_id":"c2a40dcfb9af1cefc983e24ed4c17eb99ef2be1f"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"922b6b9f27dd83dbb1cd294cc3b5c9a24dc27ea3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        real_size \u003d 1"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        _get_by_id.return_value \u003d fake_snap"},{"line_number":45,"context_line":"        _snapshot_get.return_value \u003d fake_snap"},{"line_number":46,"context_line":"        mock_db \u003d mock.MagicMock()"},{"line_number":47,"context_line":"        mock_driver \u003d mock.MagicMock()"},{"line_number":48,"context_line":"        mock_manage_existing_ref \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_b70f48e0","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":21},"updated":"2017-02-10 18:35:20.000000000","message":"_snapshot_get is a db method it should not return object.","commit_id":"c2a40dcfb9af1cefc983e24ed4c17eb99ef2be1f"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e0343df2712ee99824d06bd7d72fae0e9f6eb82e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        result \u003d task.execute(self.ctxt, fake_snap, mock_manage_existing_ref,"},{"line_number":55,"context_line":"                              real_size)"},{"line_number":56,"context_line":"        snap_after_manage \u003d result[\u0027snapshot\u0027]"},{"line_number":57,"context_line":"        # to be sure, that snapshot\u0027s volume_size attr has being changed"},{"line_number":58,"context_line":"        self.assertNotEqual(fake_size, snap_after_manage[\u0027volume_size\u0027])"},{"line_number":59,"context_line":"        # and it equal that size, that we want"},{"line_number":60,"context_line":"        self.assertEqual(real_size, snap_after_manage[\u0027volume_size\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_c92b3b2f","line":57,"range":{"start_line":57,"start_character":58,"end_line":57,"end_character":64},"updated":"2017-02-10 21:26:39.000000000","message":"been","commit_id":"c2a40dcfb9af1cefc983e24ed4c17eb99ef2be1f"},{"author":{"_account_id":23276,"name":"Nicholas Jones","email":"nj762h@att.com","username":"nj762h"},"change_message_id":"25c42b80402cce985114e315ea923deb55f51372","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright (c) 2017 Mirantic Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_36deb611","line":1,"range":{"start_line":1,"start_character":23,"end_line":1,"end_character":31},"updated":"2017-02-13 16:17:53.000000000","message":"s/Mirantic/Mirantis/","commit_id":"b1e9c837e89e96dc61283aa397ffbdeac82a2678"},{"author":{"_account_id":23276,"name":"Nicholas Jones","email":"nj762h@att.com","username":"nj762h"},"change_message_id":"25c42b80402cce985114e315ea923deb55f51372","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        result \u003d task.execute(self.ctxt, fake_snap, mock_manage_existing_ref,"},{"line_number":55,"context_line":"                              real_size)"},{"line_number":56,"context_line":"        snap_after_manage \u003d result[\u0027snapshot\u0027]"},{"line_number":57,"context_line":"        # to be sure, that snapshot\u0027s volume_size attr has been changed"},{"line_number":58,"context_line":"        self.assertNotEqual(fake_size, snap_after_manage[\u0027volume_size\u0027])"},{"line_number":59,"context_line":"        # and it equal that size, that we want"},{"line_number":60,"context_line":"        self.assertEqual(real_size, snap_after_manage[\u0027volume_size\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_567deae5","line":57,"range":{"start_line":57,"start_character":20,"end_line":57,"end_character":21},"updated":"2017-02-13 16:17:53.000000000","message":"nit: unnecessary comma","commit_id":"b1e9c837e89e96dc61283aa397ffbdeac82a2678"},{"author":{"_account_id":23276,"name":"Nicholas Jones","email":"nj762h@att.com","username":"nj762h"},"change_message_id":"25c42b80402cce985114e315ea923deb55f51372","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        snap_after_manage \u003d result[\u0027snapshot\u0027]"},{"line_number":57,"context_line":"        # to be sure, that snapshot\u0027s volume_size attr has been changed"},{"line_number":58,"context_line":"        self.assertNotEqual(fake_size, snap_after_manage[\u0027volume_size\u0027])"},{"line_number":59,"context_line":"        # and it equal that size, that we want"},{"line_number":60,"context_line":"        self.assertEqual(real_size, snap_after_manage[\u0027volume_size\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_765bce87","line":59,"range":{"start_line":59,"start_character":17,"end_line":59,"end_character":22},"updated":"2017-02-13 16:17:53.000000000","message":"nit: equals","commit_id":"b1e9c837e89e96dc61283aa397ffbdeac82a2678"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"71508e33925e9b23bdf8a3a77fde1fed216fd3ea","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from cinder import context"},{"line_number":22,"context_line":"from cinder import db  # noqa: F401"},{"line_number":23,"context_line":"from cinder import objects  # noqa: F401"},{"line_number":24,"context_line":"from cinder import test"},{"line_number":25,"context_line":"from cinder.tests.unit import fake_snapshot"},{"line_number":26,"context_line":"from cinder.volume.flows.manager import manage_existing_snapshot as manager"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_378bb169","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":40},"updated":"2017-02-15 13:31:13.000000000","message":"-1: These are not necessary and can be removed","commit_id":"c48d98c570b182641efa740b1620748da8672bb9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"71508e33925e9b23bdf8a3a77fde1fed216fd3ea","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        super(ManageSnapshotFlowTestCase, self).setUp()"},{"line_number":32,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @mock.patch(\u0027cinder.db.sqlalchemy.api._snapshot_get\u0027)"},{"line_number":35,"context_line":"    @mock.patch(\u0027cinder.objects.base.CinderPersistentObject.get_by_id\u0027)"},{"line_number":36,"context_line":"    def test_manage_snapshot_after_volume_extending(self, _get_by_id,"},{"line_number":37,"context_line":"                                                    _snapshot_get):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_f7f759d0","line":34,"updated":"2017-02-15 13:31:13.000000000","message":"?: Why is this mock necessary?  Shouldn\u0027t it get resolved by the get_by_id mocking","commit_id":"c48d98c570b182641efa740b1620748da8672bb9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"71508e33925e9b23bdf8a3a77fde1fed216fd3ea","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @mock.patch(\u0027cinder.db.sqlalchemy.api._snapshot_get\u0027)"},{"line_number":35,"context_line":"    @mock.patch(\u0027cinder.objects.base.CinderPersistentObject.get_by_id\u0027)"},{"line_number":36,"context_line":"    def test_manage_snapshot_after_volume_extending(self, _get_by_id,"},{"line_number":37,"context_line":"                                                    _snapshot_get):"},{"line_number":38,"context_line":"        \"\"\"Test checks snapshot\u0027s volume_size value after it is managed.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_97253d5d","line":35,"updated":"2017-02-15 13:31:13.000000000","message":"-1: Since this is for a snapshot please mock cinder.objects.Snapshot._get_by_id","commit_id":"c48d98c570b182641efa740b1620748da8672bb9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"71508e33925e9b23bdf8a3a77fde1fed216fd3ea","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                                    volume_size\u003dfake_size)"},{"line_number":42,"context_line":"        real_size \u003d 1"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        _get_by_id.return_value \u003d fake_snap"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        mock_db \u003d mock.MagicMock()"},{"line_number":47,"context_line":"        mock_driver \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_37ec91f2","line":44,"updated":"2017-02-15 13:31:13.000000000","message":"nit: This would be better right after we create the fake snapshot","commit_id":"c48d98c570b182641efa740b1620748da8672bb9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"71508e33925e9b23bdf8a3a77fde1fed216fd3ea","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        mock_driver \u003d mock.MagicMock()"},{"line_number":48,"context_line":"        mock_manage_existing_ref \u003d mock.MagicMock()"},{"line_number":49,"context_line":"        mock_manage_existing_snapshot \u003d self.mock_object("},{"line_number":50,"context_line":"            mock_driver, \u0027manage_existing_snapshot\u0027)"},{"line_number":51,"context_line":"        mock_manage_existing_snapshot.return_value \u003d {}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        task \u003d manager.ManageExistingTask(mock_db, mock_driver)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_d757b555","line":50,"updated":"2017-02-15 13:31:13.000000000","message":"-1: This is too convoluted, you can do this in 2 other more standard ways, either by defining it in the mock_driver creation:\n\n mock_driver \u003d mock.Mock(**{\u0027manage_existing_snapshot.return_value\u0027: {}})\n\nOr assigning the value here:\n\n mock_driver.manage_existing_snapshot.return_value \u003d {}","commit_id":"c48d98c570b182641efa740b1620748da8672bb9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"71508e33925e9b23bdf8a3a77fde1fed216fd3ea","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        result \u003d task.execute(self.ctxt, fake_snap, mock_manage_existing_ref,"},{"line_number":55,"context_line":"                              real_size)"},{"line_number":56,"context_line":"        snap_after_manage \u003d result[\u0027snapshot\u0027]"},{"line_number":57,"context_line":"        # to be sure that snapshot\u0027s volume_size attr has been changed"},{"line_number":58,"context_line":"        self.assertNotEqual(fake_size, snap_after_manage[\u0027volume_size\u0027])"},{"line_number":59,"context_line":"        # and it equals that size, that we want"},{"line_number":60,"context_line":"        self.assertEqual(real_size, snap_after_manage[\u0027volume_size\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_37f7315a","line":59,"range":{"start_line":57,"start_character":1,"end_line":59,"end_character":1},"updated":"2017-02-15 13:31:13.000000000","message":"-1: This is unnecessary, if L60\u0027s assert is true (\u003d 1) then it\u0027s already proven that it\u0027s not equal to 3.","commit_id":"c48d98c570b182641efa740b1620748da8672bb9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ef20bef452b7fe4f03e320ec7a8a22e742077eb0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(ManageSnapshotFlowTestCase, self).setUp()"},{"line_number":30,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @mock.patch(\u0027cinder.db.sqlalchemy.api._snapshot_get\u0027)"},{"line_number":33,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.Snapshot.get_by_id\u0027)"},{"line_number":34,"context_line":"    def test_manage_snapshot_after_volume_extending(self, _get_by_id,"},{"line_number":35,"context_line":"                                                    _snapshot_get):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_f4fb8a45","line":32,"updated":"2017-02-28 09:19:39.000000000","message":"-1: This mock is unnecessary","commit_id":"ea39f99629fe6413f26b18353aaa56fccc9da910"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"e767d303567097f15b9ce39ce2cf2e579e448ec8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        super(ManageSnapshotFlowTestCase, self).setUp()"},{"line_number":30,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @mock.patch(\u0027cinder.db.sqlalchemy.api._snapshot_get\u0027)"},{"line_number":33,"context_line":"    @mock.patch(\u0027cinder.objects.snapshot.Snapshot.get_by_id\u0027)"},{"line_number":34,"context_line":"    def test_manage_snapshot_after_volume_extending(self, _get_by_id,"},{"line_number":35,"context_line":"                                                    _snapshot_get):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba2be162_1bdacb78","line":32,"in_reply_to":"da36d5c6_f4fb8a45","updated":"2017-03-02 09:57:13.000000000","message":"oh, sorry, forgot to remove it. Thank you","commit_id":"ea39f99629fe6413f26b18353aaa56fccc9da910"}],"cinder/volume/flows/manager/manage_existing_snapshot.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"79b5c068b855703c34873b8b3543e64b5b5c7b26","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            existing_ref\u003dmanage_existing_ref)"},{"line_number":239,"context_line":"        if not model_update:"},{"line_number":240,"context_line":"            model_update \u003d {}"},{"line_number":241,"context_line":"        model_update.update({\u0027volume_size\u0027: size})"},{"line_number":242,"context_line":"        try:"},{"line_number":243,"context_line":"            snapshot_object \u003d objects.Snapshot.get_by_id(context,"},{"line_number":244,"context_line":"                                                         snapshot_ref[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_5e8e9ad0","line":241,"updated":"2017-01-31 09:33:14.000000000","message":"-1: Please don\u0027t create a new dictionary just for this:\n\n model_update[\u0027volume_size\u0027] \u003d size","commit_id":"c112f8d89fe3d1eee75ef69382eb6ebd375cf73b"}]}