)]}'
{"cinder/image/image_utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4be5893a12c721c15d0772a486f3d10b60098df5","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    #"},{"line_number":459,"context_line":"    # NOTE(lpetrut): On Windows, psutil.disk_usage expects a directory."},{"line_number":460,"context_line":"    if os.name \u003d\u003d \u0027nt\u0027 and not os.path.isdir(dest):"},{"line_number":461,"context_line":"        dest \u003d os.path.dirname(dest)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    free_space \u003d psutil.disk_usage(dest).free"},{"line_number":464,"context_line":"    if free_space \u003c\u003d image_size:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_f0171f52","line":461,"updated":"2017-02-03 16:23:48.000000000","message":"psutil.disk_usage() will work with a dir on all platforms, so we shouldn\u0027t make this os-specific.  Just always pass only the dir.","commit_id":"3801bd1e6c3eab3ac87d3881d3f3f2478c1f321e"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"68a8d50e1f32e75dbfb8bcffa227e6565f42142d","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    #"},{"line_number":459,"context_line":"    # NOTE(lpetrut): On Windows, psutil.disk_usage expects a directory."},{"line_number":460,"context_line":"    if os.name \u003d\u003d \u0027nt\u0027 and not os.path.isdir(dest):"},{"line_number":461,"context_line":"        dest \u003d os.path.dirname(dest)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    free_space \u003d psutil.disk_usage(dest).free"},{"line_number":464,"context_line":"    if free_space \u003c\u003d image_size:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_ab628ad6","line":461,"in_reply_to":"1a430d35_f0171f52","updated":"2017-02-03 16:28:20.000000000","message":"Haven\u0027t checked to be honest, thanks for pointing this out.\n\nUpdating it now.","commit_id":"3801bd1e6c3eab3ac87d3881d3f3f2478c1f321e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"10b171646443abb3a9659dbf2d9cd08dcddcb301","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    # TODO(e0ne): replace psutil with shutil.disk_usage when we drop"},{"line_number":457,"context_line":"    # Python 2.7 support."},{"line_number":458,"context_line":"    if not os.path.isdir(dest):"},{"line_number":459,"context_line":"        dest \u003d os.path.dirname(dest)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    free_space \u003d psutil.disk_usage(dest).free"},{"line_number":462,"context_line":"    if free_space \u003c\u003d image_size:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_7eca19a3","line":459,"updated":"2017-02-03 18:54:02.000000000","message":"This will still fail on Windows if \"dest\" is a file that does not exist yet, because isdir() will return false.","commit_id":"5bd297dae5e7cf5be728e11c5a55c976e95e959c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b47c7ad2a8d497bdb9b7921124d3000958145cce","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    # TODO(e0ne): replace psutil with shutil.disk_usage when we drop"},{"line_number":457,"context_line":"    # Python 2.7 support."},{"line_number":458,"context_line":"    if not os.path.isdir(dest):"},{"line_number":459,"context_line":"        dest \u003d os.path.dirname(dest)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    free_space \u003d psutil.disk_usage(dest).free"},{"line_number":462,"context_line":"    if free_space \u003c\u003d image_size:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_de794d31","line":459,"in_reply_to":"1a430d35_7eca19a3","updated":"2017-02-03 18:58:11.000000000","message":"Never mind, that was backwards.  Looks good.","commit_id":"5bd297dae5e7cf5be728e11c5a55c976e95e959c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"88c9fb2a8961a236d0ff102af31adb043da3bbef","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    free_space \u003d psutil.disk_usage(dest).free"},{"line_number":462,"context_line":"    if free_space \u003c\u003d image_size:"},{"line_number":463,"context_line":"        msg \u003d (\u0027There is no space to convert image. \u0027"},{"line_number":464,"context_line":"               \u0027Requested: %(image_size)s, available: %(free_space)s\u0027"},{"line_number":465,"context_line":"               ) % {\u0027image_size\u0027: image_size, \u0027free_space\u0027: free_space}"},{"line_number":466,"context_line":"        raise exception.ImageUnacceptable(image_id\u003dimage_id, reason\u003dmsg)"},{"line_number":467,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_cb55161e","line":464,"updated":"2017-02-03 16:46:36.000000000","message":"Good catch!","commit_id":"5bd297dae5e7cf5be728e11c5a55c976e95e959c"}]}