)]}'
{"cinder/api/v1/limits.py":[{"author":{"_account_id":23276,"name":"Nicholas Jones","email":"nj762h@att.com","username":"nj762h"},"change_message_id":"e654bf81bd09f0b293e2861856055725c7f6b4e6","unresolved":false,"context_lines":[{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        resp \u003d conn.getresponse()"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        if http_client.OK \u003e\u003d resp.status \u003c http_client.MULTIPLE_CHOICES:"},{"line_number":422,"context_line":"            return None, None"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        return resp.getheader(\"X-Wait-Seconds\"), resp.read() or None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_eb470249","line":421,"range":{"start_line":421,"start_character":8,"end_line":421,"end_character":71},"updated":"2017-03-01 21:38:10.000000000","message":"For what it\u0027s worth I disagree. While MULTIPLE_CHOICES might not be more readable, it\u0027s certainly not less readable. The overall change to constants is worth having to look up status codes occasionally.","commit_id":"4e92f4079e18cadc8c2e58eafa101c6452e53d92"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d615816c11605b6643c783c50f0f709218791c5a","unresolved":false,"context_lines":[{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        resp \u003d conn.getresponse()"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        if http_client.OK \u003e\u003d resp.status \u003c http_client.MULTIPLE_CHOICES:"},{"line_number":422,"context_line":"            return None, None"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        return resp.getheader(\"X-Wait-Seconds\"), resp.read() or None"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_4bd76cbf","line":421,"updated":"2017-02-27 17:43:41.000000000","message":"I don\u0027t like this change. First because MULTIPLE_CHOICES is not well known (I didn\"t know it was 300) then because the overall statement conveys the intent less clearly now, imo.","commit_id":"4e92f4079e18cadc8c2e58eafa101c6452e53d92"}]}
