)]}'
{"cinder/volume/drivers/dell_emc/vmax/masking.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c47bd15c7b8ef495ac25a6ac05e23d1158dc4060","unresolved":false,"context_lines":[{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"        @lockutils.synchronized("},{"line_number":1745,"context_line":"            defaultStorageGroupInstanceName[\u0027ElementName\u0027],"},{"line_number":1746,"context_line":"            \"emc-sg-\", True)"},{"line_number":1747,"context_line":"        def do_remove_vol_from_sg():"},{"line_number":1748,"context_line":"            assocVolumeInstanceNames \u003d self.get_devices_from_storage_group("},{"line_number":1749,"context_line":"                conn, defaultStorageGroupInstanceName)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_551700a3","line":1746,"updated":"2017-02-03 17:54:41.000000000","message":"shouldn\u0027t we be using the newer @coordination from cinder.coordination instead of these forced local file locks?","commit_id":"edf7b220eff0c7f3840efdc8a76d7a0daf4437c0"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e086f397a397437e9e30a1f71196d917fb66cd83","unresolved":false,"context_lines":[{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"        @lockutils.synchronized("},{"line_number":1745,"context_line":"            defaultStorageGroupInstanceName[\u0027ElementName\u0027],"},{"line_number":1746,"context_line":"            \"emc-sg-\", True)"},{"line_number":1747,"context_line":"        def do_remove_vol_from_sg():"},{"line_number":1748,"context_line":"            assocVolumeInstanceNames \u003d self.get_devices_from_storage_group("},{"line_number":1749,"context_line":"                conn, defaultStorageGroupInstanceName)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_db2f9a9f","line":1746,"in_reply_to":"1a430d35_551700a3","updated":"2017-02-03 20:37:44.000000000","message":"Good point.  Search for \"@coordination.synchronized\" used in other drivers.","commit_id":"edf7b220eff0c7f3840efdc8a76d7a0daf4437c0"}],"cinder/volume/drivers/dell_emc/vmax/provision_v3.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e76a3f575d2ade4df185c3aba9dad0a896c6b126","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                        \"Error Create Volume: %(volumeName)s from \""},{"line_number":152,"context_line":"                        \"%(sg)s. Return code: %(rc)lu.  Error: %(error)s.\")"},{"line_number":153,"context_line":"                        % {\u0027volumeName\u0027: volumeName,"},{"line_number":154,"context_line":"                           \u0027sg\u0027: storageGroup,"},{"line_number":155,"context_line":"                           \u0027rc\u0027: rc,"},{"line_number":156,"context_line":"                           \u0027error\u0027: errordesc})"},{"line_number":157,"context_line":"                    LOG.error(exceptionMessage)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a430d35_5f998d1e","line":154,"updated":"2017-02-06 20:36:08.000000000","message":"This will change the exception message which is a user-facing message below.  We have now passed O-3 and are in soft string freeze, user-facing message should not be modified.\n\nAfter RC-1, which will happen soon, no translatable message changes should happen.  You can change debug messages, but not info/warning/error/exception LOG messages.\n\nSo I suggest that you remove the changes to the message.  You can add a debug message for the additional info.","commit_id":"3790ff1b303d86cac6029d5a31c443f521b53dd7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e76a3f575d2ade4df185c3aba9dad0a896c6b126","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                    exceptionMessage \u003d (_("},{"line_number":322,"context_line":"                        \"Error Create Cloned Volume: %(cloneName)s in %(sg)s\""},{"line_number":323,"context_line":"                        \"Return code: %(rc)lu. Error: %(error)s.\")"},{"line_number":324,"context_line":"                        % {\u0027cloneName\u0027: cloneName, \u0027sg\u0027: storageGroupName,"},{"line_number":325,"context_line":"                           \u0027rc\u0027: rc, \u0027error\u0027: errordesc})"},{"line_number":326,"context_line":"                    LOG.error(exceptionMessage)"},{"line_number":327,"context_line":"                    raise exception.VolumeBackendAPIException("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a430d35_bf5fd13f","line":324,"updated":"2017-02-06 20:36:08.000000000","message":"See above comments.  Don\u0027t change this message.","commit_id":"3790ff1b303d86cac6029d5a31c443f521b53dd7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"e76a3f575d2ade4df185c3aba9dad0a896c6b126","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                    LOG.error(_LE("},{"line_number":510,"context_line":"                        \"Error Create Group: %(groupName)s. \""},{"line_number":511,"context_line":"                        \"Return code: %(rc)lu.  Error: %(error)s.\"),"},{"line_number":512,"context_line":"                        {\u0027groupName\u0027: sgGroupName,"},{"line_number":513,"context_line":"                         \u0027rc\u0027: rc,"},{"line_number":514,"context_line":"                         \u0027error\u0027: errordesc})"},{"line_number":515,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a430d35_9f3f75d5","line":512,"range":{"start_line":512,"start_character":38,"end_line":512,"end_character":49},"updated":"2017-02-06 20:36:08.000000000","message":"Don\u0027t change the variable name.  Go back to groupName.","commit_id":"3790ff1b303d86cac6029d5a31c443f521b53dd7"}]}