)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4823cfee38c9dfa6f266014b2b8141c08a402571","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix attachments after attached migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When migrating an attached volume, after the migration completion,"},{"line_number":10,"context_line":"the volume gots stuck and can not be deleted or detached. This"},{"line_number":11,"context_line":"is happening due an error in the volume completion implementation."},{"line_number":12,"context_line":"Now, before detaching the source volume, we first save the"},{"line_number":13,"context_line":"attachments and then re-connect then in the destination volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a461143_6e30929f","line":10,"range":{"start_line":10,"start_character":37,"end_line":10,"end_character":57},"updated":"2017-02-02 19:11:55.000000000","message":"deleted, detached or retyped","commit_id":"127f7cd297a18f0df8ac996a2dd01b1091ce37fc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4823cfee38c9dfa6f266014b2b8141c08a402571","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix attachments after attached migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When migrating an attached volume, after the migration completion,"},{"line_number":10,"context_line":"the volume gots stuck and can not be deleted or detached. This"},{"line_number":11,"context_line":"is happening due an error in the volume completion implementation."},{"line_number":12,"context_line":"Now, before detaching the source volume, we first save the"},{"line_number":13,"context_line":"attachments and then re-connect then in the destination volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a461143_8e405e09","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":15},"updated":"2017-02-02 19:11:55.000000000","message":"gets","commit_id":"127f7cd297a18f0df8ac996a2dd01b1091ce37fc"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4823cfee38c9dfa6f266014b2b8141c08a402571","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When migrating an attached volume, after the migration completion,"},{"line_number":10,"context_line":"the volume gots stuck and can not be deleted or detached. This"},{"line_number":11,"context_line":"is happening due an error in the volume completion implementation."},{"line_number":12,"context_line":"Now, before detaching the source volume, we first save the"},{"line_number":13,"context_line":"attachments and then re-connect then in the destination volume."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a461143_4eb916ec","line":11,"range":{"start_line":11,"start_character":17,"end_line":11,"end_character":64},"updated":"2017-02-02 19:11:55.000000000","message":"to the destination volume being refreshed after the original attachments had been detached from the source. As a result no attachments are found for the new volume.","commit_id":"127f7cd297a18f0df8ac996a2dd01b1091ce37fc"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"bdc50aec43bfdd4206067a9fa0ad4fdfa14be468","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix attachments after attached migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When migrating an attached volume, after the migration completion,"},{"line_number":10,"context_line":"the volume gots stuck and can not be deleted or detached. This"},{"line_number":11,"context_line":"is happening due an error in the volume completion implementation."},{"line_number":12,"context_line":"Now, before detaching the source volume, we first save the"},{"line_number":13,"context_line":"attachments and then re-connect then in the destination volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa31d9ce_febf22cd","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":15},"updated":"2017-02-15 20:00:06.000000000","message":"gets","commit_id":"a5ae53867bbe7f66bd640061a68a690c6d217177"}],"cinder/tests/unit/volume/test_volume_migration.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7756df50d97a918120d56dc5a97220aceafebefb","unresolved":false,"context_lines":[{"line_number":532,"context_line":"                                        retyping\u003dFalse,"},{"line_number":533,"context_line":"                                        previous_status\u003d\u0027available\u0027):"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        initial_status \u003d retyping and \u0027retyping\u0027 or status"},{"line_number":536,"context_line":"        old_volume \u003d tests_utils.create_volume(self.context, size\u003d0,"},{"line_number":537,"context_line":"                                               host\u003dCONF.host,"},{"line_number":538,"context_line":"                                               status\u003dinitial_status,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_d92ef88a","line":535,"updated":"2017-02-15 20:14:41.000000000","message":"nit: This was unnecessary and makes the code less clear imo","commit_id":"a5ae53867bbe7f66bd640061a68a690c6d217177"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ce4343e96160c5fe63efc736de880260e030f8f1","unresolved":false,"context_lines":[{"line_number":532,"context_line":"                                        retyping\u003dFalse,"},{"line_number":533,"context_line":"                                        previous_status\u003d\u0027available\u0027):"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        initial_status \u003d retyping and \u0027retyping\u0027 or status"},{"line_number":536,"context_line":"        old_volume \u003d tests_utils.create_volume(self.context, size\u003d0,"},{"line_number":537,"context_line":"                                               host\u003dCONF.host,"},{"line_number":538,"context_line":"                                               status\u003dinitial_status,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_3940f406","line":535,"in_reply_to":"fa31d9ce_d92ef88a","updated":"2017-02-15 20:17:07.000000000","message":"Hmm, there\u0027s actually another patch that just went through to get rid of this deprecated ternary assignment.\n\nhttps://review.openstack.org/#/c/432372/","commit_id":"a5ae53867bbe7f66bd640061a68a690c6d217177"}],"cinder/volume/manager.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"4823cfee38c9dfa6f266014b2b8141c08a402571","unresolved":false,"context_lines":[{"line_number":1921,"context_line":"        # We keep volume_attachment for later attach."},{"line_number":1922,"context_line":"        volume_attachments \u003d []"},{"line_number":1923,"context_line":"        if orig_volume_status \u003d\u003d \u0027in-use\u0027:"},{"line_number":1924,"context_line":"            for attachment in volume.volume_attachment:"},{"line_number":1925,"context_line":"                # Save the attachments the volume currently have"},{"line_number":1926,"context_line":"                volume_attachments.append(attachment)"},{"line_number":1927,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_cea2669a","line":1924,"range":{"start_line":1924,"start_character":30,"end_line":1924,"end_character":54},"updated":"2017-02-02 19:11:55.000000000","message":"Can\u0027t we just save this and iterate back over it later?","commit_id":"127f7cd297a18f0df8ac996a2dd01b1091ce37fc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7e0e109af48005813dca4e07cd65b3b7d34c19e2","unresolved":false,"context_lines":[{"line_number":1921,"context_line":"        # We keep volume_attachment for later attach."},{"line_number":1922,"context_line":"        volume_attachments \u003d []"},{"line_number":1923,"context_line":"        if orig_volume_status \u003d\u003d \u0027in-use\u0027:"},{"line_number":1924,"context_line":"            for attachment in volume.volume_attachment:"},{"line_number":1925,"context_line":"                # Save the attachments the volume currently have"},{"line_number":1926,"context_line":"                volume_attachments.append(attachment)"},{"line_number":1927,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_acaaad6e","line":1924,"range":{"start_line":1924,"start_character":30,"end_line":1924,"end_character":54},"in_reply_to":"3a461143_cea2669a","updated":"2017-02-03 11:58:53.000000000","message":"I was going to suggest it as well, but since we don\u0027t own here the actual list of volume_attachment it could be changed (for example removing elements) by any method, so we need to keep our own list, and our options are doing a full copy of the list in one go or by adding elements to an empty list as it is doing here.\n\nI didn\u0027t feel like it would be such a great improvement the one shot copy of the list to justify a downvote.","commit_id":"127f7cd297a18f0df8ac996a2dd01b1091ce37fc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"196d3a92f1ce7982b1b48f723e31e6f0d123b57b","unresolved":false,"context_lines":[{"line_number":1941,"context_line":"        # the current host and driver object is for the \"existing\" volume."},{"line_number":1942,"context_line":"        rpcapi.update_migrated_volume(ctxt, volume, new_volume,"},{"line_number":1943,"context_line":"                                      orig_volume_status)"},{"line_number":1944,"context_line":"        volume.refresh()"},{"line_number":1945,"context_line":"        new_volume.refresh()"},{"line_number":1946,"context_line":""},{"line_number":1947,"context_line":"        # Swap src and dest DB records so we can continue using the src id and"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_e22e87f9","line":1944,"updated":"2017-02-01 17:46:54.000000000","message":"This is where the issue was introduced, refreshing destroyed the volume.volume_attachment data!!!","commit_id":"127f7cd297a18f0df8ac996a2dd01b1091ce37fc"}]}