)]}'
{"cinder/opts.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6cc61a4cf07cbaf4e2956726d9b64f1696be5ab1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"from cinder.volume.drivers.datera import datera_iscsi as \\"},{"line_number":75,"context_line":"    cinder_volume_drivers_datera_dateraiscsi"},{"line_number":76,"context_line":"from cinder.volume.drivers.dell_emc.sc import dell_storagecenter_common as \\"},{"line_number":77,"context_line":"    cinder_volume_drivers_dell_dellstoragecentercommon"},{"line_number":78,"context_line":"from cinder.volume.drivers.dell_emc import ps as \\"},{"line_number":79,"context_line":"    cinder_volume_drivers_dell_emc_ps"},{"line_number":80,"context_line":"from cinder.volume.drivers.dell_emc.scaleio import driver as \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_2dc269e9","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":54},"updated":"2017-01-31 20:57:38.000000000","message":"This needs to be changed, otherwise it won\u0027t pass Jenkins.","commit_id":"3e3610a1062ca244b6c2b8fd4c3ba6f69593ff30"}],"cinder/volume/drivers/dell_emc/sc/dell_storagecenter_api.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6cc61a4cf07cbaf4e2956726d9b64f1696be5ab1","unresolved":false,"context_lines":[{"line_number":608,"context_line":"                # will catch any errors."},{"line_number":609,"context_line":"                # Update our version and update our header."},{"line_number":610,"context_line":"                self.apiversion \u003d response.text.split(\u0027[\u0027)[1].split(\u0027,\u0027)[0]"},{"line_number":611,"context_line":"                self.client.header[\u0027x-de-api-version\u0027] \u003d self.apiversion"},{"line_number":612,"context_line":"                LOG.debug(\u0027API version updated to %s\u0027, self.apiversion)"},{"line_number":613,"context_line":"                # Give login another go."},{"line_number":614,"context_line":"                r \u003d self.client.post(\u0027ApiConnection/Login\u0027, payload)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_2d6989f9","line":611,"range":{"start_line":611,"start_character":38,"end_line":611,"end_character":40},"updated":"2017-01-31 20:57:38.000000000","message":"This seems to be an unrelated change?","commit_id":"3e3610a1062ca244b6c2b8fd4c3ba6f69593ff30"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ba385262f9fd012be107e60b94b8440f934a5b94","unresolved":false,"context_lines":[{"line_number":608,"context_line":"                # will catch any errors."},{"line_number":609,"context_line":"                # Update our version and update our header."},{"line_number":610,"context_line":"                self.apiversion \u003d response.text.split(\u0027[\u0027)[1].split(\u0027,\u0027)[0]"},{"line_number":611,"context_line":"                self.client.header[\u0027x-de-api-version\u0027] \u003d self.apiversion"},{"line_number":612,"context_line":"                LOG.debug(\u0027API version updated to %s\u0027, self.apiversion)"},{"line_number":613,"context_line":"                # Give login another go."},{"line_number":614,"context_line":"                r \u003d self.client.post(\u0027ApiConnection/Login\u0027, payload)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_9fc38037","line":611,"range":{"start_line":611,"start_character":38,"end_line":611,"end_character":40},"updated":"2017-01-31 21:18:25.000000000","message":"I don\u0027t think that was meant to be changed.","commit_id":"bb9c61f0a4f17d9fe7ff6f8238695182ac31060a"}],"cinder/volume/drivers/dell_emc/sc/dell_storagecenter_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f5a7a76d0df35f34e5e3a0c7420fedeb84c2d5dd","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            # Static stats."},{"line_number":706,"context_line":"            data \u003d {}"},{"line_number":707,"context_line":"            data[\u0027volume_backend_name\u0027] \u003d self.backend_name"},{"line_number":708,"context_line":"            data[\u0027vendor_name\u0027] \u003d \u0027Dell\u0027"},{"line_number":709,"context_line":"            data[\u0027driver_version\u0027] \u003d self.VERSION"},{"line_number":710,"context_line":"            data[\u0027storage_protocol\u0027] \u003d self.storage_protocol"},{"line_number":711,"context_line":"            data[\u0027reserved_percentage\u0027] \u003d 0"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_f3a034f6","line":708,"range":{"start_line":708,"start_character":35,"end_line":708,"end_character":39},"updated":"2017-02-01 04:15:48.000000000","message":"Please change vendor_name to \u0027Dell EMC\u0027","commit_id":"67cc903d757df322286afe068a5fbba9a7396706"}],"cinder/volume/drivers/dell_emc/sc/dell_storagecenter_fc.py":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"11676aee258377b86a60ff47f093ed4958f6b814","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\"Implements commands for Dell Storage Center FC management."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    To enable the driver add the following line to the cinder configuration:"},{"line_number":37,"context_line":"        volume_driver\u003dcinder.volume.drivers.sc.dell_storagecenter_fc.\\"},{"line_number":38,"context_line":"        DellStorageCenterFCDriver"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Version history:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a461143_c2144fea","line":37,"updated":"2017-01-31 21:42:10.000000000","message":"This is inconsistent with PS series\nvolume_driver\u003dcinder.volume.drivers.dell_emc.ps.PSSeriesISCSIDriver\n\ncinder.volume.drivers.dell_emc.sc.dell_storagecenter_fc ??","commit_id":"00787aa915f178531cfcd3c24031983b532760c0"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"5e5607b3cce45ee590e8c084d26124286a5a55d5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\"Implements commands for Dell Storage Center FC management."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    To enable the driver add the following line to the cinder configuration:"},{"line_number":37,"context_line":"        volume_driver\u003dcinder.volume.drivers.sc.dell_storagecenter_fc.\\"},{"line_number":38,"context_line":"        DellStorageCenterFCDriver"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Version history:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_a2766303","line":37,"updated":"2017-01-31 21:48:43.000000000","message":"Shouldn\u0027t this be cinder.volume.drivers.dell_emc.sc.dell_storagecenter_fc??","commit_id":"a0b0af697943094c93ded48934348f6f7f103463"}],"cinder/volume/drivers/dell_emc/sc/dell_storagecenter_iscsi.py":[{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"f0749e3b1cb2b2e2a9b183786ecb4162a5e4300d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        3.5.0 - Support for AFO."},{"line_number":62,"context_line":"        3.6.0 - Server type support."},{"line_number":63,"context_line":"        3.7.0 - Support for Data Reduction, Group QOS and Volume QOS."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    VERSION \u003d \u00273.7.0\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_5fa678ae","line":64,"updated":"2017-01-31 21:13:57.000000000","message":"Should we update the version\u003e","commit_id":"bb9c61f0a4f17d9fe7ff6f8238695182ac31060a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ba385262f9fd012be107e60b94b8440f934a5b94","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        3.5.0 - Support for AFO."},{"line_number":62,"context_line":"        3.6.0 - Server type support."},{"line_number":63,"context_line":"        3.7.0 - Support for Data Reduction, Group QOS and Volume QOS."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    VERSION \u003d \u00273.7.0\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_5ffbd878","line":64,"in_reply_to":"3a461143_5fa678ae","updated":"2017-01-31 21:18:25.000000000","message":"+1","commit_id":"bb9c61f0a4f17d9fe7ff6f8238695182ac31060a"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"5e5607b3cce45ee590e8c084d26124286a5a55d5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\"Implements commands for Dell Storage Center ISCSI management."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    To enable the driver add the following line to the cinder configuration:"},{"line_number":36,"context_line":"        volume_driver\u003dcinder.volume.drivers.sc.dell_storagecenter_iscsi.\\"},{"line_number":37,"context_line":"        DellStorageCenterISCSIDriver"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Version history:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_228273c8","line":36,"updated":"2017-01-31 21:48:43.000000000","message":"Shouldn\u0027t this be cinder.volume.drivers.dell_emc.sc.dell_storagecenter_iscsi??","commit_id":"a0b0af697943094c93ded48934348f6f7f103463"}],"cinder/volume/drivers/dell_emc/sc/storagecenter_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eed6f78c34a38f71fa3ac615d573e2a5ad193e73","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2016 Dell Inc, or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f013ff3_7a9f70b4","line":1,"range":{"start_line":1,"start_character":28,"end_line":1,"end_character":50},"updated":"2017-05-13 14:01:39.000000000","message":"This does need to be added because the merger didn\u0027t happen until 2017.  Also copyright info should not be changed when changing an existing file.","commit_id":"88215bb0a49c3da14a25b35757654807ce933509"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"04d0a88fd62e5a6c2be3a9d1ae6b3e9852747919","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2016 Dell Inc, or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f013ff3_4e6a9f80","line":1,"range":{"start_line":1,"start_character":28,"end_line":1,"end_character":50},"in_reply_to":"1f013ff3_42a95879","updated":"2017-05-15 16:22:12.000000000","message":"What am I doing? Removing this?","commit_id":"88215bb0a49c3da14a25b35757654807ce933509"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"b3f0b28dacdde0ec6af84784ba934c63b04a590b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2016 Dell Inc, or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f013ff3_eedccb47","line":1,"range":{"start_line":1,"start_character":28,"end_line":1,"end_character":50},"in_reply_to":"1f013ff3_4e6a9f80","updated":"2017-05-15 16:23:59.000000000","message":"May be make it same as PS?\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/dell_emc/ps.py","commit_id":"88215bb0a49c3da14a25b35757654807ce933509"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"90101976793c14f10bd52484238e15c976b30938","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2016 Dell Inc, or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f013ff3_9b27cc65","line":1,"range":{"start_line":1,"start_character":28,"end_line":1,"end_character":50},"in_reply_to":"1f013ff3_7a9f70b4","updated":"2017-05-15 13:17:59.000000000","message":"We were given mixed direction on that. Some in legal had stated any time a file was updated, the copyright header should be updated as well.","commit_id":"88215bb0a49c3da14a25b35757654807ce933509"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9178332f8111ae7aaf3640341d283fda4a2e2034","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Copyright 2016 Dell Inc, or its subsidiaries."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f013ff3_42a95879","line":1,"range":{"start_line":1,"start_character":28,"end_line":1,"end_character":50},"in_reply_to":"1f013ff3_9b27cc65","updated":"2017-05-15 14:24:49.000000000","message":"If the copyright is in 2017, I think it should be fine to have the new header, but the merger didn\u0027t happen in 2016 and before.\n\nEven if you want to keep this change in this file, this is not consistent even within this patch.  The file cinder/volume/drivers/dell_emc/sc/storagecenter_api.py has the same 2016 copyright header but was not changed.","commit_id":"88215bb0a49c3da14a25b35757654807ce933509"}],"cinder/volume/manager.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f5a7a76d0df35f34e5e3a0c7420fedeb84c2d5dd","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    \u0027cinder.volume.drivers.dell_emc.ps.PSSeriesISCSIDriver\u0027,"},{"line_number":174,"context_line":"    \u0027cinder.volume.drivers.dell.dell_storagecenter_iscsi.\u0027"},{"line_number":175,"context_line":"    \u0027DellStorageCenterISCSIDriver\u0027:"},{"line_number":176,"context_line":"    \u0027cinder.volume.drivers.dell_emc.sc.dell_storagecenter_iscsi.\u0027"},{"line_number":177,"context_line":"    \u0027DellStorageCenterISCSIDriver\u0027,"},{"line_number":178,"context_line":"    \u0027cinder.volume.drivers.dell.dell_storagecenter_fc.\u0027"},{"line_number":179,"context_line":"    \u0027DellStorageCenterFCDriver\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_3359dc35","line":176,"range":{"start_line":176,"start_character":39,"end_line":176,"end_character":44},"updated":"2017-02-01 04:15:48.000000000","message":"Do you have to keep \"dell_\" in the file name?  \"dell_emc\" is already in the file path.  We dropped \"emc_\" from ours.","commit_id":"67cc903d757df322286afe068a5fbba9a7396706"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"01664490e90ea308d48baa2362e05f5b3096c6de","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    \u0027cinder.volume.drivers.dell_emc.ps.PSSeriesISCSIDriver\u0027,"},{"line_number":174,"context_line":"    \u0027cinder.volume.drivers.dell.dell_storagecenter_iscsi.\u0027"},{"line_number":175,"context_line":"    \u0027DellStorageCenterISCSIDriver\u0027:"},{"line_number":176,"context_line":"    \u0027cinder.volume.drivers.dell_emc.sc.dell_storagecenter_iscsi.\u0027"},{"line_number":177,"context_line":"    \u0027DellStorageCenterISCSIDriver\u0027,"},{"line_number":178,"context_line":"    \u0027cinder.volume.drivers.dell.dell_storagecenter_fc.\u0027"},{"line_number":179,"context_line":"    \u0027DellStorageCenterFCDriver\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_d3eb3811","line":176,"range":{"start_line":176,"start_character":39,"end_line":176,"end_character":44},"in_reply_to":"3a461143_3359dc35","updated":"2017-02-01 04:17:33.000000000","message":"I agree, the dell_storagecenter file prefix should change now too.","commit_id":"67cc903d757df322286afe068a5fbba9a7396706"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f5a7a76d0df35f34e5e3a0c7420fedeb84c2d5dd","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    \u0027cinder.volume.drivers.dell.dell_storagecenter_iscsi.\u0027"},{"line_number":175,"context_line":"    \u0027DellStorageCenterISCSIDriver\u0027:"},{"line_number":176,"context_line":"    \u0027cinder.volume.drivers.dell_emc.sc.dell_storagecenter_iscsi.\u0027"},{"line_number":177,"context_line":"    \u0027DellStorageCenterISCSIDriver\u0027,"},{"line_number":178,"context_line":"    \u0027cinder.volume.drivers.dell.dell_storagecenter_fc.\u0027"},{"line_number":179,"context_line":"    \u0027DellStorageCenterFCDriver\u0027:"},{"line_number":180,"context_line":"    \u0027cinder.volume.drivers.dell_emc.sc.dell_storagecenter_fc.\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_934a9053","line":177,"range":{"start_line":177,"start_character":5,"end_line":177,"end_character":9},"updated":"2017-02-01 04:15:48.000000000","message":"Do you have to keep Dell in the driver name?  We dropped EMC from ours.","commit_id":"67cc903d757df322286afe068a5fbba9a7396706"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f5a7a76d0df35f34e5e3a0c7420fedeb84c2d5dd","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    \u0027DellStorageCenterISCSIDriver\u0027,"},{"line_number":178,"context_line":"    \u0027cinder.volume.drivers.dell.dell_storagecenter_fc.\u0027"},{"line_number":179,"context_line":"    \u0027DellStorageCenterFCDriver\u0027:"},{"line_number":180,"context_line":"    \u0027cinder.volume.drivers.dell_emc.sc.dell_storagecenter_fc.\u0027"},{"line_number":181,"context_line":"    \u0027DellStorageCenterFCDriver\u0027,"},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_f3791494","line":180,"range":{"start_line":180,"start_character":39,"end_line":180,"end_character":44},"updated":"2017-02-01 04:15:48.000000000","message":"Same","commit_id":"67cc903d757df322286afe068a5fbba9a7396706"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f5a7a76d0df35f34e5e3a0c7420fedeb84c2d5dd","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    \u0027cinder.volume.drivers.dell.dell_storagecenter_fc.\u0027"},{"line_number":179,"context_line":"    \u0027DellStorageCenterFCDriver\u0027:"},{"line_number":180,"context_line":"    \u0027cinder.volume.drivers.dell_emc.sc.dell_storagecenter_fc.\u0027"},{"line_number":181,"context_line":"    \u0027DellStorageCenterFCDriver\u0027,"},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_3370fca3","line":181,"range":{"start_line":181,"start_character":5,"end_line":181,"end_character":9},"updated":"2017-02-01 04:15:48.000000000","message":"Same","commit_id":"67cc903d757df322286afe068a5fbba9a7396706"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06cf8aa672b7e747db16b8ec67afce3134a751e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    \u0027cinder.volume.drivers.dell_emc.ps.PSSeriesISCSIDriver\u0027,"},{"line_number":174,"context_line":"    \u0027cinder.volume.drivers.dell.dell_storagecenter_iscsi.\u0027"},{"line_number":175,"context_line":"    \u0027SCISCSIDriver\u0027:"},{"line_number":176,"context_line":"    \u0027cinder.volume.drivers.dell_emc.sc.dell_storagecenter_iscsi.\u0027"},{"line_number":177,"context_line":"    \u0027SCISCSIDriver\u0027,"},{"line_number":178,"context_line":"    \u0027cinder.volume.drivers.dell.dell_storagecenter_fc.\u0027"},{"line_number":179,"context_line":"    \u0027SCFCDriver\u0027:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_1d774603","line":176,"range":{"start_line":176,"start_character":39,"end_line":176,"end_character":44},"updated":"2017-02-02 18:13:51.000000000","message":"\"dell_\" should be removed.","commit_id":"ecb85c94b8e2a103badd976fd103c321d0b5eea7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06cf8aa672b7e747db16b8ec67afce3134a751e","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    \u0027SCISCSIDriver\u0027,"},{"line_number":178,"context_line":"    \u0027cinder.volume.drivers.dell.dell_storagecenter_fc.\u0027"},{"line_number":179,"context_line":"    \u0027SCFCDriver\u0027:"},{"line_number":180,"context_line":"    \u0027cinder.volume.drivers.dell_emc.sc.dell_storagecenter_fc.\u0027"},{"line_number":181,"context_line":"    \u0027SCFCDriver\u0027,"},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_5d5f0e75","line":180,"range":{"start_line":180,"start_character":39,"end_line":180,"end_character":44},"updated":"2017-02-02 18:13:51.000000000","message":"Same comment here.","commit_id":"ecb85c94b8e2a103badd976fd103c321d0b5eea7"}],"releasenotes/notes/Dell-SC-Driver-to-dell_emc-folder-e5d6fb1f1cf84149.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ba385262f9fd012be107e60b94b8440f934a5b94","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Moved Dell SC driver from cinder.volume.drivers.dell"},{"line_number":4,"context_line":"    to cinder.volume.drivers.dell_emc.sc."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a461143_ff09e495","line":4,"updated":"2017-01-31 21:18:25.000000000","message":"Please note the changes that need to be made to volume_driver for the new values.","commit_id":"bb9c61f0a4f17d9fe7ff6f8238695182ac31060a"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f5a7a76d0df35f34e5e3a0c7420fedeb84c2d5dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Moved Dell SC driver from cinder.volume.drivers.dell"},{"line_number":4,"context_line":"    to cinder.volume.drivers.dell_emc.sc."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3a461143_d3289888","line":4,"updated":"2017-02-01 04:15:48.000000000","message":"This should be under upgrades.  Also please specify the new volume_driver entry in cinder.conf.  Please see example here:\n\nhttps://review.openstack.org/#/c/415565/7/releasenotes/notes/move-eqlx-driver-to-dell-emc-fe5d2b484c47b7a6.yaml","commit_id":"67cc903d757df322286afe068a5fbba9a7396706"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b06cf8aa672b7e747db16b8ec67afce3134a751e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Moved Dell SC driver from cinder.volume.drivers.dell"},{"line_number":4,"context_line":"    to cinder.volume.drivers.dell_emc.sc."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3a461143_dd6cde38","line":2,"updated":"2017-02-02 18:13:51.000000000","message":"This should be under upgrades, not features.  Also please specify the new volume_driver entry in cinder.conf.  Please see example here:\n\nhttps://review.openstack.org/#/c/415565/7/releasenotes/notes/move-eqlx-driver-to-dell-emc-fe5d2b484c47b7a6.yaml","commit_id":"ecb85c94b8e2a103badd976fd103c321d0b5eea7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"687a5cb262936872e10af8883e7877473f671c3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Moved Dell SC driver from cinder.volume.drivers.dell"},{"line_number":4,"context_line":"    to cinder.volume.drivers.dell_emc.sc."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3a461143_2bf5a782","line":3,"range":{"start_line":3,"start_character":18,"end_line":3,"end_character":56},"updated":"2017-02-02 15:13:11.000000000","message":"This should be surrounded with ``","commit_id":"ecb85c94b8e2a103badd976fd103c321d0b5eea7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"687a5cb262936872e10af8883e7877473f671c3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Moved Dell SC driver from cinder.volume.drivers.dell"},{"line_number":4,"context_line":"    to cinder.volume.drivers.dell_emc.sc."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3a461143_6b1defbc","line":4,"range":{"start_line":4,"start_character":7,"end_line":4,"end_character":40},"updated":"2017-02-02 15:13:11.000000000","message":"Same comment here ``","commit_id":"ecb85c94b8e2a103badd976fd103c321d0b5eea7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d1553966a697f4023eaff3592be670908572c2d6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - The Dell Storage Center driver is moved to the dell_emc directory"},{"line_number":4,"context_line":"    and has been rebranded to its current Dell EMC SC name. The"},{"line_number":5,"context_line":"    volume_driver entry in cinder.conf needs to be changed to"},{"line_number":6,"context_line":"    ``cinder.volume.drivers.dell_emc.cs.SCFCDriver`` for FC or"},{"line_number":7,"context_line":"    ``cinder.volume.drivers.dell_emc.cs.SCISCSIDriver`` for ISCSI."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a430d35_fbe4563c","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":52},"updated":"2017-02-03 20:19:01.000000000","message":"``cinder.volume.drivers.dell_emc.sc.storagecenter_fc.SCFCDriver``","commit_id":"ccdadf5610018f2df37f9f2145a2607d55d15067"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d1553966a697f4023eaff3592be670908572c2d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    and has been rebranded to its current Dell EMC SC name. The"},{"line_number":5,"context_line":"    volume_driver entry in cinder.conf needs to be changed to"},{"line_number":6,"context_line":"    ``cinder.volume.drivers.dell_emc.cs.SCFCDriver`` for FC or"},{"line_number":7,"context_line":"    ``cinder.volume.drivers.dell_emc.cs.SCISCSIDriver`` for ISCSI."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a430d35_dbbebafe","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":55},"updated":"2017-02-03 20:19:01.000000000","message":"``cinder.volume.drivers.dell_emc.sc.storagecenter_iscsi.SCISCSIDriver``","commit_id":"ccdadf5610018f2df37f9f2145a2607d55d15067"}]}