)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"e4811ac0203fae47e9c6eb6b42d1deca67953d8b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"List api for manageable volumes and snapshots returns 500 error if you pass"},{"line_number":10,"context_line":"non-existent marker to it. Both the calls gives rpc.call to volume service"},{"line_number":11,"context_line":"for returning the list. Volume service returns InvalidInput but it\u0027s not"},{"line_number":12,"context_line":"catched at c-api side."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"At c-api side it comes in the form of oslo_messaging.messaging.RemoteError."},{"line_number":15,"context_line":"Caught \u0027InvalidInput\u0027 exception by checking RemoteError.exc_type and raised"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a430d35_3211b4ad","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":7},"updated":"2017-02-03 13:05:46.000000000","message":"caught","commit_id":"bb3bfb14340efe11af9152d625662bbb3acc094b"}],"cinder/api/contrib/resource_common_manage.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"26a9ccffa1b882db922795b45689f6684b7c42c6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    except messaging.RemoteError as err:"},{"line_number":50,"context_line":"        if err.exc_type \u003d\u003d \"InvalidInput\":"},{"line_number":51,"context_line":"            raise exception.InvalidInput(err.value)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            # There are also few cases where manageable volumes and snapshots"},{"line_number":54,"context_line":"            # calls could fail due to db or volume driver errors. These errors"},{"line_number":55,"context_line":"            # shouldn\u0027t be exposed to the user and in such cases it should"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_4f8f9175","line":52,"updated":"2017-02-01 13:09:19.000000000","message":"nit: No need for the else","commit_id":"44990f738165bfa22556d8b79fa3e405cb952f6c"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"ed1c7896c9fc60052ca7a2552603d81671dc7f7f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    except messaging.RemoteError as err:"},{"line_number":50,"context_line":"        if err.exc_type \u003d\u003d \"InvalidInput\":"},{"line_number":51,"context_line":"            raise exception.InvalidInput(err.value)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            # There are also few cases where manageable volumes and snapshots"},{"line_number":54,"context_line":"            # calls could fail due to db or volume driver errors. These errors"},{"line_number":55,"context_line":"            # shouldn\u0027t be exposed to the user and in such cases it should"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_6a81928f","line":52,"in_reply_to":"3a461143_4f8f9175","updated":"2017-02-03 06:15:18.000000000","message":"Done","commit_id":"44990f738165bfa22556d8b79fa3e405cb952f6c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"26a9ccffa1b882db922795b45689f6684b7c42c6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            # calls could fail due to db or volume driver errors. These errors"},{"line_number":55,"context_line":"            # shouldn\u0027t be exposed to the user and in such cases it should"},{"line_number":56,"context_line":"            # raise 500 error."},{"line_number":57,"context_line":"            raise"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    resource_count \u003d len(resources)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_cf7aa177","line":57,"updated":"2017-02-01 13:09:19.000000000","message":"I think we should be raising the exact same exception we got on the other end, in fact, I would argue that this should be the default behavior for our middleware.","commit_id":"44990f738165bfa22556d8b79fa3e405cb952f6c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c1e7ce29a37b0ac7056e519046a2d9270714330","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                                            sort_dirs\u003dsort_dirs)"},{"line_number":49,"context_line":"    except messaging.RemoteError as err:"},{"line_number":50,"context_line":"        if err.exc_type \u003d\u003d \"InvalidInput\":"},{"line_number":51,"context_line":"            raise exception.InvalidInput(err.value)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    resource_count \u003d len(resources)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_a649eed2","line":51,"updated":"2017-02-03 11:18:39.000000000","message":"-1: I meant no need to write the \u0027else\u0027 word, but the raise was still required, since the previous statement would prevent code from continuing (that\u0027s why the comment was right below the else and not below the raise), so this should be:\n\n        if err.exc_type \u003d\u003d \"InvalidInput\":\n            raise exception.InvalidInput(err.value)\n        raise","commit_id":"4d5f6e436f9a50965eb56eed9af85262e79a5d19"}],"cinder/tests/unit/api/contrib/test_snapshot_manage.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"26a9ccffa1b882db922795b45689f6684b7c42c6","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                    exc_type\u003d\u0027InvalidInput\u0027, value\u003d\u0027marker not found: 1234\u0027))"},{"line_number":265,"context_line":"    def test_get_manageable_snapshots_non_existent_marker("},{"line_number":266,"context_line":"            self, mock_api_manageable):"},{"line_number":267,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027, False, True)"},{"line_number":268,"context_line":"        self.assertEqual(400, res.status_int)"},{"line_number":269,"context_line":"        mock_api_manageable.assert_called_once_with("},{"line_number":270,"context_line":"            self._admin_ctxt, \u0027fakehost\u0027, None, limit\u003d10, marker\u003d\u00271234\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_cf246162","line":267,"range":{"start_line":267,"start_character":45,"end_line":267,"end_character":56},"updated":"2017-02-01 13:09:19.000000000","message":"nit: It would be better to pass these as keyword parameters","commit_id":"44990f738165bfa22556d8b79fa3e405cb952f6c"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"ed1c7896c9fc60052ca7a2552603d81671dc7f7f","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                    exc_type\u003d\u0027InvalidInput\u0027, value\u003d\u0027marker not found: 1234\u0027))"},{"line_number":265,"context_line":"    def test_get_manageable_snapshots_non_existent_marker("},{"line_number":266,"context_line":"            self, mock_api_manageable):"},{"line_number":267,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027, False, True)"},{"line_number":268,"context_line":"        self.assertEqual(400, res.status_int)"},{"line_number":269,"context_line":"        mock_api_manageable.assert_called_once_with("},{"line_number":270,"context_line":"            self._admin_ctxt, \u0027fakehost\u0027, None, limit\u003d10, marker\u003d\u00271234\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_8a7ebeac","line":267,"range":{"start_line":267,"start_character":45,"end_line":267,"end_character":56},"in_reply_to":"3a461143_cf246162","updated":"2017-02-03 06:15:18.000000000","message":"Done","commit_id":"44990f738165bfa22556d8b79fa3e405cb952f6c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"26a9ccffa1b882db922795b45689f6684b7c42c6","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            self, mock_api_manageable):"},{"line_number":267,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027, False, True)"},{"line_number":268,"context_line":"        self.assertEqual(400, res.status_int)"},{"line_number":269,"context_line":"        mock_api_manageable.assert_called_once_with("},{"line_number":270,"context_line":"            self._admin_ctxt, \u0027fakehost\u0027, None, limit\u003d10, marker\u003d\u00271234\u0027,"},{"line_number":271,"context_line":"            offset\u003d4, sort_dirs\u003d[\u0027asc\u0027], sort_keys\u003d[\u0027reference\u0027])"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_4fe6b145","line":269,"updated":"2017-02-01 13:09:19.000000000","message":"nit: Since we don\u0027t really care about the values we are passing we can just check:\n\n self.assertTrue(mock_api_manageable.called)","commit_id":"44990f738165bfa22556d8b79fa3e405cb952f6c"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"ed1c7896c9fc60052ca7a2552603d81671dc7f7f","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            self, mock_api_manageable):"},{"line_number":267,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027, False, True)"},{"line_number":268,"context_line":"        self.assertEqual(400, res.status_int)"},{"line_number":269,"context_line":"        mock_api_manageable.assert_called_once_with("},{"line_number":270,"context_line":"            self._admin_ctxt, \u0027fakehost\u0027, None, limit\u003d10, marker\u003d\u00271234\u0027,"},{"line_number":271,"context_line":"            offset\u003d4, sort_dirs\u003d[\u0027asc\u0027], sort_keys\u003d[\u0027reference\u0027])"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_aa49ba90","line":269,"in_reply_to":"3a461143_4fe6b145","updated":"2017-02-03 06:15:18.000000000","message":"Done","commit_id":"44990f738165bfa22556d8b79fa3e405cb952f6c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"26a9ccffa1b882db922795b45689f6684b7c42c6","unresolved":false,"context_lines":[{"line_number":297,"context_line":"                    exc_type\u003d\u0027InvalidInput\u0027, value\u003d\u0027marker not found: 1234\u0027))"},{"line_number":298,"context_line":"    def test_get_manageable_snapshots_non_existent_marker_detailed("},{"line_number":299,"context_line":"            self, mock_api_manageable):"},{"line_number":300,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027, True, True)"},{"line_number":301,"context_line":"        self.assertEqual(400, res.status_int)"},{"line_number":302,"context_line":"        mock_api_manageable.assert_called_once_with("},{"line_number":303,"context_line":"            self._admin_ctxt, \u0027fakehost\u0027, None, limit\u003d10,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_4f195122","line":300,"range":{"start_line":300,"start_character":45,"end_line":300,"end_character":55},"updated":"2017-02-01 13:09:19.000000000","message":"nit: It would be better to pass these as keyword parameters","commit_id":"44990f738165bfa22556d8b79fa3e405cb952f6c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"26a9ccffa1b882db922795b45689f6684b7c42c6","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            self, mock_api_manageable):"},{"line_number":300,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027, True, True)"},{"line_number":301,"context_line":"        self.assertEqual(400, res.status_int)"},{"line_number":302,"context_line":"        mock_api_manageable.assert_called_once_with("},{"line_number":303,"context_line":"            self._admin_ctxt, \u0027fakehost\u0027, None, limit\u003d10,"},{"line_number":304,"context_line":"            marker\u003d\u00271234\u0027, offset\u003d4, sort_dirs\u003d[\u0027asc\u0027],"},{"line_number":305,"context_line":"            sort_keys\u003d[\u0027reference\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_6fe36d34","line":302,"updated":"2017-02-01 13:09:19.000000000","message":"ditto","commit_id":"44990f738165bfa22556d8b79fa3e405cb952f6c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c1e7ce29a37b0ac7056e519046a2d9270714330","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027, admin\u003dFalse)"},{"line_number":236,"context_line":"        self.assertEqual(403, res.status_int)"},{"line_number":237,"context_line":"        self.assertEqual(False, mock_api_manageable.called)"},{"line_number":238,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027, detailed\u003dTrue, admin\u003dFalse)"},{"line_number":239,"context_line":"        self.assertEqual(403, res.status_int)"},{"line_number":240,"context_line":"        self.assertEqual(False, mock_api_manageable.called)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_269fbe04","line":238,"updated":"2017-02-03 11:18:39.000000000","message":"nit: Not a good idea to touch unrelated parts of the code even if it\u0027s improving readability.","commit_id":"4d5f6e436f9a50965eb56eed9af85262e79a5d19"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c1e7ce29a37b0ac7056e519046a2d9270714330","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    @mock.patch(\u0027cinder.volume.api.API.get_manageable_snapshots\u0027,"},{"line_number":243,"context_line":"                wraps\u003dapi_get_manageable_snapshots)"},{"line_number":244,"context_line":"    def test_get_manageable_snapshots_ok(self, mock_api_manageable):"},{"line_number":245,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027)"},{"line_number":246,"context_line":"        snap_name \u003d \u0027snapshot-ffffffff-0000-ffff-0000-ffffffffffff\u0027"},{"line_number":247,"context_line":"        exp \u003d {\u0027manageable-snapshots\u0027:"},{"line_number":248,"context_line":"               [{\u0027reference\u0027: {\u0027source-name\u0027: snap_name}, \u0027size\u0027: 4,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_6689c6ca","line":245,"updated":"2017-02-03 11:18:39.000000000","message":"nit: Not a good idea to touch unrelated parts of the code even if it\u0027s improving readability.","commit_id":"4d5f6e436f9a50965eb56eed9af85262e79a5d19"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c1e7ce29a37b0ac7056e519046a2d9270714330","unresolved":false,"context_lines":[{"line_number":271,"context_line":"    @mock.patch(\u0027cinder.volume.api.API.get_manageable_snapshots\u0027,"},{"line_number":272,"context_line":"                wraps\u003dapi_get_manageable_snapshots)"},{"line_number":273,"context_line":"    def test_get_manageable_snapshots_detailed_ok(self, mock_api_manageable):"},{"line_number":274,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027, detailed\u003dTrue, paging\u003dTrue)"},{"line_number":275,"context_line":"        snap_id \u003d \u0027ffffffff-0000-ffff-0000-ffffffffffff\u0027"},{"line_number":276,"context_line":"        exp \u003d {\u0027manageable-snapshots\u0027:"},{"line_number":277,"context_line":"               [{\u0027reference\u0027: {\u0027source-name\u0027: \u0027snapshot-%s\u0027 % snap_id},"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_46bbea72","line":274,"updated":"2017-02-03 11:18:39.000000000","message":"nit: Not a good idea to touch unrelated parts of the code even if it\u0027s improving readability.","commit_id":"4d5f6e436f9a50965eb56eed9af85262e79a5d19"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c1e7ce29a37b0ac7056e519046a2d9270714330","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    def test_get_manageable_snapshots_disabled(self, mock_db, mock_is_up):"},{"line_number":305,"context_line":"        mock_db.return_value \u003d fake_service.fake_service_obj(self._admin_ctxt,"},{"line_number":306,"context_line":"                                                             disabled\u003dTrue)"},{"line_number":307,"context_line":"        res \u003d self._get_resp_get(\u0027host_ok\u0027, paging\u003dTrue)"},{"line_number":308,"context_line":"        self.assertEqual(400, res.status_int, res)"},{"line_number":309,"context_line":"        self.assertEqual(exception.ServiceUnavailable.message,"},{"line_number":310,"context_line":"                         res.json[\u0027badRequest\u0027][\u0027message\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_06cc8234","line":307,"updated":"2017-02-03 11:18:39.000000000","message":"nit: Not a good idea to touch unrelated parts of the code even if it\u0027s improving readability.","commit_id":"4d5f6e436f9a50965eb56eed9af85262e79a5d19"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c1e7ce29a37b0ac7056e519046a2d9270714330","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    @mock.patch(\u0027cinder.db.sqlalchemy.api.service_get\u0027)"},{"line_number":316,"context_line":"    def test_get_manageable_snapshots_is_down(self, mock_db, mock_is_up):"},{"line_number":317,"context_line":"        mock_db.return_value \u003d fake_service.fake_service_obj(self._admin_ctxt)"},{"line_number":318,"context_line":"        res \u003d self._get_resp_get(\u0027host_ok\u0027, paging\u003dTrue)"},{"line_number":319,"context_line":"        self.assertEqual(400, res.status_int, res)"},{"line_number":320,"context_line":"        self.assertEqual(exception.ServiceUnavailable.message,"},{"line_number":321,"context_line":"                         res.json[\u0027badRequest\u0027][\u0027message\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_26d17ece","line":318,"updated":"2017-02-03 11:18:39.000000000","message":"nit: Not a good idea to touch unrelated parts of the code even if it\u0027s improving readability.","commit_id":"4d5f6e436f9a50965eb56eed9af85262e79a5d19"}],"cinder/tests/unit/api/contrib/test_volume_manage.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"26a9ccffa1b882db922795b45689f6684b7c42c6","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                    exc_type\u003d\u0027InvalidInput\u0027, value\u003d\u0027marker not found: 1234\u0027))"},{"line_number":421,"context_line":"    def test_get_manageable_volumes_non_existent_marker(self,"},{"line_number":422,"context_line":"                                                        mock_api_manageable):"},{"line_number":423,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027, False, True)"},{"line_number":424,"context_line":"        self.assertEqual(400, res.status_int)"},{"line_number":425,"context_line":"        mock_api_manageable.assert_called_once_with("},{"line_number":426,"context_line":"            self._admin_ctxt, \u0027fakehost\u0027, None, limit\u003d10, marker\u003d\u00271234\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_8fb899ea","line":423,"updated":"2017-02-01 13:09:19.000000000","message":"Sam comments apply to these tests as in the previous file","commit_id":"44990f738165bfa22556d8b79fa3e405cb952f6c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c1e7ce29a37b0ac7056e519046a2d9270714330","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027, admin\u003dFalse)"},{"line_number":395,"context_line":"        self.assertEqual(403, res.status_int)"},{"line_number":396,"context_line":"        mock_api_manageable.assert_not_called()"},{"line_number":397,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027, paging\u003dFalse, admin\u003dFalse)"},{"line_number":398,"context_line":"        self.assertEqual(403, res.status_int)"},{"line_number":399,"context_line":"        mock_api_manageable.assert_not_called()"},{"line_number":400,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_e694d6e9","line":397,"updated":"2017-02-03 11:18:39.000000000","message":"nit: Not a good idea to touch unrelated parts of the code even if it\u0027s improving readability.","commit_id":"4d5f6e436f9a50965eb56eed9af85262e79a5d19"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c1e7ce29a37b0ac7056e519046a2d9270714330","unresolved":false,"context_lines":[{"line_number":401,"context_line":"    @mock.patch(\u0027cinder.volume.api.API.get_manageable_volumes\u0027,"},{"line_number":402,"context_line":"                wraps\u003dapi_get_manageable_volumes)"},{"line_number":403,"context_line":"    def test_get_manageable_volumes_ok(self, mock_api_manageable):"},{"line_number":404,"context_line":"        res \u003d self._get_resp_get(\u0027fakehost\u0027, paging\u003dTrue)"},{"line_number":405,"context_line":"        exp \u003d {\u0027manageable-volumes\u0027:"},{"line_number":406,"context_line":"               [{\u0027reference\u0027:"},{"line_number":407,"context_line":"                 {\u0027source-name\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_069ac214","line":404,"updated":"2017-02-03 11:18:39.000000000","message":"nit: Not a good idea to touch unrelated parts of the code even if it\u0027s improving readability.","commit_id":"4d5f6e436f9a50965eb56eed9af85262e79a5d19"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c1e7ce29a37b0ac7056e519046a2d9270714330","unresolved":false,"context_lines":[{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    @mock.patch(\u0027cinder.objects.service.Service.is_up\u0027, return_value\u003dTrue,"},{"line_number":467,"context_line":"                new_callable\u003dmock.PropertyMock)"},{"line_number":468,"context_line":"    def test_get_manageable_volumes_disabled(self, mock_is_up):"},{"line_number":469,"context_line":"        res \u003d self._get_resp_get(\u0027host_disabled\u0027, paging\u003dTrue)"},{"line_number":470,"context_line":"        self.assertEqual(400, res.status_int, res)"},{"line_number":471,"context_line":"        self.assertEqual(exception.ServiceUnavailable.message,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_e6edb68f","line":468,"updated":"2017-02-03 11:18:39.000000000","message":"nit: Not a good idea to touch unrelated parts of the code even if it\u0027s improving readability.","commit_id":"4d5f6e436f9a50965eb56eed9af85262e79a5d19"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4c1e7ce29a37b0ac7056e519046a2d9270714330","unresolved":false,"context_lines":[{"line_number":475,"context_line":"    @mock.patch(\u0027cinder.objects.service.Service.is_up\u0027, return_value\u003dFalse,"},{"line_number":476,"context_line":"                new_callable\u003dmock.PropertyMock)"},{"line_number":477,"context_line":"    def test_get_manageable_volumes_is_down(self, mock_is_up):"},{"line_number":478,"context_line":"        res \u003d self._get_resp_get(\u0027host_ok\u0027, paging\u003dTrue)"},{"line_number":479,"context_line":"        self.assertEqual(400, res.status_int, res)"},{"line_number":480,"context_line":"        self.assertEqual(exception.ServiceUnavailable.message,"},{"line_number":481,"context_line":"                         res.json[\u0027badRequest\u0027][\u0027message\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a430d35_26e89e7c","line":478,"updated":"2017-02-03 11:18:39.000000000","message":"nit: Not a good idea to touch unrelated parts of the code even if it\u0027s improving readability.","commit_id":"4d5f6e436f9a50965eb56eed9af85262e79a5d19"}]}