)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9a0cbaa462193646e55d4570d03f4a2d3f9ecbef","unresolved":false,"context_lines":[{"line_number":13,"context_line":"fixes this up by making the call seek for available services using both"},{"line_number":14,"context_line":"host and cluster_name properties."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Although it\u0027s an API change, it doesn\u0027t need a new microversion, because"},{"line_number":17,"context_line":"it falls under \"Did we silently fail to do what is asked?\" category."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: If7bca131c84fc997da8ad277eccd134e8ca4b316"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_b1e744ab","line":16,"updated":"2017-02-02 15:58:53.000000000","message":"Agree","commit_id":"7401d0d098348d2a14eb4ed2473f0dc47cae0275"}],"cinder/api/contrib/capabilities.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e815c1746bf8ad19fa7af66e03edfd4136f3a98f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            msg \u003d (_(\"Can\u0027t find service: %s\") % id)"},{"line_number":51,"context_line":"            raise exception.NotFound(msg)"},{"line_number":52,"context_line":"        try:"},{"line_number":53,"context_line":"            capabilities \u003d self.volume_api.get_capabilities(context, id, False)"},{"line_number":54,"context_line":"        except oslo_messaging.MessagingTimeout:"},{"line_number":55,"context_line":"            raise exception.RPCTimeout(service\u003did)"},{"line_number":56,"context_line":"        return self._view_builder.summary(req, capabilities, id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_a42ab62a","line":53,"range":{"start_line":53,"start_character":69,"end_line":53,"end_character":71},"updated":"2017-02-02 09:01:16.000000000","message":"-1: We should send it to the cluster if there is one, even if it was asked by host:\n\n capabilities \u003d self.volume_api.get_capabilities(context, services[0].service_topic_queue, False)\n\nAnd the same should be done in the exception and the build summary in my opinion.","commit_id":"947c947e2f2f7bf9680681f370bea5749b109767"}],"cinder/tests/unit/api/contrib/test_capabilities.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1e0b148f361ed5e2c4d2448502ecd7b9ea73ba7d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    @mock.patch(\u0027cinder.volume.rpcapi.VolumeAPI.get_capabilities\u0027,"},{"line_number":71,"context_line":"                rpcapi_get_capabilities)"},{"line_number":72,"context_line":"    def test_capabilities_summary(self, mock_services):"},{"line_number":73,"context_line":"        mock_services.return_value \u003d [{\u0027name\u0027: \u0027fake\u0027, \u0027host\u0027: \u0027fake_host\u0027}]"},{"line_number":74,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/fake/capabilities/fake\u0027)"},{"line_number":75,"context_line":"        req.environ[\u0027cinder.context\u0027] \u003d self.ctxt"},{"line_number":76,"context_line":"        res \u003d self.controller.show(req, \u0027fake\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_6b3a56e9","line":73,"updated":"2017-02-02 12:46:04.000000000","message":"nit: it may be good to have a case with a cluster to see that even when requested by host we get the cluster in the namespace.","commit_id":"7401d0d098348d2a14eb4ed2473f0dc47cae0275"}]}
