)]}'
{"cinder/volume/drivers/quobyte.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"1c0c1df3b3e98d1b034e3a9796b3332f23231a00","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            self._validate_volume(mount_path)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def _validate_volume(self, mount_path):"},{"line_number":471,"context_line":"        \"\"\"Runs a number of tests on the expect Quobyte mount\"\"\""},{"line_number":472,"context_line":"        with open(self.MTAB_LOCATION) as mtab:"},{"line_number":473,"context_line":"            for line in mtab:"},{"line_number":474,"context_line":"                if re.search(mount_path, line):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a430d35_d5ff7032","line":471,"updated":"2017-02-03 17:56:49.000000000","message":"this seems a bit dangerous to allow a driver to read directly from files in /etc","commit_id":"db1ed9312e2be4e19328d65cb731570682ec207c"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"4f78a02cc16a9f8ac3deca82c9a6001ffa76d14d","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            self._validate_volume(mount_path)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def _validate_volume(self, mount_path):"},{"line_number":471,"context_line":"        \"\"\"Runs a number of tests on the expect Quobyte mount\"\"\""},{"line_number":472,"context_line":"        with open(self.MTAB_LOCATION) as mtab:"},{"line_number":473,"context_line":"            for line in mtab:"},{"line_number":474,"context_line":"                if re.search(mount_path, line):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a430d35_3d4cb29d","line":471,"in_reply_to":"1a430d35_d5ff7032","updated":"2017-02-07 10:28:27.000000000","message":"I switched the implementation to reading available entries via psutil.disk_partitions, so no more reading in /etc/ ...","commit_id":"db1ed9312e2be4e19328d65cb731570682ec207c"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"1450d25670ac22aa4d199cafe81bfb82f38ffc3d","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            self._validate_volume(mount_path)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def _validate_volume(self, mount_path):"},{"line_number":471,"context_line":"        \"\"\"Runs a number of tests on the expect Quobyte mount\"\"\""},{"line_number":472,"context_line":"        with open(self.MTAB_LOCATION) as mtab:"},{"line_number":473,"context_line":"            for line in mtab:"},{"line_number":474,"context_line":"                if re.search(mount_path, line):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a430d35_91f5cfcc","line":471,"in_reply_to":"1a430d35_d5ff7032","updated":"2017-02-06 08:23:06.000000000","message":"I thought about different options and saw:\n1) read from /etc/mtab\n2) read from /proc/self/mounts\n3) run \u0027mount\u0027 in the shell and parse output\n\nI\u0027d prefer to go without running a shell command. It seems to me /etc/mtab is more reliably present than /proc/self/mounts which is why I\u0027m going with this.\n\nWhich dangers do you see with /etc/mtab?","commit_id":"db1ed9312e2be4e19328d65cb731570682ec207c"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"6303a3def7d0516e82f03534a81daf59667298a6","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            self._validate_volume(mount_path)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def _validate_volume(self, mount_path):"},{"line_number":471,"context_line":"        \"\"\"Runs a number of tests on the expect Quobyte mount\"\"\""},{"line_number":472,"context_line":"        partitions \u003d psutil.disk_partitions(all\u003dTrue)"},{"line_number":473,"context_line":"        for p in partitions:"},{"line_number":474,"context_line":"            if mount_path \u003d\u003d p.mountpoint:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa31d9ce_c548a98d","line":471,"updated":"2017-02-16 13:03:50.000000000","message":"hmm, s/expect/expected . I\u0027ll update this should other needs for changes arise.","commit_id":"7585a09bdfd1f6197638928b46b377f13956bfda"}]}