)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"b4573e3d7eb11bb948dcb7a7b35bf83d74c683ee","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Xiv create vol from replicated source fails"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the ibm_storage driver failes to create a volume from a replicated"},{"line_number":10,"context_line":"source."},{"line_number":11,"context_line":"it firsts creates the volume, defines replication for it, and then"},{"line_number":12,"context_line":"tries to copy the source volume to the target volume."},{"line_number":13,"context_line":"This logic should be reveresed - after create, we should first copy"},{"line_number":14,"context_line":"source and then define replictaion."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ic6d093bfc3c03807211dd47c5eb4428127e28821"},{"line_number":17,"context_line":"closes-bug: 1661223"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_417d79e6","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":35},"updated":"2017-02-02 13:29:49.000000000","message":"edited:\nThe ibm_storage driver fails to clone a volume from a replicated\nsource. It creates the volume, defines replication for it, and when\nit tries to copy the contents of the source volume it fails.\nThe logic should be reversed - after create, we should copy\nthe contents of the source and then set the replication.","commit_id":"886009e72965e086fe6cd75d9096df2013bb1c76"},{"author":{"_account_id":17947,"name":"Tzur Eliyahu","email":"tzure@il.ibm.com","username":"TzurEliyahu"},"change_message_id":"35154dd6f0e42fdab7e39b6a9167baffb1dd75c2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Xiv create vol from replicated source fails"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the ibm_storage driver failes to create a volume from a replicated"},{"line_number":10,"context_line":"source."},{"line_number":11,"context_line":"it firsts creates the volume, defines replication for it, and then"},{"line_number":12,"context_line":"tries to copy the source volume to the target volume."},{"line_number":13,"context_line":"This logic should be reveresed - after create, we should first copy"},{"line_number":14,"context_line":"source and then define replictaion."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ic6d093bfc3c03807211dd47c5eb4428127e28821"},{"line_number":17,"context_line":"closes-bug: 1661223"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_1c2596ad","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":35},"in_reply_to":"3a461143_417d79e6","updated":"2017-02-02 15:15:46.000000000","message":"Done","commit_id":"886009e72965e086fe6cd75d9096df2013bb1c76"}],"cinder/tests/unit/volume/drivers/ibm/test_xiv_proxy.py":[{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"883da6c97bd1310a0a5c991b10eaa5d4eb7a80cd","unresolved":false,"context_lines":[{"line_number":1809,"context_line":"        ret_val \u003d p.handle_created_vol_properties("},{"line_number":1810,"context_line":"            None, {\u0027enabled\u0027: True}, {\u0027name\u0027: \u0027bla\u0027})"},{"line_number":1811,"context_line":""},{"line_number":1812,"context_line":"        self.assertEqual(ret_val, {\u0027replication_status\u0027: \u0027enabled\u0027})"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_4f866814","line":1812,"range":{"start_line":1812,"start_character":13,"end_line":1812,"end_character":24},"updated":"2017-02-06 03:31:45.000000000","message":"it may be better to use assertDictEqual.","commit_id":"0a47ab83b5a5c12b31cc5f426000a033788c872c"}],"cinder/volume/drivers/ibm/ibm_storage/xiv_proxy.py":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"b4573e3d7eb11bb948dcb7a7b35bf83d74c683ee","unresolved":false,"context_lines":[{"line_number":467,"context_line":"        return self.handle_vol_properties(cg, volume_update,"},{"line_number":468,"context_line":"                                          replication_info, volume)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def handle_vol_properties(self, cg, volume_update,"},{"line_number":471,"context_line":"                              replication_info, volume):"},{"line_number":472,"context_line":"        if cg:"},{"line_number":473,"context_line":"            volume_update[\u0027consistencygroup_id\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_e1a90526","line":470,"range":{"start_line":470,"start_character":40,"end_line":470,"end_character":53},"updated":"2017-02-02 13:29:49.000000000","message":"seems like volume_update is not required as parameter and should just be the return value","commit_id":"886009e72965e086fe6cd75d9096df2013bb1c76"},{"author":{"_account_id":17947,"name":"Tzur Eliyahu","email":"tzure@il.ibm.com","username":"TzurEliyahu"},"change_message_id":"35154dd6f0e42fdab7e39b6a9167baffb1dd75c2","unresolved":false,"context_lines":[{"line_number":467,"context_line":"        return self.handle_vol_properties(cg, volume_update,"},{"line_number":468,"context_line":"                                          replication_info, volume)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def handle_vol_properties(self, cg, volume_update,"},{"line_number":471,"context_line":"                              replication_info, volume):"},{"line_number":472,"context_line":"        if cg:"},{"line_number":473,"context_line":"            volume_update[\u0027consistencygroup_id\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_6269948b","line":470,"range":{"start_line":470,"start_character":40,"end_line":470,"end_character":53},"in_reply_to":"3a461143_e1a90526","updated":"2017-02-02 15:15:46.000000000","message":"Done","commit_id":"886009e72965e086fe6cd75d9096df2013bb1c76"}]}