)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"b422ea9e027f47d39fc9153c2138328e33f196b0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are a number of Pep8 checks that fail when testing using"},{"line_number":10,"context_line":"Python3.  This commit corrects those issues:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"-For test cases using the \u0027file\u0027 built-in a \u0027# noqa\u0027 was added"},{"line_number":13,"context_line":"-Add \u0027# noqa\u0027 for cases where the \u0027buffer\u0027 built-in was used"},{"line_number":14,"context_line":"-Use of \u0027unicode\u0027 was switched to \u0027six.text_type\u0027"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a430d35_71e115fe","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"updated":"2017-02-07 02:28:22.000000000","message":"blank space required before first word of list item.","commit_id":"238e526de15ead402b89d8253818a0c3199f3230"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"2322288dd3fb693fe2d9cb562312c70c0fc7ef28","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are a number of Pep8 checks that fail when testing using"},{"line_number":10,"context_line":"Python3.  This commit corrects those issues:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"-For test cases using the \u0027file\u0027 built-in a \u0027# noqa\u0027 was added"},{"line_number":13,"context_line":"-Add \u0027# noqa\u0027 for cases where the \u0027buffer\u0027 built-in was used"},{"line_number":14,"context_line":"-Use of \u0027unicode\u0027 was switched to \u0027six.text_type\u0027"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_7ca9ecde","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"in_reply_to":"1a430d35_71e115fe","updated":"2017-02-13 19:43:50.000000000","message":"Done","commit_id":"238e526de15ead402b89d8253818a0c3199f3230"}],"cinder/tests/unit/backup/drivers/test_backup_nfs.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"05b4d0698acca06beec6764ce5491dcaf37a307b","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        fake_data \u003d bytearray(size)"},{"line_number":672,"context_line":"        if six.PY2:"},{"line_number":673,"context_line":"            # On Python 2, zlib.compressor() accepts buffer, but not bytearray"},{"line_number":674,"context_line":"            fake_data \u003d buffer(fake_data)  # noqa"},{"line_number":675,"context_line":"        return fake_data"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def test_prepare_output_data_effective_compression(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_33d4fa1e","line":674,"range":{"start_line":674,"start_character":43,"end_line":674,"end_character":49},"updated":"2017-02-06 22:06:48.000000000","message":"If you are to put this, please add a comment in the line above explaining why and the special meaning of the # noqa comment. Otherwise people will just flush it out in the future.","commit_id":"238e526de15ead402b89d8253818a0c3199f3230"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"b422ea9e027f47d39fc9153c2138328e33f196b0","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        fake_data \u003d bytearray(size)"},{"line_number":672,"context_line":"        if six.PY2:"},{"line_number":673,"context_line":"            # On Python 2, zlib.compressor() accepts buffer, but not bytearray"},{"line_number":674,"context_line":"            fake_data \u003d buffer(fake_data)  # noqa"},{"line_number":675,"context_line":"        return fake_data"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def test_prepare_output_data_effective_compression(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_f1ed05f0","line":674,"range":{"start_line":674,"start_character":43,"end_line":674,"end_character":49},"in_reply_to":"1a430d35_33d4fa1e","updated":"2017-02-07 02:28:22.000000000","message":"+1, suggest add comments on why adding noqa for \u0027buffer\u0027.","commit_id":"238e526de15ead402b89d8253818a0c3199f3230"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"2322288dd3fb693fe2d9cb562312c70c0fc7ef28","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        fake_data \u003d bytearray(size)"},{"line_number":672,"context_line":"        if six.PY2:"},{"line_number":673,"context_line":"            # On Python 2, zlib.compressor() accepts buffer, but not bytearray"},{"line_number":674,"context_line":"            fake_data \u003d buffer(fake_data)  # noqa"},{"line_number":675,"context_line":"        return fake_data"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def test_prepare_output_data_effective_compression(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_39994620","line":674,"range":{"start_line":674,"start_character":43,"end_line":674,"end_character":49},"in_reply_to":"1a430d35_33d4fa1e","updated":"2017-02-13 19:43:50.000000000","message":"Done","commit_id":"238e526de15ead402b89d8253818a0c3199f3230"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"2322288dd3fb693fe2d9cb562312c70c0fc7ef28","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        fake_data \u003d bytearray(size)"},{"line_number":672,"context_line":"        if six.PY2:"},{"line_number":673,"context_line":"            # On Python 2, zlib.compressor() accepts buffer, but not bytearray"},{"line_number":674,"context_line":"            fake_data \u003d buffer(fake_data)  # noqa"},{"line_number":675,"context_line":"        return fake_data"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    def test_prepare_output_data_effective_compression(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_59a0ba43","line":674,"range":{"start_line":674,"start_character":43,"end_line":674,"end_character":49},"in_reply_to":"1a430d35_f1ed05f0","updated":"2017-02-13 19:43:50.000000000","message":"Done","commit_id":"238e526de15ead402b89d8253818a0c3199f3230"}],"cinder/volume/drivers/coprhd/helpers/commoncoprhdapi.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3c29171bea9a8bc693f71c9e786c60de8d3b25fa","unresolved":false,"context_lines":[{"line_number":49,"context_line":"def _decode_list(data):"},{"line_number":50,"context_line":"    rv \u003d []"},{"line_number":51,"context_line":"    for item in data:"},{"line_number":52,"context_line":"        if isinstance(item, six.text_type):"},{"line_number":53,"context_line":"            item \u003d item.encode(\u0027utf-8\u0027)"},{"line_number":54,"context_line":"        elif isinstance(item, list):"},{"line_number":55,"context_line":"            item \u003d _decode_list(item)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_bada81e6","line":52,"updated":"2017-02-13 19:52:37.000000000","message":"I\u0027m not sure this is correct -- it results in encode being called on text that is already encoded (ASCII) plain text, which is not what was done previously.","commit_id":"9517dd2592a9ee371540cd51a1001ddcf6bcc876"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"04aa714986e367f2873b107b42ea55a86e2e25b8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"def _decode_list(data):"},{"line_number":50,"context_line":"    rv \u003d []"},{"line_number":51,"context_line":"    for item in data:"},{"line_number":52,"context_line":"        if isinstance(item, six.text_type):"},{"line_number":53,"context_line":"            item \u003d item.encode(\u0027utf-8\u0027)"},{"line_number":54,"context_line":"        elif isinstance(item, list):"},{"line_number":55,"context_line":"            item \u003d _decode_list(item)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_e78ddcd3","line":52,"in_reply_to":"fa31d9ce_bada81e6","updated":"2017-02-15 17:02:40.000000000","message":"To document our IRC discussion I think this is ok.  For py2, six.text_type \u003d\u003d unicode.  For py3 it \u003d\u003d str().  encoding a str to utf-8 is valid.  So, I think this is ok.","commit_id":"9517dd2592a9ee371540cd51a1001ddcf6bcc876"}]}