)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ab04c51193bce992fb8bbe434203f5d9c7b1d0d0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alon Marx \u003calonma@il.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-09 22:02:26 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"create_consistencygroup in xiv stopped working"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"create_consistencygroup failed when extracting extra_specs. This was the"},{"line_number":10,"context_line":"result of ConsistencyGroup.volume_type_id having an extra comma at the end"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a430d35_3d48ad87","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":46},"updated":"2017-02-09 20:23:25.000000000","message":"This comma has always been there since CG was introduced.  I don\u0027t know how the driver could have worked before.  I suggest change the title to \"Fix create_consistencygroup in xiv\".","commit_id":"6a6d5ccd4e3d7dfc85751408136b8947b25fb692"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"3f62535247f57924c370e55a2009411a80964634","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alon Marx \u003calonma@il.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-09 22:02:26 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"create_consistencygroup in xiv stopped working"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"create_consistencygroup failed when extracting extra_specs. This was the"},{"line_number":10,"context_line":"result of ConsistencyGroup.volume_type_id having an extra comma at the end"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_6a5277df","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":46},"in_reply_to":"1a430d35_3d48ad87","updated":"2017-02-09 20:46:18.000000000","message":"I really have no idea, but we did test this lately and it worked. Anyway, fixed the title.","commit_id":"6a6d5ccd4e3d7dfc85751408136b8947b25fb692"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ab04c51193bce992fb8bbe434203f5d9c7b1d0d0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"create_consistencygroup in xiv stopped working"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"create_consistencygroup failed when extracting extra_specs. This was the"},{"line_number":10,"context_line":"result of ConsistencyGroup.volume_type_id having an extra comma at the end"},{"line_number":11,"context_line":"(e.g. u\u00272ec11e39-881a-4392-a0dd-2254ec4b39a0,\u0027)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I52dd2d8c55afccb6734742a7ca4fe916eba0142d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a430d35_5d5d7947","line":10,"updated":"2017-02-09 20:23:25.000000000","message":"Please wrap at 72 characters.","commit_id":"6a6d5ccd4e3d7dfc85751408136b8947b25fb692"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"3f62535247f57924c370e55a2009411a80964634","unresolved":false,"context_lines":[{"line_number":7,"context_line":"create_consistencygroup in xiv stopped working"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"create_consistencygroup failed when extracting extra_specs. This was the"},{"line_number":10,"context_line":"result of ConsistencyGroup.volume_type_id having an extra comma at the end"},{"line_number":11,"context_line":"(e.g. u\u00272ec11e39-881a-4392-a0dd-2254ec4b39a0,\u0027)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I52dd2d8c55afccb6734742a7ca4fe916eba0142d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_8a5debee","line":10,"in_reply_to":"1a430d35_5d5d7947","updated":"2017-02-09 20:46:18.000000000","message":"Done","commit_id":"6a6d5ccd4e3d7dfc85751408136b8947b25fb692"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7fd82bdd8b18ea7a176f686571ce2c8c8558da65","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix create_consistencygroup in xiv"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"create_consistencygroup failed when extracting extra_specs. This is the"},{"line_number":10,"context_line":"due to ConsistencyGroup.volume_type_id having an extra comma at the"},{"line_number":11,"context_line":"end (e.g. u\u00272ec11e39-881a-4392-a0dd-2254ec4b39a0,\u0027)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa31d9ce_cd561d06","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":71},"updated":"2017-02-09 20:54:25.000000000","message":"don\u0027t need \u0027the\u0027 here.  Not going to hold up the review for it though.","commit_id":"93aa9acfed3e730b7d521df9c0d2d36626136be8"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"13ee4a6e7ee35fbfcd8c83c1a7179f0ffdbec99a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix create_consistencygroup in xiv"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"create_consistencygroup failed when extracting extra_specs. This is the"},{"line_number":10,"context_line":"due to ConsistencyGroup.volume_type_id having an extra comma at the"},{"line_number":11,"context_line":"end (e.g. u\u00272ec11e39-881a-4392-a0dd-2254ec4b39a0,\u0027)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa31d9ce_6dee11ee","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":71},"in_reply_to":"fa31d9ce_cd561d06","updated":"2017-02-09 21:07:04.000000000","message":"will remove it if another fix is needed","commit_id":"93aa9acfed3e730b7d521df9c0d2d36626136be8"}],"cinder/tests/unit/volume/drivers/ibm/test_xiv_proxy.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7fd82bdd8b18ea7a176f686571ce2c8c8558da65","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    \"\"\"Tests the main Proxy driver\"\"\""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    test_cg \u003d consistencygroup.ConsistencyGroup("},{"line_number":138,"context_line":"        context\u003dNone, name\u003d\u0027WTF32\u0027, id\u003d\u0027WTF32\u0027, volume_type_id\u003d\u0027WTF32,\u0027,"},{"line_number":139,"context_line":"        status\u003dfields.ConsistencyGroupStatus.AVAILABLE)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_cd1ffd59","line":138,"range":{"start_line":138,"start_character":28,"end_line":138,"end_character":33},"updated":"2017-02-09 20:54:25.000000000","message":"Nice. :-)","commit_id":"93aa9acfed3e730b7d521df9c0d2d36626136be8"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"2dec07dd0e68620696d7183fcbf6ef5506a5993a","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    \"\"\"Tests the main Proxy driver\"\"\""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    test_cg \u003d consistencygroup.ConsistencyGroup("},{"line_number":138,"context_line":"        context\u003dNone, name\u003d\u0027WTF32\u0027, id\u003d\u0027WTF32\u0027, volume_type_id\u003d\u0027WTF32,\u0027,"},{"line_number":139,"context_line":"        status\u003dfields.ConsistencyGroupStatus.AVAILABLE)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_35827e53","line":138,"range":{"start_line":138,"start_character":28,"end_line":138,"end_character":33},"in_reply_to":"fa31d9ce_36137d5e","updated":"2017-02-10 14:08:18.000000000","message":"Fixed. It would be good to change other constants to use these fakes, but better do it in a separate review.","commit_id":"93aa9acfed3e730b7d521df9c0d2d36626136be8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"a0998fc0b7d0277ae9a8838e67453ba81b1b8678","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    \"\"\"Tests the main Proxy driver\"\"\""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    test_cg \u003d consistencygroup.ConsistencyGroup("},{"line_number":138,"context_line":"        context\u003dNone, name\u003d\u0027WTF32\u0027, id\u003d\u0027WTF32\u0027, volume_type_id\u003d\u0027WTF32,\u0027,"},{"line_number":139,"context_line":"        status\u003dfields.ConsistencyGroupStatus.AVAILABLE)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_36137d5e","line":138,"range":{"start_line":138,"start_character":28,"end_line":138,"end_character":33},"in_reply_to":"fa31d9ce_cd1ffd59","updated":"2017-02-10 05:45:57.000000000","message":"id and volume_type_id should use real UUIDs, otherwise there will be warnings.  You can use UUIDs from the following file:\n\nhttps://github.com/openstack/cinder/blob/master/cinder/tests/unit/fake_constants.py","commit_id":"93aa9acfed3e730b7d521df9c0d2d36626136be8"}],"cinder/volume/drivers/ibm/ibm_storage/xiv_proxy.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"3b67f038bb926249d7f43a1e2f2bf0a3dd6f2a77","unresolved":false,"context_lines":[{"line_number":1651,"context_line":"                   {\u0027group\u0027: cgname})"},{"line_number":1652,"context_line":"            LOG.error(msg)"},{"line_number":1653,"context_line":"            raise self.meta[\u0027exception\u0027].VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1654,"context_line":"        LOG.debug(\"volume_type_ids: %s\" % volume_type_ids)"},{"line_number":1655,"context_line":"        for volume_type_id in volume_type_ids:"},{"line_number":1656,"context_line":"            specs \u003d self._get_extra_specs(volume_type_id)"},{"line_number":1657,"context_line":"            replication_info \u003d self._get_replication_info(specs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_4ab9332e","line":1654,"range":{"start_line":1654,"start_character":39,"end_line":1654,"end_character":42},"updated":"2017-02-09 20:25:49.000000000","message":"Should use \u0027,\u0027 here.","commit_id":"6a6d5ccd4e3d7dfc85751408136b8947b25fb692"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b53956e4fb66884eab7cc56562a107a498c11f93","unresolved":false,"context_lines":[{"line_number":1651,"context_line":"                   {\u0027group\u0027: cgname})"},{"line_number":1652,"context_line":"            LOG.error(msg)"},{"line_number":1653,"context_line":"            raise self.meta[\u0027exception\u0027].VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1654,"context_line":"        LOG.debug(\"volume_type_ids: %s\" % volume_type_ids)"},{"line_number":1655,"context_line":"        for volume_type_id in volume_type_ids:"},{"line_number":1656,"context_line":"            specs \u003d self._get_extra_specs(volume_type_id)"},{"line_number":1657,"context_line":"            replication_info \u003d self._get_replication_info(specs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_6ae277a1","line":1654,"range":{"start_line":1654,"start_character":39,"end_line":1654,"end_character":42},"in_reply_to":"fa31d9ce_4ab9332e","updated":"2017-02-09 20:44:38.000000000","message":"+1","commit_id":"6a6d5ccd4e3d7dfc85751408136b8947b25fb692"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"3f62535247f57924c370e55a2009411a80964634","unresolved":false,"context_lines":[{"line_number":1651,"context_line":"                   {\u0027group\u0027: cgname})"},{"line_number":1652,"context_line":"            LOG.error(msg)"},{"line_number":1653,"context_line":"            raise self.meta[\u0027exception\u0027].VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1654,"context_line":"        LOG.debug(\"volume_type_ids: %s\" % volume_type_ids)"},{"line_number":1655,"context_line":"        for volume_type_id in volume_type_ids:"},{"line_number":1656,"context_line":"            specs \u003d self._get_extra_specs(volume_type_id)"},{"line_number":1657,"context_line":"            replication_info \u003d self._get_replication_info(specs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_0af9fbc8","line":1654,"range":{"start_line":1654,"start_character":39,"end_line":1654,"end_character":42},"in_reply_to":"fa31d9ce_4ab9332e","updated":"2017-02-09 20:46:18.000000000","message":"Done","commit_id":"6a6d5ccd4e3d7dfc85751408136b8947b25fb692"}]}