)]}'
{"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":10221,"name":"Edward Balduf","email":"ed.balduf@solidfire.com","username":"ebalduf"},"change_message_id":"9395eeac989bd9d4ca830dadeb559eab5a92c464","unresolved":false,"context_lines":[{"line_number":909,"context_line":"                LOG.debug(\u0027Removing SolidFire Cache Volume (SF ID): %s\u0027,"},{"line_number":910,"context_line":"                          vol[\u0027volumeID\u0027])"},{"line_number":911,"context_line":"                self._detach_volume(context, attach_info, tvol, properties)"},{"line_number":912,"context_line":"                self._issue_api_request(\u0027DeleteVolume\u0027, params)"},{"line_number":913,"context_line":"                return"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        self._detach_volume(context, attach_info, tvol, properties)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_a588e3e8","line":912,"range":{"start_line":912,"start_character":16,"end_line":912,"end_character":63},"updated":"2017-02-11 02:42:26.000000000","message":"While we are fixing this, lets put an API call to PurgeDeletedVolume here after the DeleteVolume request just to be safe. Just add a line self._issue_api_request(\u0027PurgeDeletedVolume\u0027, params)","commit_id":"f23186e61303ad43fb1425a24663a7e4298140a9"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"7b154d83f5655fb624d3754814c0e1c1f54a19cb","unresolved":false,"context_lines":[{"line_number":909,"context_line":"                LOG.debug(\u0027Removing SolidFire Cache Volume (SF ID): %s\u0027,"},{"line_number":910,"context_line":"                          vol[\u0027volumeID\u0027])"},{"line_number":911,"context_line":"                self._detach_volume(context, attach_info, tvol, properties)"},{"line_number":912,"context_line":"                self._issue_api_request(\u0027DeleteVolume\u0027, params)"},{"line_number":913,"context_line":"                return"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        self._detach_volume(context, attach_info, tvol, properties)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_f960c037","line":912,"range":{"start_line":912,"start_character":16,"end_line":912,"end_character":63},"in_reply_to":"fa31d9ce_a588e3e8","updated":"2017-02-11 23:20:15.000000000","message":"+1","commit_id":"f23186e61303ad43fb1425a24663a7e4298140a9"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"e172833b7518d78c636e3b9ca2a3dc70af9a50aa","unresolved":false,"context_lines":[{"line_number":909,"context_line":"                LOG.debug(\u0027Removing SolidFire Cache Volume (SF ID): %s\u0027,"},{"line_number":910,"context_line":"                          vol[\u0027volumeID\u0027])"},{"line_number":911,"context_line":"                self._detach_volume(context, attach_info, tvol, properties)"},{"line_number":912,"context_line":"                self._issue_api_request(\u0027DeleteVolume\u0027, params)"},{"line_number":913,"context_line":"                return"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        self._detach_volume(context, attach_info, tvol, properties)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_f29b4370","line":912,"range":{"start_line":912,"start_character":16,"end_line":912,"end_character":63},"in_reply_to":"fa31d9ce_a588e3e8","updated":"2017-02-13 18:37:23.000000000","message":"Sounds good. Curious though, I thought deleted volume shouldn\u0027t be cloned or snapshot, even hasn\u0027t been purged, maybe I was wrong?","commit_id":"f23186e61303ad43fb1425a24663a7e4298140a9"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"7dad713f995131ed53dbf2333930e21614b65efc","unresolved":false,"context_lines":[{"line_number":909,"context_line":"                LOG.debug(\u0027Removing SolidFire Cache Volume (SF ID): %s\u0027,"},{"line_number":910,"context_line":"                          vol[\u0027volumeID\u0027])"},{"line_number":911,"context_line":"                self._detach_volume(context, attach_info, tvol, properties)"},{"line_number":912,"context_line":"                self._issue_api_request(\u0027DeleteVolume\u0027, params)"},{"line_number":913,"context_line":"                return"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        self._detach_volume(context, attach_info, tvol, properties)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_b2ac6b36","line":912,"range":{"start_line":912,"start_character":16,"end_line":912,"end_character":63},"in_reply_to":"fa31d9ce_f29b4370","updated":"2017-02-13 18:42:29.000000000","message":"Nahh, you\u0027re correct; the purge is something we\u0027ve added though because there are some issues / corner cases where we get duplicate volumes found on searches.  It\u0027s pretty limited at this point, but the best way to fix it is to just purge.  This also addresses some things with GC that we\u0027ve seen in the past impacting some calls to the backend.","commit_id":"f23186e61303ad43fb1425a24663a7e4298140a9"}]}