)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"772f8cc10f4f955bcbff3c5aec923760f3da9935","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Zadara driver - move from httplib to requests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Move from httplib to requests"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8c1659132f79f9affbf5e6eb5129f3e23ee63cb1"},{"line_number":12,"context_line":"Closes-Bug: 1658770"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da36d5c6_756173d3","line":10,"updated":"2017-02-27 16:40:41.000000000","message":"I think this needs a doc impact tag? Since you are adding a new config option?","commit_id":"e8f2a8d6feffb8e3973320f3dc8b4e38a24ab2a6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ecd5535dfc92c92cc03d9dd147d83928216fbd35","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Zadara driver - move from httplib to requests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Move from httplib to requests"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8c1659132f79f9affbf5e6eb5129f3e23ee63cb1"},{"line_number":12,"context_line":"Closes-Bug: 1658770"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da36d5c6_95ffc7a9","line":10,"in_reply_to":"da36d5c6_756173d3","updated":"2017-02-27 16:45:12.000000000","message":"Only if a bug needs to be created to track changes to openstack-manuals for this. If it\u0027s just an update of the config option table for Zadara, that is generated automatically.","commit_id":"e8f2a8d6feffb8e3973320f3dc8b4e38a24ab2a6"}],"cinder/volume/drivers/zadara.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f5179d3b7c76474abad083aeabea58764a3b7545","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                help\u003d\u0027VPSA - Use SSL connection\u0027),"},{"line_number":46,"context_line":"    cfg.BoolOpt(\u0027zadara_insecure_ssl\u0027,"},{"line_number":47,"context_line":"                default\u003dFalse,"},{"line_number":48,"context_line":"                help\u003d\u0027Do not validate The VPSA SSL certificate\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027zadara_capath\u0027,"},{"line_number":50,"context_line":"               default\u003dNone,"},{"line_number":51,"context_line":"               help\u003d\u0027User defined CA path\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_4b9f03b4","line":48,"updated":"2017-02-13 15:53:17.000000000","message":"We should name this zadara_ssl_cert_verify to match the already existing driver_ssl_cert_verify option.  (Note that this has the opposite behavior for True/False compared to the propsed option here.)\n\nIt would be nice to not have to add an option for this driver, but it makes sense because this driver is defaulting to secure mode.","commit_id":"9a4d0435f96a3b6feee7753d7701b95cff5575a5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f5179d3b7c76474abad083aeabea58764a3b7545","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                help\u003d\u0027Do not validate The VPSA SSL certificate\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027zadara_capath\u0027,"},{"line_number":50,"context_line":"               default\u003dNone,"},{"line_number":51,"context_line":"               help\u003d\u0027User defined CA path\u0027),"},{"line_number":52,"context_line":"    cfg.StrOpt(\u0027zadara_user\u0027,"},{"line_number":53,"context_line":"               default\u003dNone,"},{"line_number":54,"context_line":"               help\u003d\u0027VPSA - Username\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_abb07f44","line":51,"updated":"2017-02-13 15:53:17.000000000","message":"Use driver_ssl_cert_path instead of introducing a zadara-specific variable for this.","commit_id":"9a4d0435f96a3b6feee7753d7701b95cff5575a5"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"d2cac3c466c97fc97c08a9c6d95d708223eb4a1d","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        host \u003d self.conf.zadara_vpsa_host"},{"line_number":242,"context_line":"        port \u003d int(self.conf.zadara_vpsa_port)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        protocol \u003d \"https\" if self.conf.zadara_vpsa_use_ssl else \"http\""},{"line_number":245,"context_line":"        if protocol \u003d\u003d \"https\":"},{"line_number":246,"context_line":"            if not self.conf.zadara_ssl_cert_verify:"},{"line_number":247,"context_line":"                verify \u003d False"},{"line_number":248,"context_line":"            else:"},{"line_number":249,"context_line":"                cert \u003d ((self.conf.driver_ssl_cert_path) or None)"},{"line_number":250,"context_line":"                verify \u003d cert if cert else True"},{"line_number":251,"context_line":"        else:"},{"line_number":252,"context_line":"            verify \u003d False"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        if port:"},{"line_number":255,"context_line":"            api_url \u003d \"%s://%s:%d%s\" % (protocol, host, port, url)"},{"line_number":256,"context_line":"        else:"},{"line_number":257,"context_line":"            api_url \u003d \"%s://%s%s\" % (protocol, host, url)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        response \u003d requests.request(method, api_url, data\u003dbody, verify\u003dverify)"},{"line_number":260,"context_line":"        if response.status_code !\u003d 200:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_f8c5480a","line":257,"range":{"start_line":244,"start_character":0,"end_line":257,"end_character":57},"updated":"2017-02-16 18:09:35.000000000","message":"So, thanks for making updates to the test cases.  Forgive me if I am missing it, but generally when we add branches in the code like this I look for test cases to go with them.  So you should make sure verify is set properly based on zadara_ssl_cert_verify.  Also there should be a test case for the exception that is raised below if it doesn\u0027t already exist.","commit_id":"b162f7a66b15a298035ad0f9c5ecae12596edaab"}]}