)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"ed567b3bbaca8267b62bf5e50a992b39ec2f0c19","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use more specific asserts in tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of assertTrue and assertFalse use more specific asserts."},{"line_number":10,"context_line":"They are compatible with Python 2.7[1] and 3.4[2]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]: https://docs.python.org/2.7/library/unittest.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_ec097885","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":63},"updated":"2017-02-14 16:43:02.000000000","message":"You write that we need to use more specific asserts instead of assertTrue, but change assertEqual to assertTrue. \nI think, it\u0027s a mistake, because for me it\u0027s quite unlogical","commit_id":"928a8f3a49fd244f4ade948161cf810e19e238b3"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"ed567b3bbaca8267b62bf5e50a992b39ec2f0c19","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use more specific asserts in tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of assertTrue and assertFalse use more specific asserts."},{"line_number":10,"context_line":"They are compatible with Python 2.7[1] and 3.4[2]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]: https://docs.python.org/2.7/library/unittest.html"},{"line_number":13,"context_line":"[2]: https://docs.python.org/3.4/library/unittest.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_6c7588f8","line":10,"range":{"start_line":10,"start_character":43,"end_line":10,"end_character":49},"updated":"2017-02-14 16:43:02.000000000","message":"And we\u0027ve already changed default python3 version to 3.5 here\nhttps://review.openstack.org/#/c/409324/","commit_id":"928a8f3a49fd244f4ade948161cf810e19e238b3"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"ed567b3bbaca8267b62bf5e50a992b39ec2f0c19","unresolved":false,"context_lines":[{"line_number":10,"context_line":"They are compatible with Python 2.7[1] and 3.4[2]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1]: https://docs.python.org/2.7/library/unittest.html"},{"line_number":13,"context_line":"[2]: https://docs.python.org/3.4/library/unittest.html"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I0a7b11044b9968de9d9402c1a35b28374487b16c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_cc667450","line":13,"range":{"start_line":13,"start_character":29,"end_line":13,"end_character":32},"updated":"2017-02-14 16:43:02.000000000","message":"Same","commit_id":"928a8f3a49fd244f4ade948161cf810e19e238b3"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8b27884c4cad9632deb4f5cc753f21cc03fd4be5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use more specific asserts in tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead of assertEqual(False, A) and assertEqual(True, A)"},{"line_number":10,"context_line":"use assertFalse(A) and assertTrue(A)."},{"line_number":11,"context_line":"They are compatible with Python 3.5[1]"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]: https://docs.python.org/3.5/library/unittest.html"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7f287b81_74874763","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":33},"updated":"2017-08-24 19:44:06.000000000","message":"This looks like it actually covers assertFalse and assertIn","commit_id":"132cb70837d954d10c86be7b66ed352123593db4"}],"cinder/tests/unit/api/contrib/test_backups.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8948298db8d3f59bf5ad6435c6fa6a65ec9d139a","unresolved":false,"context_lines":[{"line_number":1035,"context_line":"        volume \u003d utils.create_volume(self.context, size\u003d2, host\u003dtesthost)"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"        # test empty service"},{"line_number":1038,"context_line":"        self.assertFalse(self.backup_api._is_backup_service_enabled("},{"line_number":1039,"context_line":"            volume.availability_zone, testhost))"},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"        # test host not match service"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f287b81_d03fa384","line":1038,"range":{"start_line":1038,"start_character":8,"end_line":1038,"end_character":24},"updated":"2017-08-30 15:24:33.000000000","message":"This is not more specific.  It is less specific.\n\nassertEqual(False, None) will fail, assertFalse(None) will pass, which means this test is being made less rigorous here.\n\nThis has come up many times in Cinder changes, so I will add it to devref documentation.","commit_id":"132cb70837d954d10c86be7b66ed352123593db4"}]}