)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9d239c51c079b602622b1152ae138844471dd557","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct Extend lvm Volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A volume extened which has some snapshot will be deactive."},{"line_number":10,"context_line":"With this change, the volume will be reactived."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11c9b5935d74a5a3d4562ec1ce534b9e412d6030"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_57b4b633","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":31},"updated":"2017-02-15 06:17:45.000000000","message":"a","commit_id":"d066aeb86bc30739f1adeaa2476842908d51d37b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9d239c51c079b602622b1152ae138844471dd557","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct Extend lvm Volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A volume extened which has some snapshot will be deactive."},{"line_number":10,"context_line":"With this change, the volume will be reactived."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11c9b5935d74a5a3d4562ec1ce534b9e412d6030"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_f7992ac5","line":9,"range":{"start_line":9,"start_character":49,"end_line":9,"end_character":57},"updated":"2017-02-15 06:17:45.000000000","message":"deactivated","commit_id":"d066aeb86bc30739f1adeaa2476842908d51d37b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9d239c51c079b602622b1152ae138844471dd557","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Correct Extend lvm Volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A volume extened which has some snapshot will be deactive."},{"line_number":10,"context_line":"With this change, the volume will be reactived."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11c9b5935d74a5a3d4562ec1ce534b9e412d6030"},{"line_number":13,"context_line":"Closes-Bug: #1663525"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa31d9ce_1795de85","line":10,"range":{"start_line":10,"start_character":37,"end_line":10,"end_character":46},"updated":"2017-02-15 06:17:45.000000000","message":"reactivated","commit_id":"d066aeb86bc30739f1adeaa2476842908d51d37b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f33041c966c6181bb01eda802a3fea24d4c62849","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct Extend lvm Volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A volume extened which has some snapshot will be deactivated."},{"line_number":10,"context_line":"With this change, the volume will be reactivated."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I11c9b5935d74a5a3d4562ec1ce534b9e412d6030"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a30ddce_da76e8a2","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":40},"updated":"2017-03-13 10:27:41.000000000","message":"nit: Extended volume that has snapshot","commit_id":"f2d3e94545cec2d6cfdb8177083aee7a5de92e62"}],"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f33041c966c6181bb01eda802a3fea24d4c62849","unresolved":false,"context_lines":[{"line_number":817,"context_line":"            LOG.error(_LE(\u0027StdOut  :%s\u0027), err.stdout)"},{"line_number":818,"context_line":"            LOG.error(_LE(\u0027StdErr  :%s\u0027), err.stderr)"},{"line_number":819,"context_line":"            raise"},{"line_number":820,"context_line":"        if self.lv_has_snapshot(lv_name):"},{"line_number":821,"context_line":"            self.activate_lv(lv_name)"},{"line_number":822,"context_line":""},{"line_number":823,"context_line":"    def vg_mirror_free_space(self, mirror_count):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_6728099b","line":820,"updated":"2017-03-13 10:27:41.000000000","message":"-1: We don\u0027t need to run the shell command again, we should be storing the value on L807.\n\n has_snapshot \u003d self.lv_has_snapshot(lv_name)\n if has_snapshot:","commit_id":"f2d3e94545cec2d6cfdb8177083aee7a5de92e62"}],"cinder/tests/unit/brick/test_brick_lvm.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f33041c966c6181bb01eda802a3fea24d4c62849","unresolved":false,"context_lines":[{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def test_lv_extend(self):"},{"line_number":393,"context_line":"        self.vg.deactivate_lv \u003d mock.MagicMock()"},{"line_number":394,"context_line":"        self.vg.activate_lv \u003d mock.MagicMock()"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        # Extend lv with snapshot and make sure deactivate called"},{"line_number":397,"context_line":"        self.vg.create_volume(\"test\", \"1G\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_9a1c706b","line":394,"updated":"2017-03-13 10:27:41.000000000","message":"nit: This is not how we should be using mocks, we should be using ``self.mock_object`` instead, but I guess it\u0027s OK for consistency with existing code in this test.","commit_id":"f2d3e94545cec2d6cfdb8177083aee7a5de92e62"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f33041c966c6181bb01eda802a3fea24d4c62849","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        self.vg.vg_name \u003d \"test-volumes\""},{"line_number":407,"context_line":"        self.vg.extend_volume(\"test\", \"2G\")"},{"line_number":408,"context_line":"        self.assertFalse(self.vg.deactivate_lv.called)"},{"line_number":409,"context_line":"        self.assertFalse(self.vg.activate_lv.called)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def test_lv_deactivate(self):"},{"line_number":412,"context_line":"        with mock.patch.object(self.vg, \u0027_execute\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_c729b59c","line":409,"updated":"2017-03-13 10:27:41.000000000","message":"nit:\n\n self.vg.activate_lv.assert_not_called()","commit_id":"f2d3e94545cec2d6cfdb8177083aee7a5de92e62"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"82397d9f5ece853d99c220d97695e0f6abc4c8ab","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        self.assertEqual(2.0, self.vg.vg_mirror_free_space(1))"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def test_lv_extend(self):"},{"line_number":393,"context_line":"        with mock.patch.object(self.vg, \u0027_execute\u0027):"},{"line_number":394,"context_line":"            lv_has_snapshot \u003d mock.Mock()"},{"line_number":395,"context_line":"            self.vg.lv_has_snapshot \u003d lv_has_snapshot"},{"line_number":396,"context_line":"            self.vg.deactivate_lv \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a22e58a_5d48162e","line":393,"updated":"2017-03-14 11:14:16.000000000","message":"nit: this whole test should be done with ddt","commit_id":"0d862d3d278aa7b923c75703e0943f40600247b4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"82397d9f5ece853d99c220d97695e0f6abc4c8ab","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"            # Extend lv with snapshot and make sure deactivate called"},{"line_number":400,"context_line":"            lv_has_snapshot.return_value \u003d True"},{"line_number":401,"context_line":"            self.vg.create_volume(\u0027test\u0027, \u00271G\u0027)"},{"line_number":402,"context_line":"            self.vg.extend_volume(\"test\", \"2G\")"},{"line_number":403,"context_line":"            self.vg.activate_lv.assert_called_once_with(\"test\")"},{"line_number":404,"context_line":"            self.vg.deactivate_lv.assert_called_once_with(\"test\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a22e58a_bd366ab2","line":401,"updated":"2017-03-14 11:14:16.000000000","message":"nit: this line is unnecessary","commit_id":"0d862d3d278aa7b923c75703e0943f40600247b4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"82397d9f5ece853d99c220d97695e0f6abc4c8ab","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            lv_has_snapshot.return_value \u003d False"},{"line_number":408,"context_line":"            self.vg.activate_lv.reset_mock()"},{"line_number":409,"context_line":"            self.vg.deactivate_lv.reset_mock()"},{"line_number":410,"context_line":"            self.vg.create_volume(\u0027test\u0027, \u00271G\u0027)"},{"line_number":411,"context_line":"            self.vg.extend_volume(\"test\", \"2G\")"},{"line_number":412,"context_line":"            self.vg.activate_lv.assert_not_called()"},{"line_number":413,"context_line":"            self.vg.deactivate_lv.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a22e58a_fd40e209","line":410,"updated":"2017-03-14 11:14:16.000000000","message":"nit: this line is unnecessary","commit_id":"0d862d3d278aa7b923c75703e0943f40600247b4"}]}