)]}'
{"cinder/api/contrib/backups.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8fb69f99ee3260e99fc1c7b77952f21326670053","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            msg \u003d _(\"Incorrect request body format\")"},{"line_number":131,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":132,"context_line":"        except exception.VolumeNotFound:"},{"line_number":133,"context_line":"            LOG.debug(\"Could not find volume %(vol)s to backup \","},{"line_number":134,"context_line":"                      {\u0027vol\u0027: volume_id})"},{"line_number":135,"context_line":"        container \u003d backup.get(\u0027container\u0027, None)"},{"line_number":136,"context_line":"        if container:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_bad308d4","line":133,"range":{"start_line":133,"start_character":61,"end_line":133,"end_character":63},"updated":"2017-02-15 13:49:14.000000000","message":"Please end with a \u0027.\u0027","commit_id":"63c84a5656ec4fe4583e82e0b543c4fee6637b45"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"8fb69f99ee3260e99fc1c7b77952f21326670053","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            msg \u003d _(\"Incorrect request body format\")"},{"line_number":131,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":132,"context_line":"        except exception.VolumeNotFound:"},{"line_number":133,"context_line":"            LOG.debug(\"Could not find volume %(vol)s to backup \","},{"line_number":134,"context_line":"                      {\u0027vol\u0027: volume_id})"},{"line_number":135,"context_line":"        container \u003d backup.get(\u0027container\u0027, None)"},{"line_number":136,"context_line":"        if container:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_3ae0f895","line":133,"range":{"start_line":133,"start_character":16,"end_line":133,"end_character":21},"updated":"2017-02-15 13:49:14.000000000","message":"This should be LOG.error please.","commit_id":"63c84a5656ec4fe4583e82e0b543c4fee6637b45"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"2d7a4ec35ad1c0e56117ce82ebd89df123a8b81d","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        try:"},{"line_number":126,"context_line":"            volume_id \u003d backup[\u0027volume_id\u0027]"},{"line_number":127,"context_line":"            if volume_id is None:"},{"line_number":128,"context_line":"                raise exception.VolumeNotFound"},{"line_number":129,"context_line":"        except KeyError:"},{"line_number":130,"context_line":"            msg \u003d _(\"Incorrect request body format\")"},{"line_number":131,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":132,"context_line":"        except exception.VolumeNotFound:"},{"line_number":133,"context_line":"            LOG.error(\"Could not find volume %(vol)s to backup.\","},{"line_number":134,"context_line":"                      {\u0027vol\u0027: volume_id})"},{"line_number":135,"context_line":"        container \u003d backup.get(\u0027container\u0027, None)"},{"line_number":136,"context_line":"        if container:"},{"line_number":137,"context_line":"            utils.check_string_length(container, \u0027Backup container\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_c1919248","line":134,"range":{"start_line":127,"start_character":0,"end_line":134,"end_character":41},"updated":"2017-02-16 02:47:53.000000000","message":"These two volume id validations are redundant, if not any volume_id is not passed. the code block will raise KeyError exception. and if you have detected that the volume_id is None,why don\u0027t you raise this error?","commit_id":"d6237689cc123cf06e83d62770c7073839003fab"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"434866e380e52a38dd90b36fafe4c3b4473d020f","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        try:"},{"line_number":126,"context_line":"            volume_id \u003d backup[\u0027volume_id\u0027]"},{"line_number":127,"context_line":"            if volume_id is None:"},{"line_number":128,"context_line":"                raise exception.VolumeNotFound"},{"line_number":129,"context_line":"        except KeyError:"},{"line_number":130,"context_line":"            msg \u003d _(\"Incorrect request body format\")"},{"line_number":131,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":132,"context_line":"        except exception.VolumeNotFound:"},{"line_number":133,"context_line":"            LOG.error(\"Could not find volume %(vol)s to backup.\","},{"line_number":134,"context_line":"                      {\u0027vol\u0027: volume_id})"},{"line_number":135,"context_line":"        container \u003d backup.get(\u0027container\u0027, None)"},{"line_number":136,"context_line":"        if container:"},{"line_number":137,"context_line":"            utils.check_string_length(container, \u0027Backup container\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_33b3a599","line":134,"range":{"start_line":127,"start_character":0,"end_line":134,"end_character":41},"in_reply_to":"fa31d9ce_c1919248","updated":"2017-02-16 03:31:27.000000000","message":"I concur.","commit_id":"d6237689cc123cf06e83d62770c7073839003fab"},{"author":{"_account_id":23006,"name":"xianming.mao","email":"xianming.mao@easystack.cn","username":"Mars"},"change_message_id":"ac6eaf341994d6e6d4e6853ec815eeca68d89d48","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        try:"},{"line_number":126,"context_line":"            volume_id \u003d backup[\u0027volume_id\u0027]"},{"line_number":127,"context_line":"            if volume_id is None:"},{"line_number":128,"context_line":"                raise exception.VolumeNotFound"},{"line_number":129,"context_line":"        except KeyError:"},{"line_number":130,"context_line":"            msg \u003d _(\"Incorrect request body format\")"},{"line_number":131,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":132,"context_line":"        except exception.VolumeNotFound:"},{"line_number":133,"context_line":"            LOG.error(\"Could not find volume %(vol)s to backup.\","},{"line_number":134,"context_line":"                      {\u0027vol\u0027: volume_id})"},{"line_number":135,"context_line":"        container \u003d backup.get(\u0027container\u0027, None)"},{"line_number":136,"context_line":"        if container:"},{"line_number":137,"context_line":"            utils.check_string_length(container, \u0027Backup container\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_73543dc9","line":134,"range":{"start_line":127,"start_character":0,"end_line":134,"end_character":41},"in_reply_to":"fa31d9ce_c1919248","updated":"2017-02-16 04:29:57.000000000","message":"Maybe you\u0027re right! Thanks!","commit_id":"d6237689cc123cf06e83d62770c7073839003fab"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ea869148cedfb54f8d09e5b7c14b3742c98c7364","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            volume_id \u003d backup[\u0027volume_id\u0027]"},{"line_number":128,"context_line":"            volume_all \u003d list(map(lambda x: x[\u0027id\u0027],"},{"line_number":129,"context_line":"                                  db.volume_get_all(context.elevated())))"},{"line_number":130,"context_line":"            if volume_id not in volume_all:"},{"line_number":131,"context_line":"                raise exception.VolumeNotFound"},{"line_number":132,"context_line":"        except KeyError:"},{"line_number":133,"context_line":"            msg \u003d _(\"Incorrect request body format\")"},{"line_number":134,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":135,"context_line":"        except exception.VolumeNotFound:"},{"line_number":136,"context_line":"            LOG.error(_LE(\"Could not find volume %(vol)s to backup.\"),"},{"line_number":137,"context_line":"                      {\u0027vol\u0027: volume_id})"},{"line_number":138,"context_line":"        container \u003d backup.get(\u0027container\u0027, None)"},{"line_number":139,"context_line":"        if container:"},{"line_number":140,"context_line":"            utils.check_string_length(container, \u0027Backup container\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_f4953e88","line":137,"range":{"start_line":128,"start_character":1,"end_line":137,"end_character":41},"updated":"2017-02-17 07:29:05.000000000","message":"Hey xianming.mao, if you wanna optimise this logic, I think it\u0027s as simple as:\n1. retrieve the volume object(ovo)\n2. pass the volume object instead of volume_id to the bakup.create method\nyou don\u0027t need to raise and catch the not found error, cause it will be handled in the wsgi layer.","commit_id":"f10dc03fe7d1159e1d1b1e1ff01728ac0bdf0328"},{"author":{"_account_id":22932,"name":"lijing","email":"lijing@gohighsec.com","username":"lijing"},"change_message_id":"12b2cc353a55df8ea9bb721c2f201bf488592549","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            msg \u003d _(\"Incorrect request body format\")"},{"line_number":130,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":131,"context_line":"        # Add volume_ref is aim to use ovo check volume_id whether exists."},{"line_number":132,"context_line":"        volume_ref \u003d objects.Volume.get_by_id(context, volume_id)"},{"line_number":133,"context_line":"        container \u003d backup.get(\u0027container\u0027, None)"},{"line_number":134,"context_line":"        if container:"},{"line_number":135,"context_line":"            utils.check_string_length(container, \u0027Backup container\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da36d5c6_65dd2b70","line":132,"range":{"start_line":132,"start_character":8,"end_line":132,"end_character":65},"updated":"2017-02-20 10:23:06.000000000","message":"I think it\u0027s better to use a try to wrap this.","commit_id":"fde91c5ce87a1e34f7c811bb4c84198c9e841c5c"}]}