)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"43b41b62d89c3a18ec1028e7bf0a542d014d05e5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"2. when trying to attach deleted volume;"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds neccesary exception handler to initialize_connection"},{"line_number":15,"context_line":"volume action. Also unit test provided."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1f4982ec5a045070db981c864b4235271c92e497"},{"line_number":18,"context_line":"Closes-Bug: #1515101"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa31d9ce_0e3719e4","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":39},"updated":"2017-02-17 10:36:14.000000000","message":"nit: This is not necessary.","commit_id":"aae67645e6d0b3830911d6bd841f48799abb59fd"}],"cinder/api/contrib/volume_actions.py":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"e8c0b4b20b9b2564b99aa5b001a177d54a04bc53","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            raise webob.exc.HTTPInternalServerError(explanation\u003dmsg)"},{"line_number":180,"context_line":"        except messaging.RemoteError as error:"},{"line_number":181,"context_line":"            if error.exc_type in [\u0027InvalidInput\u0027, \u0027VolumeBackendAPIException\u0027]:"},{"line_number":182,"context_line":"                msg \u003d \"Error attaching volume - %(err_type)s: %(err_msg)s\" % {"},{"line_number":183,"context_line":"                      \u0027err_type\u0027: error.exc_type, \u0027err_msg\u0027: error.value}"},{"line_number":184,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":185,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_f4b2c505","line":182,"updated":"2017-02-16 11:47:06.000000000","message":"_()","commit_id":"76e4bff1700e35983f6a0794a2b542e2ade7fd6c"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"4f75a58c5d8fc729c8587fdb871a38d7a002fc72","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            raise webob.exc.HTTPInternalServerError(explanation\u003dmsg)"},{"line_number":180,"context_line":"        except messaging.RemoteError as error:"},{"line_number":181,"context_line":"            if error.exc_type in [\u0027InvalidInput\u0027, \u0027VolumeBackendAPIException\u0027]:"},{"line_number":182,"context_line":"                msg \u003d \"Error attaching volume - %(err_type)s: %(err_msg)s\" % {"},{"line_number":183,"context_line":"                      \u0027err_type\u0027: error.exc_type, \u0027err_msg\u0027: error.value}"},{"line_number":184,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":185,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_e758558d","line":182,"in_reply_to":"fa31d9ce_f4b2c505","updated":"2017-02-16 12:12:40.000000000","message":"Done","commit_id":"76e4bff1700e35983f6a0794a2b542e2ade7fd6c"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"2b649e8a51a17f13101f2d52f24176739ec76192","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        except messaging.RemoteError as error:"},{"line_number":80,"context_line":"            if error.exc_type in [\u0027InvalidVolume\u0027, \u0027InvalidUUID\u0027,"},{"line_number":81,"context_line":"                                  \u0027InvalidVolumeAttachMode\u0027]:"},{"line_number":82,"context_line":"                msg \u003d _(\"Error attaching volume - %(err_type)s: \""},{"line_number":83,"context_line":"                        \"%(err_msg)s\") % {"},{"line_number":84,"context_line":"                    \u0027err_type\u0027: error.exc_type, \u0027err_msg\u0027: error.value}"},{"line_number":85,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_e5e04dcf","line":82,"range":{"start_line":82,"start_character":22,"end_line":82,"end_character":24},"updated":"2017-02-16 12:56:21.000000000","message":"Why this change? is it required to fix this issue?","commit_id":"6d269f2a42827420b2f09402c4a659db211ac938"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"2b649e8a51a17f13101f2d52f24176739ec76192","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            msg \u003d _(\"Unable to fetch connection information from backend.\")"},{"line_number":181,"context_line":"            raise webob.exc.HTTPInternalServerError(explanation\u003dmsg)"},{"line_number":182,"context_line":"        except messaging.RemoteError as error:"},{"line_number":183,"context_line":"            if error.exc_type in [\u0027InvalidInput\u0027, \u0027VolumeBackendAPIException\u0027]:"},{"line_number":184,"context_line":"                msg \u003d _(\"Error attaching volume - %(err_type)s: \""},{"line_number":185,"context_line":"                        \"%(err_msg)s\") % {"},{"line_number":186,"context_line":"                    \u0027err_type\u0027: error.exc_type, \u0027err_msg\u0027: error.value}"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_6591bd52","line":183,"range":{"start_line":183,"start_character":51,"end_line":183,"end_character":76},"updated":"2017-02-16 12:56:21.000000000","message":"Is it right to return HTTPBadRequest in case of \u0027VolumeBackendAPIException\u0027 ?","commit_id":"6d269f2a42827420b2f09402c4a659db211ac938"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"336d1ef4328013f0ae74afe2578076fac9a67510","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            msg \u003d _(\"Unable to fetch connection information from backend.\")"},{"line_number":181,"context_line":"            raise webob.exc.HTTPInternalServerError(explanation\u003dmsg)"},{"line_number":182,"context_line":"        except messaging.RemoteError as error:"},{"line_number":183,"context_line":"            if error.exc_type in [\u0027InvalidInput\u0027, \u0027VolumeBackendAPIException\u0027]:"},{"line_number":184,"context_line":"                msg \u003d _(\"Error attaching volume - %(err_type)s: \""},{"line_number":185,"context_line":"                        \"%(err_msg)s\") % {"},{"line_number":186,"context_line":"                    \u0027err_type\u0027: error.exc_type, \u0027err_msg\u0027: error.value}"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_9bba9409","line":183,"range":{"start_line":183,"start_character":51,"end_line":183,"end_character":76},"in_reply_to":"fa31d9ce_6591bd52","updated":"2017-02-16 13:27:18.000000000","message":"Oh...Good catch. I agree with you. Thanks for it","commit_id":"6d269f2a42827420b2f09402c4a659db211ac938"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"43b41b62d89c3a18ec1028e7bf0a542d014d05e5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        except messaging.RemoteError as error:"},{"line_number":80,"context_line":"            if error.exc_type in [\u0027InvalidVolume\u0027, \u0027InvalidUUID\u0027,"},{"line_number":81,"context_line":"                                  \u0027InvalidVolumeAttachMode\u0027]:"},{"line_number":82,"context_line":"                msg \u003d _(\"Error attaching volume - %(err_type)s: \""},{"line_number":83,"context_line":"                        \"%(err_msg)s\") % {"},{"line_number":84,"context_line":"                    \u0027err_type\u0027: error.exc_type, \u0027err_msg\u0027: error.value}"},{"line_number":85,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_ee12c557","line":82,"updated":"2017-02-17 10:36:14.000000000","message":"nit: This change is unrelated","commit_id":"aae67645e6d0b3830911d6bd841f48799abb59fd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"43b41b62d89c3a18ec1028e7bf0a542d014d05e5","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.volume_api.detach(context, volume, attachment_id)"},{"line_number":107,"context_line":"        except messaging.RemoteError as error:"},{"line_number":108,"context_line":"            if error.exc_type in [\u0027VolumeAttachmentNotFound\u0027, \u0027InvalidVolume\u0027]:"},{"line_number":109,"context_line":"                msg \u003d _(\"Error detaching volume - %(err_type)s: \""},{"line_number":110,"context_line":"                        \"%(err_msg)s\") % {"},{"line_number":111,"context_line":"                    \u0027err_type\u0027: error.exc_type, \u0027err_msg\u0027: error.value}"},{"line_number":112,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_0e10f94d","line":109,"updated":"2017-02-17 10:36:14.000000000","message":"nit: ditto","commit_id":"aae67645e6d0b3830911d6bd841f48799abb59fd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"43b41b62d89c3a18ec1028e7bf0a542d014d05e5","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                    \"%(err_msg)s\") % {"},{"line_number":185,"context_line":"                \u0027err_type\u0027: error.exc_type, \u0027err_msg\u0027: error.value}"},{"line_number":186,"context_line":"            if error.exc_type \u003d\u003d \u0027InvalidInput\u0027:"},{"line_number":187,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":188,"context_line":"            elif error.exc_type \u003d\u003d \u0027VolumeBackendAPIException\u0027:"},{"line_number":189,"context_line":"                raise webob.exc.HTTPInternalServerError(explanation\u003dmsg)"},{"line_number":190,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_ee6725e8","line":187,"updated":"2017-02-17 10:36:14.000000000","message":"-1: We should raise InvalidInput exception and let the middleware layer handle the conversion.","commit_id":"aae67645e6d0b3830911d6bd841f48799abb59fd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"43b41b62d89c3a18ec1028e7bf0a542d014d05e5","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            if error.exc_type \u003d\u003d \u0027InvalidInput\u0027:"},{"line_number":187,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":188,"context_line":"            elif error.exc_type \u003d\u003d \u0027VolumeBackendAPIException\u0027:"},{"line_number":189,"context_line":"                raise webob.exc.HTTPInternalServerError(explanation\u003dmsg)"},{"line_number":190,"context_line":"            else:"},{"line_number":191,"context_line":"                raise"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa31d9ce_aeafed7b","line":189,"updated":"2017-02-17 10:36:14.000000000","message":"-1: We shouldn\u0027t be doing this, many drivers use this exception to report information that only admins should be reading.","commit_id":"aae67645e6d0b3830911d6bd841f48799abb59fd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"38f1375ee1f6df46ca95ef28afef690ca484ecb9","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            raise webob.exc.HTTPInternalServerError(explanation\u003dmsg)"},{"line_number":182,"context_line":"        except messaging.RemoteError as error:"},{"line_number":183,"context_line":"            if error.exc_type \u003d\u003d \u0027InvalidInput\u0027:"},{"line_number":184,"context_line":"                msg \u003d _(\"Error attaching volume - %(err_type)s: \""},{"line_number":185,"context_line":"                        \"%(err_msg)s\") % {"},{"line_number":186,"context_line":"                    \u0027err_type\u0027: error.exc_type, \u0027err_msg\u0027: error.value}"},{"line_number":187,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":188,"context_line":"            else:"},{"line_number":189,"context_line":"                raise"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_0865d51c","line":187,"range":{"start_line":184,"start_character":0,"end_line":187,"end_character":56},"updated":"2017-03-10 10:30:27.000000000","message":"-1: I don\u0027t think we should be changing the exception message:\n\n raise exception.InvalidInput(message\u003derror.value)","commit_id":"26532b7cfbe245a07d02d485f3ab91ad7333bff1"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"38f1375ee1f6df46ca95ef28afef690ca484ecb9","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                        \"%(err_msg)s\") % {"},{"line_number":186,"context_line":"                    \u0027err_type\u0027: error.exc_type, \u0027err_msg\u0027: error.value}"},{"line_number":187,"context_line":"                raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":188,"context_line":"            else:"},{"line_number":189,"context_line":"                raise"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        return {\u0027connection_info\u0027: info}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_c87f3da9","line":188,"updated":"2017-03-10 10:30:27.000000000","message":"-1: No need for an else","commit_id":"26532b7cfbe245a07d02d485f3ab91ad7333bff1"}]}