)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ae0901bf50ebb39ba04f2f6276675b3868aa1bbe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     poojajadhav \u003cpooja.jadhav@nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-20 17:59:03 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Extracted HTTP response codes to constants"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are several places in the source code where HTTP response"},{"line_number":10,"context_line":"codes are used as numeric values."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_51691989","line":7,"updated":"2017-09-04 11:32:20.000000000","message":"nit: Please add prefix for the drivers where this is being changed.","commit_id":"502e7bc05db0ef89293a37cd693738d0c092e9ef"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ae0901bf50ebb39ba04f2f6276675b3868aa1bbe","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There are several places in the source code where HTTP response"},{"line_number":10,"context_line":"codes are used as numeric values."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Status codes 200, 400, 401, 403, 404, 409 and 500 under"},{"line_number":13,"context_line":"tests/unit/volume/drivers are replaced with symbolic constants from"},{"line_number":14,"context_line":"six.moves.http_client thus improves code readability. More patches"},{"line_number":15,"context_line":"will be submitted to address other status codes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_7101b5af","line":12,"updated":"2017-09-04 11:32:20.000000000","message":"nit: Add comment with the scope of the change, otherwise reading commit history will be misleading.","commit_id":"502e7bc05db0ef89293a37cd693738d0c092e9ef"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4b8873b3a802f9a679230319aa1c70291bc151ab","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Status codes 200, 400, 401, 403, 404, 409 and 500 under"},{"line_number":13,"context_line":"tests/unit/volume/drivers(dell_emc,hpe) are replaced with symbolic"},{"line_number":14,"context_line":"constants from six.moves.http_client thus improves code readability."},{"line_number":15,"context_line":"More patches will be submitted to address other status codes."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partial-Bug: #1520159"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f515b1d_1c439f15","line":14,"range":{"start_line":14,"start_character":37,"end_line":14,"end_character":67},"updated":"2017-10-05 17:54:12.000000000","message":"This is quite arguable in unit tests.\n\nUnit tests mocking a response from an HTTP server are perfectly right to just say \"400\" because that\u0027s what\u0027s in the response.  The response doesn\u0027t say http.bad_request, which requires translation in the developer\u0027s mind when reading the code and grepping through tests.\n\n-1 to doing this in unit tests.","commit_id":"c1f3463d55303222912c75d06a8f3cdfb81f37c5"}],"cinder/tests/unit/volume/drivers/dell_emc/scaleio/test_manage_existing_snapshot.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ae0901bf50ebb39ba04f2f6276675b3868aa1bbe","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                        \u0027sizeInKb\u0027: 8000000,"},{"line_number":63,"context_line":"                        \u0027mappedSdcInfo\u0027: None,"},{"line_number":64,"context_line":"                        \u0027ancestorVolumeId\u0027: fake.PROVIDER_ID"},{"line_number":65,"context_line":"                    }, 200),"},{"line_number":66,"context_line":"                \u0027instances/Volume::\u0027 + self.snapshot2[\u0027provider_id\u0027]:"},{"line_number":67,"context_line":"                    mocks.MockHTTPSResponse({"},{"line_number":68,"context_line":"                        \u0027id\u0027: fake.PROVIDER3_ID,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_d15d09ea","line":65,"range":{"start_line":65,"start_character":23,"end_line":65,"end_character":26},"updated":"2017-09-04 11:32:20.000000000","message":"-1: Missed this one","commit_id":"502e7bc05db0ef89293a37cd693738d0c092e9ef"}]}