)]}'
{"cinder/volume/drivers/netapp/eseries/client.py":[{"author":{"_account_id":22683,"name":"Arnon Yaari","email":"arnony@infinidat.com","username":"arnony"},"change_message_id":"11a2371e7c654a2554b7eafc7098d2072eba6ef1","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        \"\"\"Evaluates response before passing result to invoker.\"\"\""},{"line_number":342,"context_line":"        status_code \u003d int(response.status_code)"},{"line_number":343,"context_line":"        # codes \u003e\u003d 300 are not ok and to be treated as errors"},{"line_number":344,"context_line":"        if status_code \u003e\u003d http_client.MULTIPLE_CHOICES:"},{"line_number":345,"context_line":"            # Response code 422 returns error code and message"},{"line_number":346,"context_line":"            if status_code \u003d\u003d http_client.UNPROCESSABLE_ENTITY:"},{"line_number":347,"context_line":"                msg \u003d _(\"Response error - %s.\") % response.text"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_7fca13a3","line":344,"updated":"2017-02-20 14:40:50.000000000","message":"IMO in this particular case we should leave the numeral instead of using the constant. The constant has no meaning in this context, and the comment explains why \"300\" is used.\nSomething similar can be found in the \"requests\" library, where they use \"codes.xxx\" for the constants where needed, but the numbers in \"raise_for_status\": https://github.com/kennethreitz/requests/blob/master/requests/models.py#L921","commit_id":"16a155e9b0e14803fc9502266b6db93e32d7b564"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"8271c288e9cf69e3ba455fc46f3d27f69a43ed16","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        try:"},{"line_number":469,"context_line":"            return self._invoke(\u0027GET\u0027, path, **{\u0027object-id\u0027: object_id})"},{"line_number":470,"context_line":"        except es_exception.WebServiceException as e:"},{"line_number":471,"context_line":"            if http_client.NOT_FOUND \u003d\u003d e.status_code:"},{"line_number":472,"context_line":"                raise exception.VolumeNotFound(volume_id\u003dobject_id)"},{"line_number":473,"context_line":"            else:"},{"line_number":474,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_277318ea","line":471,"range":{"start_line":471,"start_character":15,"end_line":471,"end_character":53},"updated":"2017-05-29 08:14:41.000000000","message":"This will be better to read\n\n  e.status_code \u003d\u003d http_client.NOT_FOUND","commit_id":"7c5b630838bc9120522236d4cd39d47a9f81861d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cc3d32afb3eaf31cd50c0b03ca736f6a868af637","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        \"\"\"Evaluates response before passing result to invoker.\"\"\""},{"line_number":341,"context_line":"        status_code \u003d int(response.status_code)"},{"line_number":342,"context_line":"        # codes \u003e\u003d 300 are not ok and to be treated as errors"},{"line_number":343,"context_line":"        if status_code \u003e\u003d http_client.MULTIPLE_CHOICES:"},{"line_number":344,"context_line":"            # Response code 422 returns error code and message"},{"line_number":345,"context_line":"            if status_code \u003d\u003d http_client.UNPROCESSABLE_ENTITY:"},{"line_number":346,"context_line":"                msg \u003d _(\"Response error - %s.\") % response.text"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f515b1d_fc72037c","line":343,"range":{"start_line":343,"start_character":11,"end_line":343,"end_character":54},"updated":"2017-10-05 17:55:12.000000000","message":"Saying \"\u003e\u003d http_client.MULTIPLE_CHOICES\" is way more confusing than \"\u003e\u003d 300\", which is the actual intent here.","commit_id":"0e9088fddc9706c8055b49406e28713ac5bbd71b"}],"cinder/volume/drivers/synology/synology_common.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"8271c288e9cf69e3ba455fc46f3d27f69a43ed16","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        LOG.debug(\u0027%s\u0027, json.dumps(result, indent\u003d4))"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        # Check for status code"},{"line_number":385,"context_line":"        if (http_client.OK !\u003d http_status):"},{"line_number":386,"context_line":"            result \u003d {\u0027http_status\u0027: http_status}"},{"line_number":387,"context_line":"        elif \u0027success\u0027 not in result:"},{"line_number":388,"context_line":"            reason \u003d _(\"\u0027success\u0027 not found\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_e755201f","line":385,"range":{"start_line":385,"start_character":12,"end_line":385,"end_character":41},"updated":"2017-05-29 08:14:41.000000000","message":"here too","commit_id":"7c5b630838bc9120522236d4cd39d47a9f81861d"}]}