)]}'
{"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":23100,"name":"Swapnil Nilangekar","email":"swapnil.sun.nilangekar@hpe.com","username":"swapnil-nilangekar"},"change_message_id":"75937b3adbe44b84be8c0c779ff167c48103acee","unresolved":false,"context_lines":[{"line_number":2041,"context_line":"                                  tpvv\u003dtype_info[\u0027tpvv\u0027],"},{"line_number":2042,"context_line":"                                  tdvv\u003dtype_info[\u0027tdvv\u0027])"},{"line_number":2043,"context_line":""},{"line_number":2044,"context_line":"                if qos or vvs_name or flash_cache is not None:"},{"line_number":2045,"context_line":"                    try:"},{"line_number":2046,"context_line":"                        self._add_volume_to_volume_set("},{"line_number":2047,"context_line":"                            volume, vol_name, cpg, vvs_name, qos, flash_cache)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_c5c4f260","line":2044,"range":{"start_line":2044,"start_character":38,"end_line":2044,"end_character":49},"updated":"2017-02-21 10:24:16.000000000","message":"Can we have this check for non-online copy as well(if qos/vvs_name/flash_cache is not None:) and add the copied volume to the VVset. \nIn non-online mode of operation, code is creating a required volume but not adding it to a vvset.\n\nAfter the task_id status is complete, volume should be added to vvset","commit_id":"a46ca9c865ae1eaa706e59716d9c0c1b09753760"},{"author":{"_account_id":24952,"name":"Vivek Soni","email":"viveksoni31390@gmail.com","username":"sonivi"},"change_message_id":"2d5657314ecffbac59988542d404336c6be8a57d","unresolved":false,"context_lines":[{"line_number":2041,"context_line":"                                  tpvv\u003dtype_info[\u0027tpvv\u0027],"},{"line_number":2042,"context_line":"                                  tdvv\u003dtype_info[\u0027tdvv\u0027])"},{"line_number":2043,"context_line":""},{"line_number":2044,"context_line":"                if qos or vvs_name or flash_cache is not None:"},{"line_number":2045,"context_line":"                    try:"},{"line_number":2046,"context_line":"                        self._add_volume_to_volume_set("},{"line_number":2047,"context_line":"                            volume, vol_name, cpg, vvs_name, qos, flash_cache)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_73ee98b5","line":2044,"range":{"start_line":2044,"start_character":38,"end_line":2044,"end_character":49},"in_reply_to":"da36d5c6_c5c4f260","updated":"2017-03-16 08:56:01.000000000","message":"we have this check in non-online copy in \u0027create_volume\u0027 function","commit_id":"a46ca9c865ae1eaa706e59716d9c0c1b09753760"},{"author":{"_account_id":22664,"name":"William Durairaj","email":"william.dur.sandanaraj@hpe.com","username":"william.durairaj"},"change_message_id":"844030e2a86c07591ec70894c47a88c8ba1b2b85","unresolved":false,"context_lines":[{"line_number":2047,"context_line":"                            volume, vol_name, cpg, vvs_name, qos, flash_cache)"},{"line_number":2048,"context_line":"                    except exception.InvalidInput as ex:"},{"line_number":2049,"context_line":"                        # Delete volume if unable to add it to the volume set"},{"line_number":2050,"context_line":"                        self.client.deleteVolume(vol_name)"},{"line_number":2051,"context_line":"                        LOG.error(_LE(\"Exception: %s\"), ex)"},{"line_number":2052,"context_line":"                        raise exception.CinderException(ex)"},{"line_number":2053,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_eb09ce32","line":2050,"range":{"start_line":2050,"start_character":36,"end_line":2050,"end_character":48},"updated":"2017-02-21 06:58:09.000000000","message":"Do we really need to delete the cloned volume when we can\u0027t add that cloned volume to a volume set ?\n\nCan you explain the rationale behind this?","commit_id":"a46ca9c865ae1eaa706e59716d9c0c1b09753760"},{"author":{"_account_id":24952,"name":"Vivek Soni","email":"viveksoni31390@gmail.com","username":"sonivi"},"change_message_id":"2d5657314ecffbac59988542d404336c6be8a57d","unresolved":false,"context_lines":[{"line_number":2047,"context_line":"                            volume, vol_name, cpg, vvs_name, qos, flash_cache)"},{"line_number":2048,"context_line":"                    except exception.InvalidInput as ex:"},{"line_number":2049,"context_line":"                        # Delete volume if unable to add it to the volume set"},{"line_number":2050,"context_line":"                        self.client.deleteVolume(vol_name)"},{"line_number":2051,"context_line":"                        LOG.error(_LE(\"Exception: %s\"), ex)"},{"line_number":2052,"context_line":"                        raise exception.CinderException(ex)"},{"line_number":2053,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_13272413","line":2050,"range":{"start_line":2050,"start_character":36,"end_line":2050,"end_character":48},"in_reply_to":"da36d5c6_eb09ce32","updated":"2017-03-16 08:56:01.000000000","message":"Yes, we need to delete the cloned volume if its source volume is in vvset and the cloned volume is not added to vvset.\n\nwe have similar check in case of non-online copy.","commit_id":"a46ca9c865ae1eaa706e59716d9c0c1b09753760"}]}