)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"11f6506cea50dfbefb7d81899bdf7d8a2e8ee9a5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Log message cleanup for volume-usage-audit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume-usage-audit utlis logs unecessary message at for deleted"},{"line_number":10,"context_line":"volumes or exception:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  try:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_974bab86","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":63},"updated":"2017-02-23 18:01:44.000000000","message":"From this commit message I find it hard to understand what this change is all about. No need to get here to too much details and examples, just write something like, \"reduce the amount of debug messages on exceptions, and change some debug messages to info\".","commit_id":"82792be330e3b88aa1f625537ae1d2649e14ba4f"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"11f6506cea50dfbefb7d81899bdf7d8a2e8ee9a5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Log message cleanup for volume-usage-audit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"volume-usage-audit utlis logs unecessary message at for deleted"},{"line_number":10,"context_line":"volumes or exception:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  try:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_7749d7b6","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":24},"updated":"2017-02-23 18:01:44.000000000","message":"nit: utils","commit_id":"82792be330e3b88aa1f625537ae1d2649e14ba4f"}],"cinder/cmd/volume_usage_audit.py":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"11f6506cea50dfbefb7d81899bdf7d8a2e8ee9a5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                                        \u0027end\u0027: end}"},{"line_number":96,"context_line":"        LOG.error(msg)"},{"line_number":97,"context_line":"        sys.exit(-1)"},{"line_number":98,"context_line":"    LOG.info(_LI(\"Starting volume usage audit\"))"},{"line_number":99,"context_line":"    msg \u003d _LI(\"Creating usages for %(begin_period)s until %(end_period)s\")"},{"line_number":100,"context_line":"    LOG.info(msg, {\"begin_period\": str(begin), \"end_period\": str(end)})"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    extra_info \u003d {"},{"line_number":103,"context_line":"        \u0027audit_period_beginning\u0027: str(begin),"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_9732cb0e","line":100,"range":{"start_line":98,"start_character":4,"end_line":100,"end_character":71},"updated":"2017-02-23 18:01:44.000000000","message":"Why should this be INFO level?","commit_id":"82792be330e3b88aa1f625537ae1d2649e14ba4f"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"11f6506cea50dfbefb7d81899bdf7d8a2e8ee9a5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    volumes \u003d db.volume_get_active_by_window(admin_context,"},{"line_number":108,"context_line":"                                             begin,"},{"line_number":109,"context_line":"                                             end)"},{"line_number":110,"context_line":"    LOG.info(_LI(\"Found %d volumes\"), len(volumes))"},{"line_number":111,"context_line":"    for volume_ref in volumes:"},{"line_number":112,"context_line":"        try:"},{"line_number":113,"context_line":"            cinder.volume.utils.notify_about_volume_usage("}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_f73dc7dd","line":110,"range":{"start_line":110,"start_character":4,"end_line":110,"end_character":13},"updated":"2017-02-23 18:01:44.000000000","message":"Why should this be INFO level? Same question applies in other places","commit_id":"82792be330e3b88aa1f625537ae1d2649e14ba4f"}],"cinder/volume/utils.py":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"11f6506cea50dfbefb7d81899bdf7d8a2e8ee9a5","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        # In that case, not going any further by abusing low level"},{"line_number":159,"context_line":"        # DB API to fetch deleted volume but simply return empty"},{"line_number":160,"context_line":"        # string for snapshot\u0027s AZ info."},{"line_number":161,"context_line":"        az \u003d \u0027\u0027"},{"line_number":162,"context_line":"        LOG.debug(\"Source volume %s deleted\", snapshot.volume_id)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    usage_info \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_92181977","line":161,"range":{"start_line":161,"start_character":8,"end_line":161,"end_character":10},"updated":"2017-02-23 18:01:44.000000000","message":"How about calling this variable something more meaningful (e.g. availability_sone)","commit_id":"82792be330e3b88aa1f625537ae1d2649e14ba4f"}]}