)]}'
{"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"db4497e40051687fcabababd26636e9e500b6c70","unresolved":false,"context_lines":[{"line_number":5875,"context_line":"        pool \u003d _get_test_pool()"},{"line_number":5876,"context_line":"        volume_type \u003d self.non_replica_type"},{"line_number":5877,"context_line":"        if vol_type:"},{"line_number":5878,"context_line":"            volume_type \u003d vol_type"},{"line_number":5879,"context_line":"        prop \u003d {\u0027size\u0027: 10,"},{"line_number":5880,"context_line":"                \u0027volume_type_id\u0027: volume_type[\u0027id\u0027],"},{"line_number":5881,"context_line":"                \u0027host\u0027: \u0027openstack@svc#%s\u0027 % pool}"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_a0c21532","line":5878,"range":{"start_line":5878,"start_character":26,"end_line":5878,"end_character":34},"updated":"2017-02-24 02:05:09.000000000","message":"is it better to change L5876-L5878 to volume_type \u003d vol_type if vol_type else self.non_replica_type?","commit_id":"9f48f1454a928b51b1f8fb7a5d44e8af4fd2066a"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"2085c21fd3f778f640f0921a13bfb057ecf5b695","unresolved":false,"context_lines":[{"line_number":5875,"context_line":"        pool \u003d _get_test_pool()"},{"line_number":5876,"context_line":"        volume_type \u003d self.non_replica_type"},{"line_number":5877,"context_line":"        if vol_type:"},{"line_number":5878,"context_line":"            volume_type \u003d vol_type"},{"line_number":5879,"context_line":"        prop \u003d {\u0027size\u0027: 10,"},{"line_number":5880,"context_line":"                \u0027volume_type_id\u0027: volume_type[\u0027id\u0027],"},{"line_number":5881,"context_line":"                \u0027host\u0027: \u0027openstack@svc#%s\u0027 % pool}"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_44b40834","line":5878,"range":{"start_line":5878,"start_character":26,"end_line":5878,"end_character":34},"in_reply_to":"da36d5c6_a0c21532","updated":"2017-02-24 09:08:51.000000000","message":"Jiamin, thanks a lot for your comments. It\u0027s addressed in new patch.","commit_id":"9f48f1454a928b51b1f8fb7a5d44e8af4fd2066a"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"db4497e40051687fcabababd26636e9e500b6c70","unresolved":false,"context_lines":[{"line_number":2812,"context_line":"    def _failover_unreplicated_volume(self, unreplicated_vols):"},{"line_number":2813,"context_line":"        volumes_update \u003d []"},{"line_number":2814,"context_line":"        for vol in unreplicated_vols:"},{"line_number":2815,"context_line":"            if (\u0027replication_driver_data\u0027 in vol and"},{"line_number":2816,"context_line":"                    vol[\u0027replication_driver_data\u0027]):"},{"line_number":2817,"context_line":"                rep_data \u003d json.loads(vol[\u0027replication_driver_data\u0027])"},{"line_number":2818,"context_line":"                update_status \u003d rep_data[\u0027previous_status\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_c0c38955","line":2815,"range":{"start_line":2815,"start_character":17,"end_line":2815,"end_character":40},"updated":"2017-02-24 02:05:09.000000000","message":"volume object always has field replication_driver_data.","commit_id":"9f48f1454a928b51b1f8fb7a5d44e8af4fd2066a"},{"author":{"_account_id":17564,"name":"jiamin","email":"shljia@cn.ibm.com","username":"jiamin"},"change_message_id":"db4497e40051687fcabababd26636e9e500b6c70","unresolved":false,"context_lines":[{"line_number":2813,"context_line":"        volumes_update \u003d []"},{"line_number":2814,"context_line":"        for vol in unreplicated_vols:"},{"line_number":2815,"context_line":"            if (\u0027replication_driver_data\u0027 in vol and"},{"line_number":2816,"context_line":"                    vol[\u0027replication_driver_data\u0027]):"},{"line_number":2817,"context_line":"                rep_data \u003d json.loads(vol[\u0027replication_driver_data\u0027])"},{"line_number":2818,"context_line":"                update_status \u003d rep_data[\u0027previous_status\u0027]"},{"line_number":2819,"context_line":"                rep_data \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_c09aa96d","line":2816,"range":{"start_line":2816,"start_character":25,"end_line":2816,"end_character":48},"updated":"2017-02-24 02:05:09.000000000","message":"is it better to change it to vol.replication_driver_data?","commit_id":"9f48f1454a928b51b1f8fb7a5d44e8af4fd2066a"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"2085c21fd3f778f640f0921a13bfb057ecf5b695","unresolved":false,"context_lines":[{"line_number":2813,"context_line":"        volumes_update \u003d []"},{"line_number":2814,"context_line":"        for vol in unreplicated_vols:"},{"line_number":2815,"context_line":"            if (\u0027replication_driver_data\u0027 in vol and"},{"line_number":2816,"context_line":"                    vol[\u0027replication_driver_data\u0027]):"},{"line_number":2817,"context_line":"                rep_data \u003d json.loads(vol[\u0027replication_driver_data\u0027])"},{"line_number":2818,"context_line":"                update_status \u003d rep_data[\u0027previous_status\u0027]"},{"line_number":2819,"context_line":"                rep_data \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_c47e3869","line":2816,"range":{"start_line":2816,"start_character":25,"end_line":2816,"end_character":48},"in_reply_to":"da36d5c6_c09aa96d","updated":"2017-02-24 09:08:51.000000000","message":"Jiamin, thanks a lot for your comments. It\u0027s addressed in new patch.","commit_id":"9f48f1454a928b51b1f8fb7a5d44e8af4fd2066a"},{"author":{"_account_id":22583,"name":"Cheng Yong Zhao","email":"zhaochy@cn.ibm.com","username":"zhaochy"},"change_message_id":"9cb1a3ce5a7c047f28eebae79dcd9292dab47d8f","unresolved":false,"context_lines":[{"line_number":3001,"context_line":"                  {\u0027volumes_update\u0027: volumes_update})"},{"line_number":3002,"context_line":"        return volumes_update"},{"line_number":3003,"context_line":""},{"line_number":3004,"context_line":"    def _classify_volume(self, ctxt, volumes):"},{"line_number":3005,"context_line":"        normal_volumes \u003d []"},{"line_number":3006,"context_line":"        replica_volumes \u003d []"},{"line_number":3007,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_ce7b85f3","line":3004,"updated":"2017-02-27 02:20:45.000000000","message":"Is it better to change function name from \"_classify_volume\" to \"_classify_replica_volumes\" if it is used for replication classification only?","commit_id":"3010829895c8717b76099694c9cf0dcc07b6f479"},{"author":{"_account_id":22583,"name":"Cheng Yong Zhao","email":"zhaochy@cn.ibm.com","username":"zhaochy"},"change_message_id":"9cb1a3ce5a7c047f28eebae79dcd9292dab47d8f","unresolved":false,"context_lines":[{"line_number":3002,"context_line":"        return volumes_update"},{"line_number":3003,"context_line":""},{"line_number":3004,"context_line":"    def _classify_volume(self, ctxt, volumes):"},{"line_number":3005,"context_line":"        normal_volumes \u003d []"},{"line_number":3006,"context_line":"        replica_volumes \u003d []"},{"line_number":3007,"context_line":""},{"line_number":3008,"context_line":"        for v in volumes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_ee65a944","line":3005,"updated":"2017-02-27 02:20:45.000000000","message":"How about \"normal_volumes\" to \"unrep_volumes\"?","commit_id":"3010829895c8717b76099694c9cf0dcc07b6f479"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"552f152186ff57ecdd09dc0796e9792c31c46df8","unresolved":false,"context_lines":[{"line_number":3002,"context_line":"        return volumes_update"},{"line_number":3003,"context_line":""},{"line_number":3004,"context_line":"    def _classify_volume(self, ctxt, volumes):"},{"line_number":3005,"context_line":"        normal_volumes \u003d []"},{"line_number":3006,"context_line":"        replica_volumes \u003d []"},{"line_number":3007,"context_line":""},{"line_number":3008,"context_line":"        for v in volumes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_3a28db99","line":3005,"in_reply_to":"da36d5c6_ee65a944","updated":"2017-02-27 07:28:26.000000000","message":"Hi chenyong thanks a lot for your comments. I will update it if there are more incoming comments.","commit_id":"3010829895c8717b76099694c9cf0dcc07b6f479"}]}