)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ed69d2a6b0958d26954453f06e54c0fa7d1913f8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei driver supports front-end qos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There\u0027s a parameter in QoS specs named \"consumer\" and it\u0027s default value is"},{"line_number":10,"context_line":"\u0027back-end\u0027.When \"consumer\" is set to \u0027front-end\u0027/\u0027back-end\u0027, it should create"},{"line_number":11,"context_line":"a front-end/back-end QoS."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Now Huawei Driver doesn\u0027t consider the \"consumer\" parameter, fix it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba2be162_87df0b0c","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":12},"updated":"2017-03-03 03:17:00.000000000","message":"Missing space here.","commit_id":"1b0de0b40544fb59b793bf091328647fafd330e9"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"d92523b64e2c1382ea0cd7ffd4b3049482a34ad3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei driver supports front-end qos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There\u0027s a parameter in QoS specs named \"consumer\" and it\u0027s default value is"},{"line_number":10,"context_line":"\u0027back-end\u0027.When \"consumer\" is set to \u0027front-end\u0027/\u0027back-end\u0027, it should create"},{"line_number":11,"context_line":"a front-end/back-end QoS."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Now Huawei Driver doesn\u0027t consider the \"consumer\" parameter, fix it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba2be162_87654b1f","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":12},"in_reply_to":"ba2be162_87df0b0c","updated":"2017-03-03 03:31:02.000000000","message":"Done","commit_id":"1b0de0b40544fb59b793bf091328647fafd330e9"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"12b7083f54b849457d1d8eb1ae3d6e42ab5aa3e5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei driver supports front-end qos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There\u0027s a parameter in QoS specs named \"consumer\" and it\u0027s default value is"},{"line_number":10,"context_line":"\u0027back-end\u0027. When \"consumer\" is set to \u0027front-end\u0027/\u0027back-end\u0027, it should create"},{"line_number":11,"context_line":"a front-end/back-end QoS."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Now Huawei Driver doesn\u0027t consider the \"consumer\" parameter, fix it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba2be162_ea7fae63","line":10,"range":{"start_line":9,"start_character":73,"end_line":10,"end_character":78},"updated":"2017-03-03 03:46:48.000000000","message":"These two lines exceed the max legnth","commit_id":"8585d5c302527bbf95eb139a10978958864ed391"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"ac9c114d90963deec3312bd04b8ac869633ac771","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei driver supports front-end qos"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There\u0027s a parameter in QoS specs named \"consumer\" and it\u0027s default value is"},{"line_number":10,"context_line":"\u0027back-end\u0027. When \"consumer\" is set to \u0027front-end\u0027/\u0027back-end\u0027, it should create"},{"line_number":11,"context_line":"a front-end/back-end QoS."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Now Huawei Driver doesn\u0027t consider the \"consumer\" parameter, fix it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba2be162_2a5e2644","line":10,"range":{"start_line":9,"start_character":73,"end_line":10,"end_character":78},"in_reply_to":"ba2be162_ea7fae63","updated":"2017-03-03 04:13:45.000000000","message":"Done","commit_id":"8585d5c302527bbf95eb139a10978958864ed391"}],"cinder/volume/drivers/huawei/smartx.py":[{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"be2807c5cda62886ffb2ee5b9d3c35eae0916816","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":48,"context_line":"        consumer \u003d qos_specs.get_qos_specs(ctxt, qos_specs_id)[\u0027consumer\u0027]"},{"line_number":49,"context_line":"        if consumer \u003d\u003d \u0027front-end\u0027:"},{"line_number":50,"context_line":"            return"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        kvs \u003d qos_specs.get_qos_specs(ctxt, qos_specs_id)[\u0027specs\u0027]"},{"line_number":53,"context_line":"        LOG.info(_LI(\u0027The QoS sepcs is: %s.\u0027), kvs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_a247eb1b","line":50,"updated":"2017-03-08 09:03:21.000000000","message":"I see the return statement above return {},\nwhy here return None?","commit_id":"7f8ca38810df39df0f7de73f72d93a968ccd5087"},{"author":{"_account_id":17742,"name":"liucheng","email":"liucheng20@huawei.com","username":"liucheng"},"change_message_id":"16b678beb21679edf26ef5bd3534ab52a6e50b9b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        lun_list \u003d self.client.get_lun_list_in_qos(qos_id, qos_info)"},{"line_number":132,"context_line":"        if len(lun_list) \u003c\u003d 1:"},{"line_number":133,"context_line":"            qos_status \u003d qos_info[\u0027RUNNINGSTATUS\u0027]"},{"line_number":134,"context_line":"            # 2: Active status."},{"line_number":135,"context_line":"            if qos_status !\u003d constants.STATUS_QOS_INACTIVE:"},{"line_number":136,"context_line":"                self.client.activate_deactivate_qos(qos_id, False)"},{"line_number":137,"context_line":"            self.client.delete_qos_policy(qos_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_c7823194","line":134,"range":{"start_line":134,"start_character":11,"end_line":134,"end_character":30},"updated":"2017-03-08 08:52:14.000000000","message":"2? where is the first step?","commit_id":"7f8ca38810df39df0f7de73f72d93a968ccd5087"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"fd8ddd0393d6ccf241b9df6ff132179bc0ab669c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        lun_list \u003d self.client.get_lun_list_in_qos(qos_id, qos_info)"},{"line_number":132,"context_line":"        if len(lun_list) \u003c\u003d 1:"},{"line_number":133,"context_line":"            qos_status \u003d qos_info[\u0027RUNNINGSTATUS\u0027]"},{"line_number":134,"context_line":"            # 2: Active status."},{"line_number":135,"context_line":"            if qos_status !\u003d constants.STATUS_QOS_INACTIVE:"},{"line_number":136,"context_line":"                self.client.activate_deactivate_qos(qos_id, False)"},{"line_number":137,"context_line":"            self.client.delete_qos_policy(qos_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_426f0fc5","line":134,"range":{"start_line":134,"start_character":11,"end_line":134,"end_character":30},"in_reply_to":"9a30ddce_c7823194","updated":"2017-03-08 08:56:33.000000000","message":"\u00272\u0027 is QoS active status. It\u0027s not step. Thanks.","commit_id":"7f8ca38810df39df0f7de73f72d93a968ccd5087"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ee85ea03c6714d1b174311cd4d42158013d13d03","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":48,"context_line":"        consumer \u003d qos_specs.get_qos_specs(ctxt, qos_specs_id)[\u0027consumer\u0027]"},{"line_number":49,"context_line":"        if consumer \u003d\u003d \u0027front-end\u0027:"},{"line_number":50,"context_line":"            return"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        kvs \u003d qos_specs.get_qos_specs(ctxt, qos_specs_id)[\u0027specs\u0027]"},{"line_number":53,"context_line":"        LOG.info(\u0027The QoS sepcs is: %s.\u0027, kvs)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_11db5050","line":50,"updated":"2017-03-21 20:38:00.000000000","message":"Shouldn\u0027t this return {} like the other cases above, rather than None?","commit_id":"3c5b463c1970f87b282698a2e8aeff7f25fce556"}]}
