)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4c21d4d9f4f2c48c62d14805957043bdacb498a5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2017-02-28 15:50:32 -0500"},{"line_number":4,"context_line":"Commit:     Eric Young \u003ceric@aceshome.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-01 13:45:23 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixing pep warnings spotted by PyCharm and tox, including:"},{"line_number":8,"context_line":"- method signatures to match base class methods"},{"line_number":9,"context_line":"- implementing all abstract methods"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba2be162_97605c37","line":6,"updated":"2017-03-02 04:15:15.000000000","message":"Please add a title to briefly describe what this commit is about and limit it to 50 characters.","commit_id":"7a91a89f136180ac5353b0910f2a5f139182cdc5"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"96a1236d219fda6589e2fb988a4f7d77718f9014","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2017-02-28 15:50:32 -0500"},{"line_number":4,"context_line":"Commit:     Eric Young \u003ceric@aceshome.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-01 13:45:23 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixing pep warnings spotted by PyCharm and tox, including:"},{"line_number":8,"context_line":"- method signatures to match base class methods"},{"line_number":9,"context_line":"- implementing all abstract methods"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba2be162_272cc6aa","line":6,"in_reply_to":"ba2be162_97605c37","updated":"2017-03-02 13:32:14.000000000","message":"Done","commit_id":"7a91a89f136180ac5353b0910f2a5f139182cdc5"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4285ca31f9878ec164fef33ba0b18397cc704fd6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-03-01 13:45:23 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixing pep warnings spotted by PyCharm and tox, including:"},{"line_number":8,"context_line":"- method signatures to match base class methods"},{"line_number":9,"context_line":"- implementing all abstract methods"},{"line_number":10,"context_line":"- line length issues"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Responding to review comments (removing PyCharm specifics"},{"line_number":13,"context_line":"and adding newline in dict)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba2be162_4da3c64f","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":20},"updated":"2017-03-01 21:06:12.000000000","message":"There should be a space before this section.\n\nYou are also not documenting all the changes you are making.","commit_id":"7a91a89f136180ac5353b0910f2a5f139182cdc5"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"96a1236d219fda6589e2fb988a4f7d77718f9014","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-03-01 13:45:23 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixing pep warnings spotted by PyCharm and tox, including:"},{"line_number":8,"context_line":"- method signatures to match base class methods"},{"line_number":9,"context_line":"- implementing all abstract methods"},{"line_number":10,"context_line":"- line length issues"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Responding to review comments (removing PyCharm specifics"},{"line_number":13,"context_line":"and adding newline in dict)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba2be162_47329a11","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":20},"in_reply_to":"ba2be162_4da3c64f","updated":"2017-03-02 13:32:14.000000000","message":"Done","commit_id":"7a91a89f136180ac5353b0910f2a5f139182cdc5"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4285ca31f9878ec164fef33ba0b18397cc704fd6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- implementing all abstract methods"},{"line_number":10,"context_line":"- line length issues"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Responding to review comments (removing PyCharm specifics"},{"line_number":13,"context_line":"and adding newline in dict)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I28cdbc0bf4814330d1c28998a925ee45ca269dc5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba2be162_6ddc0ae5","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":27},"updated":"2017-03-01 21:06:12.000000000","message":"Do not include this in the commit message.  Not necessary.","commit_id":"7a91a89f136180ac5353b0910f2a5f139182cdc5"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"96a1236d219fda6589e2fb988a4f7d77718f9014","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- implementing all abstract methods"},{"line_number":10,"context_line":"- line length issues"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Responding to review comments (removing PyCharm specifics"},{"line_number":13,"context_line":"and adding newline in dict)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I28cdbc0bf4814330d1c28998a925ee45ca269dc5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba2be162_e721ceb5","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":27},"in_reply_to":"ba2be162_6ddc0ae5","updated":"2017-03-02 13:32:14.000000000","message":"Done","commit_id":"7a91a89f136180ac5353b0910f2a5f139182cdc5"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b36d27e910d7127b33406f582f14c6299eeca200","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eric Young \u003ceric@aceshome.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-02 08:24:01 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixing warnings spotted by PyCharm and tox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes include:"},{"line_number":10,"context_line":"- ensuring method signatures match base class methods"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba2be162_12168955","line":7,"updated":"2017-03-06 19:14:27.000000000","message":"Please, change commit message to add driver name which code is changes","commit_id":"868a4ce188b1f2c88e00aa51959d07796aeb0709"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b7e03241803382651b3bf70ae604840fba618dfb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eric Young \u003ceric@aceshome.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-02 08:24:01 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixing warnings spotted by PyCharm and tox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes include:"},{"line_number":10,"context_line":"- ensuring method signatures match base class methods"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a30ddce_2a8aedbf","line":7,"in_reply_to":"ba2be162_12168955","updated":"2017-03-08 11:56:23.000000000","message":"+1","commit_id":"868a4ce188b1f2c88e00aa51959d07796aeb0709"}],"cinder/volume/drivers/dell_emc/scaleio/driver.py":[{"author":{"_account_id":23276,"name":"Nicholas Jones","email":"nj762h@att.com","username":"nj762h"},"change_message_id":"8b09fca89c942277b156ba4188b1b358d9b5c093","unresolved":false,"context_lines":[{"line_number":107,"context_line":"SIO_MAX_OVERSUBSCRIPTION_RATIO \u003d 10.0"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# noinspection PyShadowingBuiltins,PyShadowingNames"},{"line_number":111,"context_line":"# noinspection PyShadowingNames,PyShadowingNames"},{"line_number":112,"context_line":"@interface.volumedriver"},{"line_number":113,"context_line":"class ScaleIODriver(driver.VolumeDriver):"},{"line_number":114,"context_line":"    \"\"\"Dell EMC ScaleIO Driver.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_76e227d7","line":111,"range":{"start_line":110,"start_character":0,"end_line":111,"end_character":48},"updated":"2017-03-01 15:35:46.000000000","message":"Correct me if I\u0027m wrong, but this is PyCharm specific correct? IMO, we shouldn\u0027t be committing IDE fixes.","commit_id":"4f5b82a7e2318e6df1aa3395c91898779c637afc"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"55359886adc09ff78df749a4799112e7d2f45cac","unresolved":false,"context_lines":[{"line_number":107,"context_line":"SIO_MAX_OVERSUBSCRIPTION_RATIO \u003d 10.0"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"# noinspection PyShadowingBuiltins,PyShadowingNames"},{"line_number":111,"context_line":"# noinspection PyShadowingNames,PyShadowingNames"},{"line_number":112,"context_line":"@interface.volumedriver"},{"line_number":113,"context_line":"class ScaleIODriver(driver.VolumeDriver):"},{"line_number":114,"context_line":"    \"\"\"Dell EMC ScaleIO Driver.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_04352ef6","line":111,"range":{"start_line":110,"start_character":0,"end_line":111,"end_character":48},"in_reply_to":"ba2be162_76e227d7","updated":"2017-03-01 18:55:10.000000000","message":"fixed","commit_id":"4f5b82a7e2318e6df1aa3395c91898779c637afc"},{"author":{"_account_id":23276,"name":"Nicholas Jones","email":"nj762h@att.com","username":"nj762h"},"change_message_id":"8b09fca89c942277b156ba4188b1b358d9b5c093","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            \u0027serverUsername\u0027: self.server_username,"},{"line_number":195,"context_line":"            \u0027serverPassword\u0027: self.server_password,"},{"line_number":196,"context_line":"            \u0027serverToken\u0027: self.server_token,"},{"line_number":197,"context_line":"            \u0027iopsLimit\u0027: None, \u0027bandwidthLimit\u0027: None"},{"line_number":198,"context_line":"        }"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_5604437d","line":197,"range":{"start_line":197,"start_character":31,"end_line":197,"end_character":53},"updated":"2017-03-01 15:35:46.000000000","message":"newline","commit_id":"4f5b82a7e2318e6df1aa3395c91898779c637afc"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"55359886adc09ff78df749a4799112e7d2f45cac","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            \u0027serverUsername\u0027: self.server_username,"},{"line_number":195,"context_line":"            \u0027serverPassword\u0027: self.server_password,"},{"line_number":196,"context_line":"            \u0027serverToken\u0027: self.server_token,"},{"line_number":197,"context_line":"            \u0027iopsLimit\u0027: None, \u0027bandwidthLimit\u0027: None"},{"line_number":198,"context_line":"        }"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_a430e202","line":197,"range":{"start_line":197,"start_character":31,"end_line":197,"end_character":53},"in_reply_to":"ba2be162_5604437d","updated":"2017-03-01 18:55:10.000000000","message":"thanks for catching","commit_id":"4f5b82a7e2318e6df1aa3395c91898779c637afc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4c21d4d9f4f2c48c62d14805957043bdacb498a5","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            \u0027serverPassword\u0027: self.server_password,"},{"line_number":194,"context_line":"            \u0027serverToken\u0027: self.server_token,"},{"line_number":195,"context_line":"            \u0027iopsLimit\u0027: None, "},{"line_number":196,"context_line":"            \u0027bandwidthLimit\u0027: None"},{"line_number":197,"context_line":"        }"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_77e1289a","line":196,"updated":"2017-03-02 04:15:15.000000000","message":"Add an ending comma","commit_id":"7a91a89f136180ac5353b0910f2a5f139182cdc5"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"96a1236d219fda6589e2fb988a4f7d77718f9014","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            \u0027serverPassword\u0027: self.server_password,"},{"line_number":194,"context_line":"            \u0027serverToken\u0027: self.server_token,"},{"line_number":195,"context_line":"            \u0027iopsLimit\u0027: None, "},{"line_number":196,"context_line":"            \u0027bandwidthLimit\u0027: None"},{"line_number":197,"context_line":"        }"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_c70daa3f","line":196,"in_reply_to":"ba2be162_77e1289a","updated":"2017-03-02 13:32:14.000000000","message":"Done","commit_id":"7a91a89f136180ac5353b0910f2a5f139182cdc5"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4285ca31f9878ec164fef33ba0b18397cc704fd6","unresolved":false,"context_lines":[{"line_number":1430,"context_line":"    def check_for_export(self, context, volume_id):"},{"line_number":1431,"context_line":"        \"\"\"Make sure volume is exported.\"\"\""},{"line_number":1432,"context_line":"        pass"},{"line_number":1433,"context_line":""},{"line_number":1434,"context_line":"    def create_group_snapshot(self, context, group_snapshot, snapshots):"},{"line_number":1435,"context_line":"        pass"},{"line_number":1436,"context_line":""},{"line_number":1437,"context_line":"    def create_group(self, context, group):"},{"line_number":1438,"context_line":"        pass"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    def failover_host(self, context, volumes, secondary_id\u003dNone):"},{"line_number":1441,"context_line":"        pass"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":"    def get_replication_updates(self, context):"},{"line_number":1444,"context_line":"        pass"},{"line_number":1445,"context_line":""},{"line_number":1446,"context_line":"    def failover_completed(self, context, active_backend_id\u003dNone):"},{"line_number":1447,"context_line":"        pass"},{"line_number":1448,"context_line":""},{"line_number":1449,"context_line":"    def create_group_from_src(self, context, group, volumes,"},{"line_number":1450,"context_line":"                              group_snapshot\u003dNone,"},{"line_number":1451,"context_line":"                              snapshots\u003dNone, source_group\u003dNone,"},{"line_number":1452,"context_line":"                              source_vols\u003dNone):"},{"line_number":1453,"context_line":"        pass"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"    def create_export_snapshot(self, context, snapshot, connector):"},{"line_number":1456,"context_line":"        pass"},{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"    def get_manageable_snapshots(self, cinder_snapshots, marker, limit,"},{"line_number":1459,"context_line":"                                 offset, sort_keys, sort_dirs):"},{"line_number":1460,"context_line":"        pass"},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"    def local_path(self, volume):"},{"line_number":1463,"context_line":"        pass"},{"line_number":1464,"context_line":""},{"line_number":1465,"context_line":"    def delete_group(self, context, group, volumes):"},{"line_number":1466,"context_line":"        pass"},{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"    def remove_export_snapshot(self, context, snapshot):"},{"line_number":1469,"context_line":"        pass"},{"line_number":1470,"context_line":""},{"line_number":1471,"context_line":"    def get_manageable_volumes(self, cinder_volumes, marker, limit,"},{"line_number":1472,"context_line":"                               offset, sort_keys, sort_dirs):"},{"line_number":1473,"context_line":"        pass"},{"line_number":1474,"context_line":""},{"line_number":1475,"context_line":"    def update_group(self, context, group, add_volumes\u003dNone,"},{"line_number":1476,"context_line":"                     remove_volumes\u003dNone):"},{"line_number":1477,"context_line":"        pass"},{"line_number":1478,"context_line":""},{"line_number":1479,"context_line":"    def delete_group_snapshot(self, context, group_snapshot, snapshots):"},{"line_number":1480,"context_line":"        pass"},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"    def create_replica_test_volume(self, volume, src_vref):"},{"line_number":1483,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_ad78c2f3","line":1483,"range":{"start_line":1433,"start_character":0,"end_line":1483,"end_character":12},"updated":"2017-03-01 21:06:12.000000000","message":"We do not want these here.  Should only have functions that are implemented in your driver.","commit_id":"7a91a89f136180ac5353b0910f2a5f139182cdc5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4c21d4d9f4f2c48c62d14805957043bdacb498a5","unresolved":false,"context_lines":[{"line_number":1430,"context_line":"    def check_for_export(self, context, volume_id):"},{"line_number":1431,"context_line":"        \"\"\"Make sure volume is exported.\"\"\""},{"line_number":1432,"context_line":"        pass"},{"line_number":1433,"context_line":""},{"line_number":1434,"context_line":"    def create_group_snapshot(self, context, group_snapshot, snapshots):"},{"line_number":1435,"context_line":"        pass"},{"line_number":1436,"context_line":""},{"line_number":1437,"context_line":"    def create_group(self, context, group):"},{"line_number":1438,"context_line":"        pass"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    def failover_host(self, context, volumes, secondary_id\u003dNone):"},{"line_number":1441,"context_line":"        pass"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":"    def get_replication_updates(self, context):"},{"line_number":1444,"context_line":"        pass"},{"line_number":1445,"context_line":""},{"line_number":1446,"context_line":"    def failover_completed(self, context, active_backend_id\u003dNone):"},{"line_number":1447,"context_line":"        pass"},{"line_number":1448,"context_line":""},{"line_number":1449,"context_line":"    def create_group_from_src(self, context, group, volumes,"},{"line_number":1450,"context_line":"                              group_snapshot\u003dNone,"},{"line_number":1451,"context_line":"                              snapshots\u003dNone, source_group\u003dNone,"},{"line_number":1452,"context_line":"                              source_vols\u003dNone):"},{"line_number":1453,"context_line":"        pass"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"    def create_export_snapshot(self, context, snapshot, connector):"},{"line_number":1456,"context_line":"        pass"},{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"    def get_manageable_snapshots(self, cinder_snapshots, marker, limit,"},{"line_number":1459,"context_line":"                                 offset, sort_keys, sort_dirs):"},{"line_number":1460,"context_line":"        pass"},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"    def local_path(self, volume):"},{"line_number":1463,"context_line":"        pass"},{"line_number":1464,"context_line":""},{"line_number":1465,"context_line":"    def delete_group(self, context, group, volumes):"},{"line_number":1466,"context_line":"        pass"},{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"    def remove_export_snapshot(self, context, snapshot):"},{"line_number":1469,"context_line":"        pass"},{"line_number":1470,"context_line":""},{"line_number":1471,"context_line":"    def get_manageable_volumes(self, cinder_volumes, marker, limit,"},{"line_number":1472,"context_line":"                               offset, sort_keys, sort_dirs):"},{"line_number":1473,"context_line":"        pass"},{"line_number":1474,"context_line":""},{"line_number":1475,"context_line":"    def update_group(self, context, group, add_volumes\u003dNone,"},{"line_number":1476,"context_line":"                     remove_volumes\u003dNone):"},{"line_number":1477,"context_line":"        pass"},{"line_number":1478,"context_line":""},{"line_number":1479,"context_line":"    def delete_group_snapshot(self, context, group_snapshot, snapshots):"},{"line_number":1480,"context_line":"        pass"},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"    def create_replica_test_volume(self, volume, src_vref):"},{"line_number":1483,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_f747d874","line":1483,"range":{"start_line":1433,"start_character":0,"end_line":1483,"end_character":12},"in_reply_to":"ba2be162_ad78c2f3","updated":"2017-03-02 04:15:15.000000000","message":"+1","commit_id":"7a91a89f136180ac5353b0910f2a5f139182cdc5"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"96a1236d219fda6589e2fb988a4f7d77718f9014","unresolved":false,"context_lines":[{"line_number":1430,"context_line":"    def check_for_export(self, context, volume_id):"},{"line_number":1431,"context_line":"        \"\"\"Make sure volume is exported.\"\"\""},{"line_number":1432,"context_line":"        pass"},{"line_number":1433,"context_line":""},{"line_number":1434,"context_line":"    def create_group_snapshot(self, context, group_snapshot, snapshots):"},{"line_number":1435,"context_line":"        pass"},{"line_number":1436,"context_line":""},{"line_number":1437,"context_line":"    def create_group(self, context, group):"},{"line_number":1438,"context_line":"        pass"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    def failover_host(self, context, volumes, secondary_id\u003dNone):"},{"line_number":1441,"context_line":"        pass"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":"    def get_replication_updates(self, context):"},{"line_number":1444,"context_line":"        pass"},{"line_number":1445,"context_line":""},{"line_number":1446,"context_line":"    def failover_completed(self, context, active_backend_id\u003dNone):"},{"line_number":1447,"context_line":"        pass"},{"line_number":1448,"context_line":""},{"line_number":1449,"context_line":"    def create_group_from_src(self, context, group, volumes,"},{"line_number":1450,"context_line":"                              group_snapshot\u003dNone,"},{"line_number":1451,"context_line":"                              snapshots\u003dNone, source_group\u003dNone,"},{"line_number":1452,"context_line":"                              source_vols\u003dNone):"},{"line_number":1453,"context_line":"        pass"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"    def create_export_snapshot(self, context, snapshot, connector):"},{"line_number":1456,"context_line":"        pass"},{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"    def get_manageable_snapshots(self, cinder_snapshots, marker, limit,"},{"line_number":1459,"context_line":"                                 offset, sort_keys, sort_dirs):"},{"line_number":1460,"context_line":"        pass"},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"    def local_path(self, volume):"},{"line_number":1463,"context_line":"        pass"},{"line_number":1464,"context_line":""},{"line_number":1465,"context_line":"    def delete_group(self, context, group, volumes):"},{"line_number":1466,"context_line":"        pass"},{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"    def remove_export_snapshot(self, context, snapshot):"},{"line_number":1469,"context_line":"        pass"},{"line_number":1470,"context_line":""},{"line_number":1471,"context_line":"    def get_manageable_volumes(self, cinder_volumes, marker, limit,"},{"line_number":1472,"context_line":"                               offset, sort_keys, sort_dirs):"},{"line_number":1473,"context_line":"        pass"},{"line_number":1474,"context_line":""},{"line_number":1475,"context_line":"    def update_group(self, context, group, add_volumes\u003dNone,"},{"line_number":1476,"context_line":"                     remove_volumes\u003dNone):"},{"line_number":1477,"context_line":"        pass"},{"line_number":1478,"context_line":""},{"line_number":1479,"context_line":"    def delete_group_snapshot(self, context, group_snapshot, snapshots):"},{"line_number":1480,"context_line":"        pass"},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"    def create_replica_test_volume(self, volume, src_vref):"},{"line_number":1483,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_d20f262c","line":1483,"range":{"start_line":1433,"start_character":0,"end_line":1483,"end_character":12},"in_reply_to":"ba2be162_ad78c2f3","updated":"2017-03-02 13:32:14.000000000","message":"Done","commit_id":"7a91a89f136180ac5353b0910f2a5f139182cdc5"},{"author":{"_account_id":25033,"name":"Eric Young","email":"eric.young@dell.com","username":"tssgery"},"change_message_id":"96a1236d219fda6589e2fb988a4f7d77718f9014","unresolved":false,"context_lines":[{"line_number":1430,"context_line":"    def check_for_export(self, context, volume_id):"},{"line_number":1431,"context_line":"        \"\"\"Make sure volume is exported.\"\"\""},{"line_number":1432,"context_line":"        pass"},{"line_number":1433,"context_line":""},{"line_number":1434,"context_line":"    def create_group_snapshot(self, context, group_snapshot, snapshots):"},{"line_number":1435,"context_line":"        pass"},{"line_number":1436,"context_line":""},{"line_number":1437,"context_line":"    def create_group(self, context, group):"},{"line_number":1438,"context_line":"        pass"},{"line_number":1439,"context_line":""},{"line_number":1440,"context_line":"    def failover_host(self, context, volumes, secondary_id\u003dNone):"},{"line_number":1441,"context_line":"        pass"},{"line_number":1442,"context_line":""},{"line_number":1443,"context_line":"    def get_replication_updates(self, context):"},{"line_number":1444,"context_line":"        pass"},{"line_number":1445,"context_line":""},{"line_number":1446,"context_line":"    def failover_completed(self, context, active_backend_id\u003dNone):"},{"line_number":1447,"context_line":"        pass"},{"line_number":1448,"context_line":""},{"line_number":1449,"context_line":"    def create_group_from_src(self, context, group, volumes,"},{"line_number":1450,"context_line":"                              group_snapshot\u003dNone,"},{"line_number":1451,"context_line":"                              snapshots\u003dNone, source_group\u003dNone,"},{"line_number":1452,"context_line":"                              source_vols\u003dNone):"},{"line_number":1453,"context_line":"        pass"},{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"    def create_export_snapshot(self, context, snapshot, connector):"},{"line_number":1456,"context_line":"        pass"},{"line_number":1457,"context_line":""},{"line_number":1458,"context_line":"    def get_manageable_snapshots(self, cinder_snapshots, marker, limit,"},{"line_number":1459,"context_line":"                                 offset, sort_keys, sort_dirs):"},{"line_number":1460,"context_line":"        pass"},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"    def local_path(self, volume):"},{"line_number":1463,"context_line":"        pass"},{"line_number":1464,"context_line":""},{"line_number":1465,"context_line":"    def delete_group(self, context, group, volumes):"},{"line_number":1466,"context_line":"        pass"},{"line_number":1467,"context_line":""},{"line_number":1468,"context_line":"    def remove_export_snapshot(self, context, snapshot):"},{"line_number":1469,"context_line":"        pass"},{"line_number":1470,"context_line":""},{"line_number":1471,"context_line":"    def get_manageable_volumes(self, cinder_volumes, marker, limit,"},{"line_number":1472,"context_line":"                               offset, sort_keys, sort_dirs):"},{"line_number":1473,"context_line":"        pass"},{"line_number":1474,"context_line":""},{"line_number":1475,"context_line":"    def update_group(self, context, group, add_volumes\u003dNone,"},{"line_number":1476,"context_line":"                     remove_volumes\u003dNone):"},{"line_number":1477,"context_line":"        pass"},{"line_number":1478,"context_line":""},{"line_number":1479,"context_line":"    def delete_group_snapshot(self, context, group_snapshot, snapshots):"},{"line_number":1480,"context_line":"        pass"},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"    def create_replica_test_volume(self, volume, src_vref):"},{"line_number":1483,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_720afa22","line":1483,"range":{"start_line":1433,"start_character":0,"end_line":1483,"end_character":12},"in_reply_to":"ba2be162_f747d874","updated":"2017-03-02 13:32:14.000000000","message":"Done","commit_id":"7a91a89f136180ac5353b0910f2a5f139182cdc5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b7e03241803382651b3bf70ae604840fba618dfb","unresolved":false,"context_lines":[{"line_number":753,"context_line":"        \"\"\""},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        LOG.debug(\"Connector is %s.\", connector)"},{"line_number":756,"context_line":"        connection_properties \u003d self.connection_properties"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        volname \u003d self._id_to_base64(volume.id)"},{"line_number":759,"context_line":"        connection_properties[\u0027scaleIO_volname\u0027] \u003d volname"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_f538b63f","line":756,"updated":"2017-03-08 11:56:23.000000000","message":"-1: This is most likely wrong, since original code was the same as doing\n\n connection_properties \u003d self.connection_properties.copy()\n\nAnd with your change you are effectively modifying the instances connection_properties on L759, L760, L772, L773, and that will affect all future calls.\n\nNot to mention that you\u0027ll have concurrency issues since that global value could be changed in the middle of this method by other thread.","commit_id":"868a4ce188b1f2c88e00aa51959d07796aeb0709"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b7e03241803382651b3bf70ae604840fba618dfb","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"    def _sio_attach_volume(self, volume):"},{"line_number":1038,"context_line":"        \"\"\"Call connector.connect_volume() and return the path. \"\"\""},{"line_number":1039,"context_line":"        LOG.debug(\"Calling os-brick to attach ScaleIO volume.\")"},{"line_number":1040,"context_line":"        connection_properties \u003d self.connection_properties"},{"line_number":1041,"context_line":"        connection_properties[\u0027scaleIO_volname\u0027] \u003d self._id_to_base64("},{"line_number":1042,"context_line":"            volume.id)"},{"line_number":1043,"context_line":"        connection_properties[\u0027scaleIO_volume_id\u0027] \u003d volume.provider_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_554a62c6","line":1040,"updated":"2017-03-08 11:56:23.000000000","message":"-1: ditto","commit_id":"868a4ce188b1f2c88e00aa51959d07796aeb0709"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b7e03241803382651b3bf70ae604840fba618dfb","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"    def _sio_detach_volume(self, volume):"},{"line_number":1048,"context_line":"        \"\"\"Call the connector.disconnect() \"\"\""},{"line_number":1049,"context_line":"        LOG.info(_LI(\"Calling os-brick to detach ScaleIO volume.\"))"},{"line_number":1050,"context_line":"        connection_properties \u003d self.connection_properties"},{"line_number":1051,"context_line":"        connection_properties[\u0027scaleIO_volname\u0027] \u003d self._id_to_base64("},{"line_number":1052,"context_line":"            volume.id)"},{"line_number":1053,"context_line":"        connection_properties[\u0027scaleIO_volume_id\u0027] \u003d volume.provider_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_b5155e9c","line":1050,"updated":"2017-03-08 11:56:23.000000000","message":"-1: ditto","commit_id":"868a4ce188b1f2c88e00aa51959d07796aeb0709"}]}