)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"a0bf5071a85cced13522a728b5f0c281bc11a547","unresolved":false,"context_lines":[{"line_number":12,"context_line":"recently in oslo.messaging."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch reverts the optimization in rpc.init(). This means just an"},{"line_number":15,"context_line":"one time preformance loss at the start of each service as every subsequent"},{"line_number":16,"context_line":"get_notifier call is already skipped with by if_notifications_enabled"},{"line_number":17,"context_line":"decorator if the notifications are not enabled. This was necessary"},{"line_number":18,"context_line":"as we need a Notifier object first to be able to decide if the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ff0f0b1f_e6a9a324","line":15,"range":{"start_line":15,"start_character":65,"end_line":15,"end_character":74},"updated":"2017-05-26 00:29:26.000000000","message":"Lines should technically be wrapped at 72 characters.","commit_id":"2e0cf45b35a0b63fd6c9de81c303eca1988add18"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f19398e7653f22d521a4e41029cc3bc29b3b34a4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"recently in oslo.messaging."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch reverts the optimization in rpc.init(). This means just an"},{"line_number":15,"context_line":"one time preformance loss at the start of each service as every subsequent"},{"line_number":16,"context_line":"get_notifier call is already skipped with by if_notifications_enabled"},{"line_number":17,"context_line":"decorator if the notifications are not enabled. This was necessary"},{"line_number":18,"context_line":"as we need a Notifier object first to be able to decide if the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7f287b81_a3757afc","line":15,"range":{"start_line":15,"start_character":65,"end_line":15,"end_character":74},"in_reply_to":"ff0f0b1f_e6a9a324","updated":"2017-09-05 12:22:54.000000000","message":"Done","commit_id":"2e0cf45b35a0b63fd6c9de81c303eca1988add18"}],"cinder/rpc.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"261adb53803bef93eea37263676a91bfa6b1bbd8","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        conf,"},{"line_number":62,"context_line":"        allowed_remote_exmods\u003dexmods)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    json_serializer \u003d messaging.JsonPayloadSerializer()"},{"line_number":65,"context_line":"    serializer \u003d RequestContextSerializer(json_serializer)"},{"line_number":66,"context_line":"    NOTIFIER \u003d messaging.Notifier(NOTIFICATION_TRANSPORT,"},{"line_number":67,"context_line":"                                  serializer\u003dserializer)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f4e5783_ebc4c594","line":64,"updated":"2017-10-10 02:09:23.000000000","message":"So maybe I\u0027m just missing something here. The decorator checks if things are enabled, so if not it won\u0027t try to send anything. But with this change, we will still initialize classes that might not be needed. What is the advantage of removing the check here?","commit_id":"d23f8c67bf1ff4107db21bf87bad63e6862120bc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4b1b2ac0d3eb2248849b56f69047d5df0e62dbb0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        conf,"},{"line_number":62,"context_line":"        allowed_remote_exmods\u003dexmods)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    json_serializer \u003d messaging.JsonPayloadSerializer()"},{"line_number":65,"context_line":"    serializer \u003d RequestContextSerializer(json_serializer)"},{"line_number":66,"context_line":"    NOTIFIER \u003d messaging.Notifier(NOTIFICATION_TRANSPORT,"},{"line_number":67,"context_line":"                                  serializer\u003dserializer)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_6e0a7cd2","line":64,"in_reply_to":"5f4e5783_ebc4c594","updated":"2017-11-03 11:24:31.000000000","message":"If we want to use the oslo_messaging way to decide if a notifier is enabled then we have to first create a notifier. See https://review.openstack.org/#/c/442016/10/cinder/utils.py@1098\n\nSo while we here create a serializer and a NOTIFIER if the NOTIFIER is not enabled then these classes will not be used. This is a waste but seems to be a necessary waste right now. Please note that creating this class happens once in a service during the initialization of that service.","commit_id":"d23f8c67bf1ff4107db21bf87bad63e6862120bc"}]}