)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aeff5df1e2f26a073397e93d0b97c96f5cb01d7b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"related to the snapshot is set to backing-up during the action"},{"line_number":11,"context_line":"and can\u0027t be used for other actions."},{"line_number":12,"context_line":"When create a backup from a large snapshot, such as larger"},{"line_number":13,"context_line":"than 1 TB, It will costs few hours generally. It\u0027s really a"},{"line_number":14,"context_line":"problem that the volume is not available for such a long time."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"If the snapshot is provided, we change the status of the snapshot;"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a30ddce_833d96bd","line":13,"range":{"start_line":13,"start_character":19,"end_line":13,"end_character":24},"updated":"2017-03-08 02:15:58.000000000","message":"cost","commit_id":"d7dce6bcca0be5a10112a4fde9fc004c2fa8a5ed"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aeff5df1e2f26a073397e93d0b97c96f5cb01d7b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"related to the snapshot is set to backing-up during the action"},{"line_number":11,"context_line":"and can\u0027t be used for other actions."},{"line_number":12,"context_line":"When create a backup from a large snapshot, such as larger"},{"line_number":13,"context_line":"than 1 TB, It will costs few hours generally. It\u0027s really a"},{"line_number":14,"context_line":"problem that the volume is not available for such a long time."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"If the snapshot is provided, we change the status of the snapshot;"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a30ddce_435b9e2e","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":13},"updated":"2017-03-08 02:15:58.000000000","message":"it","commit_id":"d7dce6bcca0be5a10112a4fde9fc004c2fa8a5ed"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"129646d6bec137e902b7be3743b41750f938aa9b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"related to the snapshot is set to backing-up during the action"},{"line_number":11,"context_line":"and can\u0027t be used for other actions."},{"line_number":12,"context_line":"When create a backup from a large snapshot, such as larger"},{"line_number":13,"context_line":"than 1 TB, It will costs few hours generally. It\u0027s really a"},{"line_number":14,"context_line":"problem that the volume is not available for such a long time."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"If the snapshot is provided, we change the status of the snapshot;"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a30ddce_4e5c9eed","line":13,"range":{"start_line":13,"start_character":19,"end_line":13,"end_character":24},"in_reply_to":"9a30ddce_833d96bd","updated":"2017-03-08 06:29:13.000000000","message":"Done","commit_id":"d7dce6bcca0be5a10112a4fde9fc004c2fa8a5ed"}],"cinder/backup/api.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8ab3592c479a7a0acdc349473acf06cebfbf6718","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                         \u0027snapshot.volume_id %(vol2)s.\u0027)"},{"line_number":215,"context_line":"                       % {\u0027vol1\u0027: volume_id,"},{"line_number":216,"context_line":"                          \u0027vol2\u0027: snapshot.volume_id})"},{"line_number":217,"context_line":"                raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":218,"context_line":"        if volume[\u0027status\u0027] not in [\"available\", \"in-use\"]:"},{"line_number":219,"context_line":"            msg \u003d (_(\u0027Volume to be backed up must be available \u0027"},{"line_number":220,"context_line":"                     \u0027or in-use, but the current status is \"%s\".\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_29186d84","line":217,"updated":"2017-03-07 14:18:26.000000000","message":"Need to check whether the status of the snapshot is \u0027available\u0027 here before proceeding.","commit_id":"c8c57bea2fab29cd8b698931f6f8778523237730"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"ff26beb70a3e3ccad9fe8852e26cb95a311a8582","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                         \u0027snapshot.volume_id %(vol2)s.\u0027)"},{"line_number":215,"context_line":"                       % {\u0027vol1\u0027: volume_id,"},{"line_number":216,"context_line":"                          \u0027vol2\u0027: snapshot.volume_id})"},{"line_number":217,"context_line":"                raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":218,"context_line":"        if volume[\u0027status\u0027] not in [\"available\", \"in-use\"]:"},{"line_number":219,"context_line":"            msg \u003d (_(\u0027Volume to be backed up must be available \u0027"},{"line_number":220,"context_line":"                     \u0027or in-use, but the current status is \"%s\".\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_d2c75a10","line":217,"in_reply_to":"9a30ddce_29186d84","updated":"2017-03-08 01:57:28.000000000","message":"L227 has checked it.","commit_id":"c8c57bea2fab29cd8b698931f6f8778523237730"}],"cinder/backup/manager.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f003554f25bc03c6b0dfd1dadafed1103fe8c324","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            raise exception.InvalidVolume(reason\u003derr)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        if snapshot_id:"},{"line_number":388,"context_line":"            expected_status \u003d \u0027backing-up\u0027"},{"line_number":389,"context_line":"            actual_status \u003d snapshot[\u0027status\u0027]"},{"line_number":390,"context_line":"            if actual_status !\u003d expected_status:"},{"line_number":391,"context_line":"                err \u003d _(\u0027Create backup aborted, expected snapshot status \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a1ff146_cfcfc3ae","line":388,"updated":"2017-03-15 15:09:00.000000000","message":"Please, use SnapshotStatus enum [1] here and below\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/objects/fields.py#L117","commit_id":"e12af6af0b8df803e5b83127d9b3f7aea54e2995"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"399320f10b54269441910613c39bc6678d5638a4","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        backup.availability_zone \u003d self.az"},{"line_number":372,"context_line":"        backup.save()"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        expected_status \u003d \u0027available\u0027 if snapshot_id else \"backing-up\""},{"line_number":375,"context_line":"        actual_status \u003d volume[\u0027status\u0027]"},{"line_number":376,"context_line":"        if actual_status !\u003d expected_status:"},{"line_number":377,"context_line":"            err \u003d _(\u0027Create backup aborted, expected volume status \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_1e31c55a","line":374,"range":{"start_line":374,"start_character":1,"end_line":374,"end_character":70},"updated":"2017-03-29 03:39:49.000000000","message":"If the volume has been mounted to a server, the status of volume is \"in-use\", so the \"in-use\" also could be in expected_status.","commit_id":"d304f621c23c81580fbddaf61e61ef135558acd4"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"91e3aa1d4e57d08c567d764e3e4075a1b3c9cbdf","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        backup.availability_zone \u003d self.az"},{"line_number":372,"context_line":"        backup.save()"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        expected_status \u003d \u0027available\u0027 if snapshot_id else \"backing-up\""},{"line_number":375,"context_line":"        actual_status \u003d volume[\u0027status\u0027]"},{"line_number":376,"context_line":"        if actual_status !\u003d expected_status:"},{"line_number":377,"context_line":"            err \u003d _(\u0027Create backup aborted, expected volume status \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_518dfb2f","line":374,"range":{"start_line":374,"start_character":1,"end_line":374,"end_character":70},"in_reply_to":"ffe62b97_1e31c55a","updated":"2017-03-29 06:54:59.000000000","message":"Oh, it\u0027s mistake here. Please take a look at this:\nhttps://review.openstack.org/#/c/451211\n\nThanks.","commit_id":"d304f621c23c81580fbddaf61e61ef135558acd4"}],"cinder/objects/snapshot.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"f3c955deda8c34c8afe0a871a7f62130ca6eb985","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    # Version 1.1: Changed \u0027status\u0027 field to use SnapshotStatusField"},{"line_number":37,"context_line":"    # Version 1.2: This object is now cleanable (adds rows to workers table)"},{"line_number":38,"context_line":"    # Version 1.3: SnapshotStatusField now includes \"unmanaging\""},{"line_number":39,"context_line":"    # Version 1.3: SnapshotStatusField now includes \"backing-up\""},{"line_number":40,"context_line":"    VERSION \u003d \u00271.4\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # NOTE(thangp): OPTIONAL_FIELDS are fields that would be lazy-loaded. They"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_d9cf527d","line":39,"range":{"start_line":39,"start_character":14,"end_line":39,"end_character":18},"updated":"2017-03-09 01:13:20.000000000","message":"1.4","commit_id":"8c5775c1c690ca7ced594d9fd317a417952968ea"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"4eed62959b5472bde629ef76ca78810c2865351b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    # Version 1.1: Changed \u0027status\u0027 field to use SnapshotStatusField"},{"line_number":37,"context_line":"    # Version 1.2: This object is now cleanable (adds rows to workers table)"},{"line_number":38,"context_line":"    # Version 1.3: SnapshotStatusField now includes \"unmanaging\""},{"line_number":39,"context_line":"    # Version 1.3: SnapshotStatusField now includes \"backing-up\""},{"line_number":40,"context_line":"    VERSION \u003d \u00271.4\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # NOTE(thangp): OPTIONAL_FIELDS are fields that would be lazy-loaded. They"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_385fe373","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":17},"updated":"2017-03-17 01:45:04.000000000","message":"It\u0027s should be 1.4","commit_id":"7f2514880527c249eda53f1697a5ab28af23bc2f"}],"cinder/tests/unit/backup/test_backup.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"aeff5df1e2f26a073397e93d0b97c96f5cb01d7b","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        self.assertEqual(vol_size, backup[\u0027size\u0027])"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    @mock.patch(\u0027cinder.backup.manager.BackupManager._run_backup\u0027)"},{"line_number":623,"context_line":"    @ddt.data(\u0027backing-up\u0027, \u0027available\u0027)"},{"line_number":624,"context_line":"    def test_create_backup_with_snapshot(self, snapshot_status,"},{"line_number":625,"context_line":"                                         mock_run_backup):"},{"line_number":626,"context_line":"        vol_id \u003d self._create_volume_db_entry(status\u003d\u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_43863e14","line":623,"range":{"start_line":623,"start_character":4,"end_line":623,"end_character":40},"updated":"2017-03-08 02:15:58.000000000","message":"It\u0027s better to add volume\u0027s status as one of the ddt variable","commit_id":"d7dce6bcca0be5a10112a4fde9fc004c2fa8a5ed"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"129646d6bec137e902b7be3743b41750f938aa9b","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        self.assertEqual(vol_size, backup[\u0027size\u0027])"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"    @mock.patch(\u0027cinder.backup.manager.BackupManager._run_backup\u0027)"},{"line_number":623,"context_line":"    @ddt.data(\u0027backing-up\u0027, \u0027available\u0027)"},{"line_number":624,"context_line":"    def test_create_backup_with_snapshot(self, snapshot_status,"},{"line_number":625,"context_line":"                                         mock_run_backup):"},{"line_number":626,"context_line":"        vol_id \u003d self._create_volume_db_entry(status\u003d\u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_0e30e69d","line":623,"range":{"start_line":623,"start_character":4,"end_line":623,"end_character":40},"in_reply_to":"9a30ddce_43863e14","updated":"2017-03-08 06:29:13.000000000","message":"I tested snapshots here. The volume\u0027s status is always \u0027available\u0027. I don\u0027t think it should be contained in ddt.\nthe test in L558 tested the volume with \"backing-up\" status.","commit_id":"d7dce6bcca0be5a10112a4fde9fc004c2fa8a5ed"}],"releasenotes/notes/snapshot_backing_up_status_support-164fbbb2a564e137.yaml":[{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"551563f624e5e1a5ab6ab0be88b94c7635a3efbf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Now when create backup with snapshots, the volume\u0027 status will not be"},{"line_number":4,"context_line":"    changed any more. But the snapshot\u0027s status will be changed to \"backing-up\""},{"line_number":5,"context_line":"    during the create action."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - The \"backing-up\" status is added to snapshot\u0027s status matrix."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1a1ced50_2d74f59a","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":29},"updated":"2017-03-17 12:16:02.000000000","message":"Please, make it briefer. Something like \"Fix volume status for snapshot related to volume backing-up operation\" or something better. Just facts about the fix.","commit_id":"4c05a5f0e14d2eea979b472e00f3ee81c20a9063"}]}