)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"8f7e54b2e943cf398c363dd8fee614ba512fb020","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HTTPConnect SSL certification verification failed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Avoid HTTPConnection ssl certivication verification failed"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If3aa845cf7550947a686b0d8de91cafb68da7103"},{"line_number":12,"context_line":"Closes-Bug: 1658763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a30ddce_3987ed10","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":38},"updated":"2017-03-07 07:14:01.000000000","message":"s/certivication/certification or rather \u0027..ssl certificate verification failed.\u0027","commit_id":"1bb209aad8fc451ad4f94b6e96376cee1710491e"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"88fae1c8d994acc0be7c22d15084ed67c3374691","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HTTPConnect SSL certification verification failed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Avoid HTTPConnection ssl certivication verification failed"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If3aa845cf7550947a686b0d8de91cafb68da7103"},{"line_number":12,"context_line":"Closes-Bug: 1658763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a30ddce_9fad198b","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":38},"in_reply_to":"9a30ddce_3987ed10","updated":"2017-03-07 08:28:53.000000000","message":"Why is this patch disabling certificate verification. Python 2.7.9 and up and 3.4.3 and up DO verify certs. See the following links:\n\nhttps://review.openstack.org/#/c/436157/ \nhttps://docs.python.org/2/library/httplib.html#httplib.HTTPSConnection\nhttps://docs.python.org/3.4/library/http.client.html#http.client.HTTPSConnection","commit_id":"1bb209aad8fc451ad4f94b6e96376cee1710491e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5c6e386a84fc160a80349b86ee41b7638e690d02","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HTTPConnect SSL certificate verification failed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Avoid HTTPConnection ssl certificate verification failed"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If3aa845cf7550947a686b0d8de91cafb68da7103"},{"line_number":12,"context_line":"Closes-Bug: 1658763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a30ddce_192240a3","line":9,"updated":"2017-03-13 15:47:32.000000000","message":"This is not nearly descriptive enough for a change that is about security.","commit_id":"49a998716a7cface27eeb3940fc8a5ceecf0b89f"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d65c0c89fa864a01741c45947d3a4528ae7d2a20","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rick.chen \u003crick.chen@prophetstor.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-20 18:30:20 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"HTTPConnect SSL certificate verification failed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.Move from httplib to requests."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1a1ced50_3f5105d9","line":7,"updated":"2017-03-21 14:51:10.000000000","message":"Please, add a note that it\u0027s related only for a specified driver","commit_id":"1cd4d9f237ec45a40ed834e25996737e84729256"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e70f4ae3232f25a3d25dea7a154dbd09766131d1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rick.chen \u003crick.chen@prophetstor.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-22 12:58:20 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Some server-side \u0027SSL\u0027 communication fails to check certificates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"AFAICT HTTPSConnection does not validate server certificates and"},{"line_number":10,"context_line":"should be avoided."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"ffe62b97_87ca7d6a","line":7,"updated":"2017-03-27 14:11:12.000000000","message":"Please, add a driver name to the commit message","commit_id":"5af6599f127eceea0e15bca9e95b097cbb2845e6"}],"cinder/volume/drivers/prophetstor/dplcommon.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"88fae1c8d994acc0be7c22d15084ed67c3374691","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                      self.password)).replace(\u0027\\n\u0027, \u0027\u0027)"},{"line_number":89,"context_line":"        header[\u0027Authorization\u0027] \u003d \u0027Basic %s\u0027 % auth"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        context \u003d ssl._create_unverified_context()"},{"line_number":92,"context_line":"        if not params:"},{"line_number":93,"context_line":"            payload \u003d None"},{"line_number":94,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_5f95613e","line":91,"updated":"2017-03-07 08:28:53.000000000","message":"This tells HTTPSConnection to *not* verify certificates. How does this fix the bug?","commit_id":"1bb209aad8fc451ad4f94b6e96376cee1710491e"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7851df1b0cc09fbe98ac7dc14a1a4cf28013b321","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.port \u003d port"},{"line_number":74,"context_line":"        self.username \u003d username"},{"line_number":75,"context_line":"        self.password \u003d password"},{"line_number":76,"context_line":"        if cert_path:"},{"line_number":77,"context_line":"            self.verify \u003d cert_path"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            self.verify \u003d False"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a22e58a_821dcb68","line":76,"updated":"2017-03-14 10:48:03.000000000","message":"Please, do not use the same variable for bool and string values. It makes code more complicated and harder to understand","commit_id":"3b650bc131488dc93542d8f5959e1dba604d3ff6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7851df1b0cc09fbe98ac7dc14a1a4cf28013b321","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                retcode \u003d errno.EINVAL"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        retry \u003d CONNECTION_RETRY"},{"line_number":106,"context_line":"        fun \u003d getattr(requests, method.lower())"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        while (retry):"},{"line_number":109,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a22e58a_a231e7ee","line":106,"updated":"2017-03-14 10:48:03.000000000","message":"fun \u003d\u003e func or method","commit_id":"3b650bc131488dc93542d8f5959e1dba604d3ff6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7851df1b0cc09fbe98ac7dc14a1a4cf28013b321","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                msg \u003d (_LE(\"failed to %(method)s due to %(error)s\")"},{"line_number":121,"context_line":"                       % {\"method\": method, \"error\": six.text_type(e)})"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if retcode !\u003d 0:"},{"line_number":124,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if (retcode \u003d\u003d 0 and r.status_code in expected_status and"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a22e58a_c27343b3","line":123,"updated":"2017-03-14 10:48:03.000000000","message":"We can move it into the except statement and remove this \u0027if\u0027","commit_id":"3b650bc131488dc93542d8f5959e1dba604d3ff6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7851df1b0cc09fbe98ac7dc14a1a4cf28013b321","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        if retcode !\u003d 0:"},{"line_number":124,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if (retcode \u003d\u003d 0 and r.status_code in expected_status and"},{"line_number":127,"context_line":"                r.status_code \u003d\u003d http_client.NOT_FOUND):"},{"line_number":128,"context_line":"            retcode \u003d errno.ENODATA"},{"line_number":129,"context_line":"        elif retcode \u003d\u003d 0 and r.status_code not in expected_status:"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a22e58a_426833bb","line":126,"range":{"start_line":126,"start_character":12,"end_line":126,"end_character":26},"updated":"2017-03-14 10:48:03.000000000","message":"retcode \u003d\u003d 0 will always be True","commit_id":"3b650bc131488dc93542d8f5959e1dba604d3ff6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7851df1b0cc09fbe98ac7dc14a1a4cf28013b321","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            retcode \u003d errno.EAGAIN"},{"line_number":144,"context_line":"            try:"},{"line_number":145,"context_line":"                data \u003d r.json()"},{"line_number":146,"context_line":"                # data \u003d json.loads(data)"},{"line_number":147,"context_line":"            except (TypeError, ValueError) as e:"},{"line_number":148,"context_line":"                LOG.error(_LE(\u0027Call to json.loads() raised an exception: %s.\u0027),"},{"line_number":149,"context_line":"                          e)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a22e58a_e29f5fb2","line":146,"updated":"2017-03-14 10:48:03.000000000","message":"Please, remove commented code","commit_id":"3b650bc131488dc93542d8f5959e1dba604d3ff6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7851df1b0cc09fbe98ac7dc14a1a4cf28013b321","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                http_client.NO_CONTENT not in expected_status):"},{"line_number":158,"context_line":"            try:"},{"line_number":159,"context_line":"                data \u003d r.json()"},{"line_number":160,"context_line":"                # data \u003d json.loads(data)"},{"line_number":161,"context_line":"            except (TypeError, ValueError) as e:"},{"line_number":162,"context_line":"                LOG.error(_LE(\u0027Call to json.loads() raised an exception: %s.\u0027),"},{"line_number":163,"context_line":"                          e)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a22e58a_a2b6473b","line":160,"range":{"start_line":160,"start_character":23,"end_line":160,"end_character":24},"updated":"2017-03-14 10:48:03.000000000","message":"ditto","commit_id":"3b650bc131488dc93542d8f5959e1dba604d3ff6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7851df1b0cc09fbe98ac7dc14a1a4cf28013b321","unresolved":false,"context_lines":[{"line_number":680,"context_line":"            if not cert_path:"},{"line_number":681,"context_line":"                LOG.warning("},{"line_number":682,"context_line":"                    _LW(\"Flexvisor: the ssl cert path not configured when\""},{"line_number":683,"context_line":"                        \" the ssl cert verif is enabled.\"))"},{"line_number":684,"context_line":"                cert_path \u003d None"},{"line_number":685,"context_line":"        else:"},{"line_number":686,"context_line":"            cert_path \u003d None"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a22e58a_2281774b","line":683,"updated":"2017-03-14 10:48:03.000000000","message":"verif \u003d\u003e verification","commit_id":"3b650bc131488dc93542d8f5959e1dba604d3ff6"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7a44b2f2f33da7009f8a54b39b640a35e4cd5a8d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                payload.encode(\u0027utf-8\u0027)"},{"line_number":99,"context_line":"            except Exception as e:"},{"line_number":100,"context_line":"                msg \u003d (_LE(\u0027JSON encode params %(param)s error:\u0027"},{"line_number":101,"context_line":"                           \u0027 %(status)s.\u0027), {\u0027param\u0027: params, \u0027status\u0027: e})"},{"line_number":102,"context_line":"                LOG.error(msg)"},{"line_number":103,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3a1ff146_df787c92","line":101,"range":{"start_line":101,"start_character":72,"end_line":101,"end_character":73},"updated":"2017-03-14 17:49:59.000000000","message":"Should use six.text_type here as well.","commit_id":"f7e5c7417aba390995aa9265a823f34fdb5d047b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7a44b2f2f33da7009f8a54b39b640a35e4cd5a8d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                else:"},{"line_number":124,"context_line":"                    break"},{"line_number":125,"context_line":"            except Exception as e:"},{"line_number":126,"context_line":"                msg \u003d (_LE(\"failed to %(method)s due to %(error)s\")"},{"line_number":127,"context_line":"                       % {\"method\": method, \"error\": six.text_type(e)})"},{"line_number":128,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3a1ff146_5f93aca3","line":126,"range":{"start_line":126,"start_character":24,"end_line":126,"end_character":26},"updated":"2017-03-14 17:49:59.000000000","message":"Don\u0027t need the _LE here, just _ if you are just sending it as an exception message.","commit_id":"f7e5c7417aba390995aa9265a823f34fdb5d047b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7a44b2f2f33da7009f8a54b39b640a35e4cd5a8d","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        if cert_verify:"},{"line_number":682,"context_line":"            if not cert_path:"},{"line_number":683,"context_line":"                LOG.warning("},{"line_number":684,"context_line":"                    _LW(\"Flexvisor: the ssl cert path not configured when\""},{"line_number":685,"context_line":"                        \" the ssl cert verify is enabled.\"))"},{"line_number":686,"context_line":"                cert_path \u003d None"},{"line_number":687,"context_line":"        else:"},{"line_number":688,"context_line":"            cert_path \u003d None"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a1ff146_5f6f2c92","line":685,"range":{"start_line":684,"start_character":0,"end_line":685,"end_character":60},"updated":"2017-03-14 17:49:59.000000000","message":"This message is not clear:  Suggest: \"Flexvisor: cert_verify is enabled but required cert_path option is missing.\"","commit_id":"f7e5c7417aba390995aa9265a823f34fdb5d047b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d65c0c89fa864a01741c45947d3a4528ae7d2a20","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                          ioerr)"},{"line_number":114,"context_line":"                retcode \u003d errno.ENOTCONN"},{"line_number":115,"context_line":"            except Exception as e:"},{"line_number":116,"context_line":"                LOG.error(\u0027Connect to Flexvisor failed: %s.\u0027, six.text_type(e))"},{"line_number":117,"context_line":"                msg \u003d (\u0027JSON encode params %(param)s error: %(status)s.\u0027,"},{"line_number":118,"context_line":"                       {\u0027param\u0027: params, \u0027status\u0027: six.text_type(e)})"},{"line_number":119,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a1ced50_7f337dab","line":116,"updated":"2017-03-21 14:51:10.000000000","message":"Please, change LOG.error to LOG.execption. In such case exception message will be added to the log automatically.","commit_id":"1cd4d9f237ec45a40ed834e25996737e84729256"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b34dc5fbd5fc0450ed807b39b2b3b3b11d72d204","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                        data\u003dpayload, headers\u003dheader, verify\u003dFalse)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"                if r.status_code \u003d\u003d http_client.SERVICE_UNAVAILABLE:"},{"line_number":138,"context_line":"                    msg \u003d (\"The flexvisor service is unavailable.\")"},{"line_number":139,"context_line":"                    LOG.error(msg)"},{"line_number":140,"context_line":"                    continue"},{"line_number":141,"context_line":"                else:"},{"line_number":142,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a1ced50_ac6779e7","line":139,"range":{"start_line":138,"start_character":0,"end_line":139,"end_character":34},"updated":"2017-03-22 03:33:04.000000000","message":"This should be combined into one line.","commit_id":"4b82ead0dc4c4976cf3a044e16d9bd24172c0aaf"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b34dc5fbd5fc0450ed807b39b2b3b3b11d72d204","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                else:"},{"line_number":142,"context_line":"                    break"},{"line_number":143,"context_line":"            except Exception as e:"},{"line_number":144,"context_line":"                msg \u003d (\"failed to %(method)s due to %(error)s\""},{"line_number":145,"context_line":"                       % {\"method\": method, \"error\": six.text_type(e)})"},{"line_number":146,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        if (r.status_code in expected_status and"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a1ced50_0c9dedbb","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":71},"updated":"2017-03-22 03:33:04.000000000","message":"This should still have _() as it is for an exception.","commit_id":"4b82ead0dc4c4976cf3a044e16d9bd24172c0aaf"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e70f4ae3232f25a3d25dea7a154dbd09766131d1","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                retcode \u003d errno.ENOTCONN"},{"line_number":115,"context_line":"            except Exception as e:"},{"line_number":116,"context_line":"                LOG.exceptioin(\u0027Connect to Flexvisor failed: %s.\u0027,"},{"line_number":117,"context_line":"                               six.text_type(e))"},{"line_number":118,"context_line":"                msg \u003d (\u0027JSON encode params %(param)s error: %(status)s.\u0027,"},{"line_number":119,"context_line":"                       {\u0027param\u0027: params, \u0027status\u0027: six.text_type(e)})"},{"line_number":120,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ffe62b97_e7126909","line":117,"updated":"2017-03-27 14:11:12.000000000","message":"You don\u0027t need to pass exception to LOG.exception call","commit_id":"5af6599f127eceea0e15bca9e95b097cbb2845e6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e70f4ae3232f25a3d25dea7a154dbd09766131d1","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        while (retry):"},{"line_number":127,"context_line":"            try:"},{"line_number":128,"context_line":"                if self.cert_verify:"},{"line_number":129,"context_line":"                    r \u003d func("},{"line_number":130,"context_line":"                        url\u003d\"https://%s:%s%s\" % (self.ip, self.port, url),"},{"line_number":131,"context_line":"                        data\u003dpayload, headers\u003dheader, verify\u003dself.cert_path)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ffe62b97_07de6d3e","line":128,"updated":"2017-03-27 14:11:12.000000000","message":"Why can\u0027t we do just:\n r \u003d func(\n                        url\u003d\"https://%s:%s%s\" % (self.ip, self.port, url),\n                        data\u003dpayload, headers\u003dheader, verify\u003dself.cert_path)\nwithout if-else statement?","commit_id":"5af6599f127eceea0e15bca9e95b097cbb2845e6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"e70f4ae3232f25a3d25dea7a154dbd09766131d1","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                else:"},{"line_number":141,"context_line":"                    break"},{"line_number":142,"context_line":"            except Exception as e:"},{"line_number":143,"context_line":"                msg \u003d (_(\"failed to %(method)s due to %(error)s\")"},{"line_number":144,"context_line":"                       % {\"method\": method, \"error\": six.text_type(e)})"},{"line_number":145,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"ffe62b97_47bd95d6","line":143,"updated":"2017-03-27 14:11:12.000000000","message":"Do we need logging here?","commit_id":"5af6599f127eceea0e15bca9e95b097cbb2845e6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"74c4b5eabf4cfae36376dc24b54c09385afd987f","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"            LOG.info(\u0027Flexvisor succeeded to create volume %(id)s \u0027"},{"line_number":1123,"context_line":"                     \u0027from snapshot.\u0027, {\u0027id\u0027: volume[\u0027id\u0027]})"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"        if volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027]:"},{"line_number":1126,"context_line":"            self.extend_volume(volume, volume[\u0027size\u0027])"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"        if volume.get(\u0027consistencygroup_id\u0027, None):"}],"source_content_type":"text/x-python","patch_set":25,"id":"bff0334d_83e03c98","line":1125,"updated":"2017-04-07 13:26:58.000000000","message":"This doesn\u0027t appear to be related to the commit message.","commit_id":"840289225f2776349697aa1aa51bd8c68bc1921d"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"59cffca09b02c880c83aac1592a752489c55a13a","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"            LOG.info(\u0027Flexvisor succeeded to create volume %(id)s \u0027"},{"line_number":1123,"context_line":"                     \u0027from snapshot.\u0027, {\u0027id\u0027: volume[\u0027id\u0027]})"},{"line_number":1124,"context_line":""},{"line_number":1125,"context_line":"        if volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027]:"},{"line_number":1126,"context_line":"            self.extend_volume(volume, volume[\u0027size\u0027])"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"        if volume.get(\u0027consistencygroup_id\u0027, None):"}],"source_content_type":"text/x-python","patch_set":25,"id":"bff0334d_fe843a0e","line":1125,"in_reply_to":"bff0334d_83e03c98","updated":"2017-04-07 15:01:40.000000000","message":"+1","commit_id":"840289225f2776349697aa1aa51bd8c68bc1921d"}]}