)]}'
{"tools/lintstack.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"277f1ff1e4a6a48ad641522fb515e099fc053ed3","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        result \u003d {}"},{"line_number":134,"context_line":"        for line in msg.splitlines():"},{"line_number":135,"context_line":"            obj \u003d cls.from_line(line)"},{"line_number":136,"context_line":"            if obj is None:"},{"line_number":137,"context_line":"                continue"},{"line_number":138,"context_line":"            ignored \u003d obj.is_ignored()"},{"line_number":139,"context_line":"            if ignored:"},{"line_number":140,"context_line":"                continue"},{"line_number":141,"context_line":"            key \u003d obj.key()"},{"line_number":142,"context_line":"            if key not in result:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_a8c85c73","line":139,"range":{"start_line":136,"start_character":0,"end_line":139,"end_character":23},"updated":"2017-05-24 08:44:49.000000000","message":"-1: `if not obj or obj.is_ignored():`","commit_id":"2e616c58600a96528e13b46160398b11249a1ba9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"277f1ff1e4a6a48ad641522fb515e099fc053ed3","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            any(self.filename.startswith(name)"},{"line_number":158,"context_line":"                for name in objects_ignore_modules)):"},{"line_number":159,"context_line":"            return \"objects_ignore_codes\""},{"line_number":160,"context_line":"        return False"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def key(self):"},{"line_number":163,"context_line":"        if self.code in [\"E1101\", \"E1103\"]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_e8d3f402","line":160,"updated":"2017-05-24 08:44:49.000000000","message":"-1: If we are returning strings now instead of booleans we should return `None` or `\u0027\u0027` as both will evaluate to `False`.","commit_id":"2e616c58600a96528e13b46160398b11249a1ba9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e72237490ee850694ce0888dff5c7af69ccd2a0c","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        result \u003d {}"},{"line_number":134,"context_line":"        for line in msg.splitlines():"},{"line_number":135,"context_line":"            obj \u003d cls.from_line(line)"},{"line_number":136,"context_line":"            if obj is None:"},{"line_number":137,"context_line":"                continue"},{"line_number":138,"context_line":"            ignored \u003d obj.is_ignored()"},{"line_number":139,"context_line":"            if ignored:"},{"line_number":140,"context_line":"                continue"},{"line_number":141,"context_line":"            key \u003d obj.key()"},{"line_number":142,"context_line":"            if key not in result:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_d99a3eb7","line":139,"range":{"start_line":136,"start_character":12,"end_line":139,"end_character":23},"updated":"2017-08-15 16:55:53.000000000","message":"Any reason not to simplify as Gorka suggeste in PS 3?","commit_id":"f9f9f5828ca036650d0afca81ceae2cd42454cc3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e72237490ee850694ce0888dff5c7af69ccd2a0c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            any(self.filename.startswith(name)"},{"line_number":158,"context_line":"                for name in objects_ignore_modules)):"},{"line_number":159,"context_line":"            return \"objects_ignore_codes\""},{"line_number":160,"context_line":"        return False"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def key(self):"},{"line_number":163,"context_line":"        if self.code in [\"E1101\", \"E1103\"]:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f436f4f_798b5267","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":20},"updated":"2017-08-15 16:55:53.000000000","message":"Respond to Gorka\u0027s remark in PS3?","commit_id":"f9f9f5828ca036650d0afca81ceae2cd42454cc3"}],"tox.ini":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d949be12279e89081689c99336fefc4996481997","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# pylint to work."},{"line_number":71,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":72,"context_line":"       pylint\u003d\u003d1.4.3"},{"line_number":73,"context_line":"       astroid\u003d\u003d\u003d1.4.8"},{"line_number":74,"context_line":"commands \u003d bash tools/lintstack.sh"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"[testenv:cover]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff0f0b1f_25b44e7f","line":73,"range":{"start_line":73,"start_character":14,"end_line":73,"end_character":17},"updated":"2017-05-25 08:38:50.000000000","message":"?: Why the triple \u003d? What\u0027s the difference with the double \u003d like we have in the pylint requirement?","commit_id":"2e616c58600a96528e13b46160398b11249a1ba9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"369a8d48274d42d5e88591f7fb0d875f2741aa11","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# pylint to work."},{"line_number":71,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":72,"context_line":"       pylint\u003d\u003d1.4.3"},{"line_number":73,"context_line":"       astroid\u003d\u003d\u003d1.4.8"},{"line_number":74,"context_line":"commands \u003d bash tools/lintstack.sh"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"[testenv:cover]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff0f0b1f_d052f2dd","line":73,"range":{"start_line":73,"start_character":14,"end_line":73,"end_character":17},"in_reply_to":"ff0f0b1f_25b44e7f","updated":"2017-05-25 08:51:00.000000000","message":"I just checked and this doesn\u0027t install 1.4.8, after running \u0027tox -r -epylint -notest\u0027 I get astroid\u003d\u003d1.3.8","commit_id":"2e616c58600a96528e13b46160398b11249a1ba9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a032cf571b0fd4c881c98d0cb7a204b9f7cf6783","unresolved":false,"context_lines":[{"line_number":70,"context_line":"# pylint to work."},{"line_number":71,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":72,"context_line":"       pylint\u003d\u003d1.4.3"},{"line_number":73,"context_line":"       astroid\u003d\u003d\u003d1.4.8"},{"line_number":74,"context_line":"commands \u003d bash tools/lintstack.sh"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"[testenv:cover]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"9f436f4f_96580556","line":73,"range":{"start_line":73,"start_character":14,"end_line":73,"end_character":17},"in_reply_to":"ff0f0b1f_d052f2dd","updated":"2017-08-15 16:51:35.000000000","message":"A port of this patch to manila installed 1.4.8.","commit_id":"2e616c58600a96528e13b46160398b11249a1ba9"}]}