)]}'
{"cinder/tests/unit/api/v3/fakes.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f6f462cf7f3490a5492dd17af351280a8225cb84","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    if group_id:"},{"line_number":114,"context_line":"        vol[\u0027group_id\u0027] \u003d group_id"},{"line_number":115,"context_line":"    return vol"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"fake_target \u003d {"},{"line_number":118,"context_line":"    \u0027extra\u0027: \u0027data\u0027,"},{"line_number":119,"context_line":"    \u0027more\u0027: \u0027data\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_486c2dd0","line":116,"updated":"2017-03-10 10:07:38.000000000","message":"nit: I think we don\u0027t need to add this variable here, we can just define the array directly in the ddt.data decorator.","commit_id":"607f94204bef4cc454069200dde53229abafe8dd"}],"cinder/tests/unit/api/v3/test_volumes.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"14e681c41db9ada3baa6beaf4820d0b228ec32d2","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        self.mock_object(volume_api.API, \u0027get\u0027, v2_fakes.fake_volume_get)"},{"line_number":390,"context_line":"        self.mock_object(volumes, \u0027check_policy\u0027)"},{"line_number":391,"context_line":"        mock_get_bool_param.side_effect \u003d cascade, force"},{"line_number":392,"context_line":"        mock_response.return_value \u003d None"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v3/volumes\u0027, version\u003dversion)"},{"line_number":395,"context_line":"        ctx \u003d req.environ[\u0027cinder.context\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_fcd79aea","line":392,"updated":"2017-03-09 09:27:06.000000000","message":"nit: This could go on L386","commit_id":"69bd834fb87ce31589d65a7b167159cc5fc215e2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"14e681c41db9ada3baa6beaf4820d0b228ec32d2","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        self.controller.delete(req, fake.VOLUME_ID)"},{"line_number":400,"context_line":"        mock_delete.assert_called_with(ctx, vol,"},{"line_number":401,"context_line":"                                       cascade\u003dcascade,"},{"line_number":402,"context_line":"                                       force\u003dTrue if version \u003d\u003d \"3.23\""},{"line_number":403,"context_line":"                                       else False)"},{"line_number":404,"context_line":"        mock_response.assert_called_with(status_int\u003d202)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    @ddt.data({\u0027admin\u0027: True, \u0027version\u0027: \u00273.21\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_fc45dab2","line":403,"range":{"start_line":402,"start_character":0,"end_line":403,"end_character":50},"updated":"2017-03-09 09:27:06.000000000","message":"-1: Why aren\u0027t we using force variable instead?\n\n force\u003dforce)\n\nAnd even if we don\u0027t, we don\u0027t need an if here, the boolean expression is already giving us the value:\n\n  force\u003dversion\u003d\u003d\u00273.23\u0027)","commit_id":"69bd834fb87ce31589d65a7b167159cc5fc215e2"},{"author":{"_account_id":22227,"name":"Justin A Wilson","email":"justin.wilson@intel.com","username":"waj334"},"change_message_id":"2596441d7c3398b8db2d894b9148eaa27211b4aa","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        self.controller.delete(req, fake.VOLUME_ID)"},{"line_number":400,"context_line":"        mock_delete.assert_called_with(ctx, vol,"},{"line_number":401,"context_line":"                                       cascade\u003dcascade,"},{"line_number":402,"context_line":"                                       force\u003dTrue if version \u003d\u003d \"3.23\""},{"line_number":403,"context_line":"                                       else False)"},{"line_number":404,"context_line":"        mock_response.assert_called_with(status_int\u003d202)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    @ddt.data({\u0027admin\u0027: True, \u0027version\u0027: \u00273.21\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_32021f3e","line":403,"range":{"start_line":402,"start_character":0,"end_line":403,"end_character":50},"in_reply_to":"9a30ddce_fc45dab2","updated":"2017-03-09 21:46:49.000000000","message":"Rookie mistake lol","commit_id":"69bd834fb87ce31589d65a7b167159cc5fc215e2"},{"author":{"_account_id":19774,"name":"Vivek Agrawal","email":"vivek.agrawal@veritas.com","username":"viveksagrawal"},"change_message_id":"bb62af13c27e164f297336c2bc35a885e0d32d17","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        mock_get_bool_param.side_effect \u003d cascade, force"},{"line_number":390,"context_line":"        mock_response.return_value \u003d None"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v3/volumes\u0027, version\u003dversion)"},{"line_number":393,"context_line":"        ctx \u003d req.environ[\u0027cinder.context\u0027]"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        vol \u003d v2_fakes.fake_volume_get(self, ctx, fake.VOLUME_ID)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a1ff146_1bde6f3f","line":392,"updated":"2017-03-15 20:11:57.000000000","message":"Suggestion...should we use string constant instead of string. Just to make it reusable.","commit_id":"ee5db872ee7bc1a2a387ebe1e65449a959afcbc8"},{"author":{"_account_id":19774,"name":"Vivek Agrawal","email":"vivek.agrawal@veritas.com","username":"viveksagrawal"},"change_message_id":"bb62af13c27e164f297336c2bc35a885e0d32d17","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        mock_delete.assert_called_with(ctx, vol,"},{"line_number":399,"context_line":"                                       cascade\u003dcascade,"},{"line_number":400,"context_line":"                                       force\u003dforce)"},{"line_number":401,"context_line":"        mock_response.assert_called_with(status_int\u003d202)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"    @ddt.data({\u0027admin\u0027: True, \u0027version\u0027: \u00273.21\u0027},"},{"line_number":404,"context_line":"              {\u0027admin\u0027: False, \u0027version\u0027: \u00273.21\u0027},"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a1ff146_9bc97f7b","line":401,"updated":"2017-03-15 20:11:57.000000000","message":"Suggestion...it will be nice to use http_client library constants instead of direct ints","commit_id":"ee5db872ee7bc1a2a387ebe1e65449a959afcbc8"}]}