)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9277ec0764d8e7403579ee2fbcae8875220715bf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding support for generic volume groups to the Dell EMC SC driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Removed support for consistency groups as they are going away in"},{"line_number":12,"context_line":"Pike."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I208144e6796166576a80a8f74e0bb00658c2950f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dfeb2761_8903f842","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":5},"updated":"2017-03-31 16:57:06.000000000","message":"Change to: Removed driver interfaces for consistency groups as they won\u0027t be called In Pike.\n\nSupport for consistency groups won\u0027t go away.  CG APIs still work.  CG API will be deprecated in Queens.  It\u0027s just that lots of CG code is not needed any more, but CG API code at the top layer is still there.","commit_id":"6323b9cf3be89f52136a1f798767340ae54d2cc5"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"2c5fbd11add797b8e53b85b9c874252014f9cc08","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding support for generic volume groups to the Dell EMC SC driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Removed support for consistency groups as they are going away in"},{"line_number":12,"context_line":"Pike."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I208144e6796166576a80a8f74e0bb00658c2950f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dfeb2761_f5881772","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":5},"in_reply_to":"dfeb2761_8903f842","updated":"2017-03-31 18:57:10.000000000","message":"Done","commit_id":"6323b9cf3be89f52136a1f798767340ae54d2cc5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9277ec0764d8e7403579ee2fbcae8875220715bf","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Removed support for consistency groups as they are going away in"},{"line_number":12,"context_line":"Pike."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I208144e6796166576a80a8f74e0bb00658c2950f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dfeb2761_fc4c8477","line":13,"updated":"2017-03-31 16:57:06.000000000","message":"Please register a blueprint and reference it here.","commit_id":"6323b9cf3be89f52136a1f798767340ae54d2cc5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"635e04adfbb629bd3e9acb0df0baf8cdbd24d7e8","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Removed support for consistency groups as they are going away in"},{"line_number":12,"context_line":"Pike."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I208144e6796166576a80a8f74e0bb00658c2950f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dfeb2761_2bf3bb0c","line":13,"in_reply_to":"dfeb2761_55910399","updated":"2017-03-31 20:42:53.000000000","message":"When a new feature is added to a driver, a blueprint is needed.","commit_id":"6323b9cf3be89f52136a1f798767340ae54d2cc5"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"2c5fbd11add797b8e53b85b9c874252014f9cc08","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Removed support for consistency groups as they are going away in"},{"line_number":12,"context_line":"Pike."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I208144e6796166576a80a8f74e0bb00658c2950f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dfeb2761_55910399","line":13,"in_reply_to":"dfeb2761_fc4c8477","updated":"2017-03-31 18:57:10.000000000","message":"I didn\u0027t think blueprints were required for driver changes.","commit_id":"6323b9cf3be89f52136a1f798767340ae54d2cc5"}],"cinder/volume/drivers/dell/dell_storagecenter_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1cf119659983e7c788f2908b78017af1e0fe114c","unresolved":false,"context_lines":[{"line_number":708,"context_line":"            data[\u0027driver_version\u0027] \u003d self.VERSION"},{"line_number":709,"context_line":"            data[\u0027storage_protocol\u0027] \u003d self.storage_protocol"},{"line_number":710,"context_line":"            data[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":711,"context_line":"            data[\u0027consistencygroup_support\u0027] \u003d True"},{"line_number":712,"context_line":"            data[\u0027consistent_group_snapshot_enabled\u0027] \u003d True"},{"line_number":713,"context_line":"            data[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":714,"context_line":"            data[\u0027QoS_support\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_50b06a43","line":711,"range":{"start_line":711,"start_character":12,"end_line":711,"end_character":51},"updated":"2017-03-28 18:21:55.000000000","message":"This is not needed any more.","commit_id":"e05c6076735daab219d920c9bd70af916e4de969"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"1cf119659983e7c788f2908b78017af1e0fe114c","unresolved":false,"context_lines":[{"line_number":788,"context_line":"    def _is_cg(self, group):"},{"line_number":789,"context_line":"        gid \u003d group.get(\u0027group_type_id\u0027)"},{"line_number":790,"context_line":"        specs \u003d group_types.get_group_type_specs(gid) if gid else {}"},{"line_number":791,"context_line":"        return specs.get(\u0027consistent_group_snapshot_enabled\u0027) \u003d\u003d \u0027\u003cis\u003e True\u0027"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"    def create_group(self, context, group):"},{"line_number":794,"context_line":"        \"\"\"Creates a group."}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_108f8275","line":791,"updated":"2017-03-28 18:21:55.000000000","message":"Use this existing function in utils:\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/utils.py#L904","commit_id":"e05c6076735daab219d920c9bd70af916e4de969"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9277ec0764d8e7403579ee2fbcae8875220715bf","unresolved":false,"context_lines":[{"line_number":810,"context_line":"            with self._client.open_connection() as api:"},{"line_number":811,"context_line":"                cgroup \u003d api.create_replay_profile(gid)"},{"line_number":812,"context_line":"                if cgroup:"},{"line_number":813,"context_line":"                    LOG.info(\u0027Created volume group %s\u0027, gid)"},{"line_number":814,"context_line":"                    model_update[\u0027status\u0027] \u003d fields.GroupStatus.AVAILABLE"},{"line_number":815,"context_line":"        return model_update"},{"line_number":816,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_49597058","line":813,"range":{"start_line":813,"start_character":38,"end_line":813,"end_character":50},"updated":"2017-03-31 16:57:06.000000000","message":"I\u0027d either say \"generic volume group\" or just \"group\".  \"volume group\" is a term used for LVM and therefore is confusing.","commit_id":"6323b9cf3be89f52136a1f798767340ae54d2cc5"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"2c5fbd11add797b8e53b85b9c874252014f9cc08","unresolved":false,"context_lines":[{"line_number":810,"context_line":"            with self._client.open_connection() as api:"},{"line_number":811,"context_line":"                cgroup \u003d api.create_replay_profile(gid)"},{"line_number":812,"context_line":"                if cgroup:"},{"line_number":813,"context_line":"                    LOG.info(\u0027Created volume group %s\u0027, gid)"},{"line_number":814,"context_line":"                    model_update[\u0027status\u0027] \u003d fields.GroupStatus.AVAILABLE"},{"line_number":815,"context_line":"        return model_update"},{"line_number":816,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_35bc3f04","line":813,"range":{"start_line":813,"start_character":38,"end_line":813,"end_character":50},"in_reply_to":"dfeb2761_49597058","updated":"2017-03-31 18:57:10.000000000","message":"Done","commit_id":"6323b9cf3be89f52136a1f798767340ae54d2cc5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9277ec0764d8e7403579ee2fbcae8875220715bf","unresolved":false,"context_lines":[{"line_number":811,"context_line":"                cgroup \u003d api.create_replay_profile(gid)"},{"line_number":812,"context_line":"                if cgroup:"},{"line_number":813,"context_line":"                    LOG.info(\u0027Created volume group %s\u0027, gid)"},{"line_number":814,"context_line":"                    model_update[\u0027status\u0027] \u003d fields.GroupStatus.AVAILABLE"},{"line_number":815,"context_line":"        return model_update"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"    def delete_group(self, context, group, volumes):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_7c3bd4d0","line":814,"updated":"2017-03-31 16:57:06.000000000","message":"What happens if is_group_a_cg_snapshot_type is False?  Can you do the following.  When it raises NotImplementedError(), it will be handled by the default generic volume groups implementation and create non-consistent group.\n\nif volume_utils.is_group_a_cg_snapshot_type(group):\n    ……..\nelse:\n    raise NotImplementedError()\n\nI suggest you do the same for the other groups functions.","commit_id":"6323b9cf3be89f52136a1f798767340ae54d2cc5"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"2c5fbd11add797b8e53b85b9c874252014f9cc08","unresolved":false,"context_lines":[{"line_number":811,"context_line":"                cgroup \u003d api.create_replay_profile(gid)"},{"line_number":812,"context_line":"                if cgroup:"},{"line_number":813,"context_line":"                    LOG.info(\u0027Created volume group %s\u0027, gid)"},{"line_number":814,"context_line":"                    model_update[\u0027status\u0027] \u003d fields.GroupStatus.AVAILABLE"},{"line_number":815,"context_line":"        return model_update"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"    def delete_group(self, context, group, volumes):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_f53b7799","line":814,"in_reply_to":"dfeb2761_7c3bd4d0","updated":"2017-03-31 18:57:10.000000000","message":"Done","commit_id":"6323b9cf3be89f52136a1f798767340ae54d2cc5"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bceff9298402aa5094017a57b79d0bd2d4d72f0f","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"            raise NotImplementedError()"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"        model_update \u003d {\u0027status\u0027: fields.GroupSnapshotStatus.ERROR}"},{"line_number":1037,"context_line":"        snapshot_updates \u003d None"},{"line_number":1038,"context_line":"        with self._client.open_connection() as api:"},{"line_number":1039,"context_line":"            gid \u003d group_snapshot[\u0027group_id\u0027]"},{"line_number":1040,"context_line":"            snapshotid \u003d group_snapshot[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_72b4dd35","line":1037,"range":{"start_line":1037,"start_character":27,"end_line":1037,"end_character":31},"updated":"2017-04-03 21:17:05.000000000","message":"This should be \"snapshot_updates \u003d []\", otherwise, append won\u0027t work.","commit_id":"99ce9ae5769c4d781d95c7e2a85faa8e989c04ff"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"7225c9ccaf7d16fd185be3747a775e71f23fcd9b","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"            raise NotImplementedError()"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"        model_update \u003d {\u0027status\u0027: fields.GroupSnapshotStatus.ERROR}"},{"line_number":1037,"context_line":"        snapshot_updates \u003d None"},{"line_number":1038,"context_line":"        with self._client.open_connection() as api:"},{"line_number":1039,"context_line":"            gid \u003d group_snapshot[\u0027group_id\u0027]"},{"line_number":1040,"context_line":"            snapshotid \u003d group_snapshot[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_bd9b3a64","line":1037,"range":{"start_line":1037,"start_character":27,"end_line":1037,"end_character":31},"in_reply_to":"dfeb2761_72b4dd35","updated":"2017-04-04 15:28:06.000000000","message":"It is set to [] before the for loop with the append. If it never hits that then the function returns None.","commit_id":"99ce9ae5769c4d781d95c7e2a85faa8e989c04ff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"058c4d84a21adaa8673f3ff95bfe53da433d09a8","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"            raise NotImplementedError()"},{"line_number":1035,"context_line":""},{"line_number":1036,"context_line":"        model_update \u003d {\u0027status\u0027: fields.GroupSnapshotStatus.ERROR}"},{"line_number":1037,"context_line":"        snapshot_updates \u003d None"},{"line_number":1038,"context_line":"        with self._client.open_connection() as api:"},{"line_number":1039,"context_line":"            gid \u003d group_snapshot[\u0027group_id\u0027]"},{"line_number":1040,"context_line":"            snapshotid \u003d group_snapshot[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_21b013dd","line":1037,"range":{"start_line":1037,"start_character":27,"end_line":1037,"end_character":31},"in_reply_to":"dfeb2761_bd9b3a64","updated":"2017-04-05 01:38:07.000000000","message":"You are right!  I missed it.","commit_id":"99ce9ae5769c4d781d95c7e2a85faa8e989c04ff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bceff9298402aa5094017a57b79d0bd2d4d72f0f","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"            raise NotImplementedError()"},{"line_number":1108,"context_line":""},{"line_number":1109,"context_line":"        model_update \u003d {\u0027status\u0027: fields.GroupSnapshotStatus.ERROR}"},{"line_number":1110,"context_line":"        snapshot_updates \u003d None"},{"line_number":1111,"context_line":"        with self._client.open_connection() as api:"},{"line_number":1112,"context_line":"            snapshotid \u003d group_snapshot[\u0027id\u0027]"},{"line_number":1113,"context_line":"            profile \u003d api.find_replay_profile(group_snapshot[\u0027group_id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_32d65551","line":1110,"updated":"2017-04-03 21:17:05.000000000","message":"snapshot_updates \u003d []","commit_id":"99ce9ae5769c4d781d95c7e2a85faa8e989c04ff"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"7225c9ccaf7d16fd185be3747a775e71f23fcd9b","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"            raise NotImplementedError()"},{"line_number":1108,"context_line":""},{"line_number":1109,"context_line":"        model_update \u003d {\u0027status\u0027: fields.GroupSnapshotStatus.ERROR}"},{"line_number":1110,"context_line":"        snapshot_updates \u003d None"},{"line_number":1111,"context_line":"        with self._client.open_connection() as api:"},{"line_number":1112,"context_line":"            snapshotid \u003d group_snapshot[\u0027id\u0027]"},{"line_number":1113,"context_line":"            profile \u003d api.find_replay_profile(group_snapshot[\u0027group_id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_bd021a6e","line":1110,"in_reply_to":"dfeb2761_32d65551","updated":"2017-04-04 15:28:06.000000000","message":"Same as before. If the for loop where we set this isn\u0027t hit we return nothing.","commit_id":"99ce9ae5769c4d781d95c7e2a85faa8e989c04ff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bceff9298402aa5094017a57b79d0bd2d4d72f0f","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"                LOG.info(\u0027delete_group_snapshot: %(ss)s from %(pro)s\u0027,"},{"line_number":1116,"context_line":"                         {\u0027ss\u0027: snapshotid, \u0027pro\u0027: profile})"},{"line_number":1117,"context_line":"                if not api.delete_cg_replay(profile, snapshotid):"},{"line_number":1118,"context_line":"                    model_update[\u0027status\u0027] \u003d \\"},{"line_number":1119,"context_line":"                        fields.GroupSnapshotStatus.ERROR_DELETING"},{"line_number":1120,"context_line":"                else:"},{"line_number":1121,"context_line":"                    model_update[\u0027status\u0027] \u003d fields.GroupSnapshotStatus.DELETED"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_f2446d1d","line":1118,"range":{"start_line":1118,"start_character":45,"end_line":1118,"end_character":46},"updated":"2017-04-03 21:17:05.000000000","message":"Please use () instead of \\.","commit_id":"99ce9ae5769c4d781d95c7e2a85faa8e989c04ff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"058c4d84a21adaa8673f3ff95bfe53da433d09a8","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"                LOG.info(\u0027delete_group_snapshot: %(ss)s from %(pro)s\u0027,"},{"line_number":1116,"context_line":"                         {\u0027ss\u0027: snapshotid, \u0027pro\u0027: profile})"},{"line_number":1117,"context_line":"                if not api.delete_cg_replay(profile, snapshotid):"},{"line_number":1118,"context_line":"                    model_update[\u0027status\u0027] \u003d \\"},{"line_number":1119,"context_line":"                        fields.GroupSnapshotStatus.ERROR_DELETING"},{"line_number":1120,"context_line":"                else:"},{"line_number":1121,"context_line":"                    model_update[\u0027status\u0027] \u003d fields.GroupSnapshotStatus.DELETED"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_81435faf","line":1118,"range":{"start_line":1118,"start_character":45,"end_line":1118,"end_character":46},"in_reply_to":"dfeb2761_1dc90625","updated":"2017-04-05 01:38:07.000000000","message":"Back slash is so ugly!:)\n\nParenthesis is still the preferred way.  If you\u0027ve already got a +2, I won\u0027t let this stand in the way.  This is one of those nice-to-haves.  Thanks for changing!","commit_id":"99ce9ae5769c4d781d95c7e2a85faa8e989c04ff"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"7225c9ccaf7d16fd185be3747a775e71f23fcd9b","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"                LOG.info(\u0027delete_group_snapshot: %(ss)s from %(pro)s\u0027,"},{"line_number":1116,"context_line":"                         {\u0027ss\u0027: snapshotid, \u0027pro\u0027: profile})"},{"line_number":1117,"context_line":"                if not api.delete_cg_replay(profile, snapshotid):"},{"line_number":1118,"context_line":"                    model_update[\u0027status\u0027] \u003d \\"},{"line_number":1119,"context_line":"                        fields.GroupSnapshotStatus.ERROR_DELETING"},{"line_number":1120,"context_line":"                else:"},{"line_number":1121,"context_line":"                    model_update[\u0027status\u0027] \u003d fields.GroupSnapshotStatus.DELETED"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_1dc90625","line":1118,"range":{"start_line":1118,"start_character":45,"end_line":1118,"end_character":46},"in_reply_to":"dfeb2761_f2446d1d","updated":"2017-04-04 15:28:06.000000000","message":"Changed. But I thought we all agreed that \\ was fine? Maybe that was in channel and not in a meeting. The aesthetics of parenthesis pale in comparison to the elegant back slash.","commit_id":"99ce9ae5769c4d781d95c7e2a85faa8e989c04ff"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8a65e7411a6a6408d4b79406a3d72ab7b10f48c6","unresolved":false,"context_lines":[{"line_number":708,"context_line":"            data[\u0027driver_version\u0027] \u003d self.VERSION"},{"line_number":709,"context_line":"            data[\u0027storage_protocol\u0027] \u003d self.storage_protocol"},{"line_number":710,"context_line":"            data[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":711,"context_line":"            data[\u0027consistent_group_snapshot_enabled\u0027] \u003d True"},{"line_number":712,"context_line":"            data[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":713,"context_line":"            data[\u0027QoS_support\u0027] \u003d False"},{"line_number":714,"context_line":"            data[\u0027replication_enabled\u0027] \u003d self.replication_enabled"}],"source_content_type":"text/x-python","patch_set":8,"id":"bff0334d_73c02d2b","line":711,"updated":"2017-04-10 15:38:59.000000000","message":"Shouldn\u0027t this still provide \"data[\u0027consistencygroup_support\u0027]\"  for a deprecation period as well, so people who reference that in extra specs don\u0027t break?","commit_id":"cdd12d9038328a6ef25a28317d8c2452f14fa84c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"adfe5c90916726674b807474bab5bfd662d7225e","unresolved":false,"context_lines":[{"line_number":708,"context_line":"            data[\u0027driver_version\u0027] \u003d self.VERSION"},{"line_number":709,"context_line":"            data[\u0027storage_protocol\u0027] \u003d self.storage_protocol"},{"line_number":710,"context_line":"            data[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":711,"context_line":"            data[\u0027consistent_group_snapshot_enabled\u0027] \u003d True"},{"line_number":712,"context_line":"            data[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":713,"context_line":"            data[\u0027QoS_support\u0027] \u003d False"},{"line_number":714,"context_line":"            data[\u0027replication_enabled\u0027] \u003d self.replication_enabled"}],"source_content_type":"text/x-python","patch_set":8,"id":"bff0334d_0c754364","line":711,"in_reply_to":"bff0334d_6eba860a","updated":"2017-04-10 16:19:51.000000000","message":"We have never required consistencygroup_support to be set in extra specs (due to review comments when CG was initially introduced).  That being said, it doesn\u0027t prevent anyone from adding it to extra specs.  So it is probably good to keep consistencygroup_support \u003d True here.","commit_id":"cdd12d9038328a6ef25a28317d8c2452f14fa84c"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"7cba7e49cea2ff41f9516eed5582f3eb34f2ea20","unresolved":false,"context_lines":[{"line_number":708,"context_line":"            data[\u0027driver_version\u0027] \u003d self.VERSION"},{"line_number":709,"context_line":"            data[\u0027storage_protocol\u0027] \u003d self.storage_protocol"},{"line_number":710,"context_line":"            data[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":711,"context_line":"            data[\u0027consistent_group_snapshot_enabled\u0027] \u003d True"},{"line_number":712,"context_line":"            data[\u0027thin_provisioning_support\u0027] \u003d True"},{"line_number":713,"context_line":"            data[\u0027QoS_support\u0027] \u003d False"},{"line_number":714,"context_line":"            data[\u0027replication_enabled\u0027] \u003d self.replication_enabled"}],"source_content_type":"text/x-python","patch_set":8,"id":"bff0334d_6eba860a","line":711,"in_reply_to":"bff0334d_73c02d2b","updated":"2017-04-10 15:52:46.000000000","message":"Hmmmm.... Seems like that would make sense. Xyang said I should remove it but after last weeks deprecation conversation it seems like it should probably be set.","commit_id":"cdd12d9038328a6ef25a28317d8c2452f14fa84c"}],"releasenotes/notes/dell-emc-sc-support-generic-groups-98c7452d705b36f9.yaml":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"bceff9298402aa5094017a57b79d0bd2d4d72f0f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Dell EMC SC driver now supports Generic Volume Groups."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"dfeb2761_f79fbf00","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":58},"updated":"2017-04-03 21:17:05.000000000","message":"Generic Volume Groups is supported by every driver by default.  Change this to:\n\nAdd CG capability to Generic Volume Groups in Dell EMC SC driver.","commit_id":"99ce9ae5769c4d781d95c7e2a85faa8e989c04ff"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"00e2d407ae268154c5e7f4e0cd9dbb9df205feb5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Dell EMC SC driver now supports Generic Volume Groups."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7ffa3b31_85a9927c","line":3,"updated":"2017-04-17 14:34:25.000000000","message":"Probably should state that it support the CG type of gvg, but since this is the only thing a volume driver can do with gvg right now, probably fine.","commit_id":"90f72a0c49dda78f51e4ead088245a4576e54d10"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ce109b4d0c2b419e9133547fc640f5201d8a4b57","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Dell EMC SC driver now supports Generic Volume Groups."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7ffa3b31_373315ae","line":3,"in_reply_to":"7ffa3b31_85a9927c","updated":"2017-04-17 15:03:24.000000000","message":"I missed this.  Actually should say \"Add CG capability to generic volume groups\" as every driver supports GVG by default.","commit_id":"90f72a0c49dda78f51e4ead088245a4576e54d10"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"51dfa317f81560cc7bf5579992e372cac5dcdb2d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Dell EMC SC driver now supports the Consistency Group type of Generic"},{"line_number":4,"context_line":"    Volume Groups."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7ffa3b31_3a653cb6","line":4,"updated":"2017-04-17 15:45:35.000000000","message":"Can you change this to \"Add consistency group capability to Generic Volume Groups in the Dell EMC SC driver\" to be consistent with other drivers?","commit_id":"896c9756a4d8405c3fe1fbb68302c0d0fb5f9c21"}]}