)]}'
{"cinder/tests/unit/volume/test_driver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e2769e25bfeaea660b54990ea5ca3f1b8aa31d2d","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    \"\"\"Test case for VolumeDriver.\"\"\""},{"line_number":190,"context_line":"    driver_name \u003d \"cinder.tests.fake_driver.FakeLoggingVolumeDriver\""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def test__update_pools_and_stats(self):"},{"line_number":193,"context_line":"        \"\"\"Test function for _update_pools_and_stats\"\"\""},{"line_number":194,"context_line":"        # Testing to see it pools info is not existing"},{"line_number":195,"context_line":"        fake_data \u003d {\"volume_backend_name\": \u0027fake_backend\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a25e98e_e0811efd","line":192,"updated":"2017-03-13 20:20:32.000000000","message":"The fake driver only exists to support unit tests -- does this test actually add useful coverage of anything?","commit_id":"962d028bc26746ee8dc2bcd4bc5c07309fd10a4e"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"4c4fdf67b09863b4f44c70fa3992300a905de095","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    \"\"\"Test case for VolumeDriver.\"\"\""},{"line_number":190,"context_line":"    driver_name \u003d \"cinder.tests.fake_driver.FakeLoggingVolumeDriver\""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def test__update_pools_and_stats(self):"},{"line_number":193,"context_line":"        \"\"\"Test function for _update_pools_and_stats\"\"\""},{"line_number":194,"context_line":"        # Testing to see it pools info is not existing"},{"line_number":195,"context_line":"        fake_data \u003d {\"volume_backend_name\": \u0027fake_backend\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a25e98e_cd09badf","line":192,"in_reply_to":"7a25e98e_e0811efd","updated":"2017-03-13 21:12:20.000000000","message":"The base driver\u0027s _update_pools_and_stats method gets executed in case of LVM. Since the method to be tested exists in the base driver, I added it here.","commit_id":"962d028bc26746ee8dc2bcd4bc5c07309fd10a4e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e2769e25bfeaea660b54990ea5ca3f1b8aa31d2d","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        image_service \u003d mock.MagicMock()"},{"line_number":225,"context_line":"        image_meta \u003d mock.MagicMock()"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        value \u003d vol[\u0027name\u0027].replace(\u0027-\u0027, \u0027--\u0027)"},{"line_number":228,"context_line":"        path \u003d \u0027/dev/mapper/cinder--volumes-%s\u0027 % value"},{"line_number":229,"context_line":"        self.volume.driver.copy_volume_to_image("},{"line_number":230,"context_line":"            self.context, vol, image_service, image_meta)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a25e98e_207c1620","line":227,"range":{"start_line":227,"start_character":0,"end_line":227,"end_character":46},"updated":"2017-03-13 20:20:32.000000000","message":"This is LVM-specific, so this should be in the LVM tests, not here.","commit_id":"962d028bc26746ee8dc2bcd4bc5c07309fd10a4e"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"4c4fdf67b09863b4f44c70fa3992300a905de095","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        image_service \u003d mock.MagicMock()"},{"line_number":225,"context_line":"        image_meta \u003d mock.MagicMock()"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        value \u003d vol[\u0027name\u0027].replace(\u0027-\u0027, \u0027--\u0027)"},{"line_number":228,"context_line":"        path \u003d \u0027/dev/mapper/cinder--volumes-%s\u0027 % value"},{"line_number":229,"context_line":"        self.volume.driver.copy_volume_to_image("},{"line_number":230,"context_line":"            self.context, vol, image_service, image_meta)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a25e98e_8d17c2ec","line":227,"range":{"start_line":227,"start_character":0,"end_line":227,"end_character":46},"in_reply_to":"7a25e98e_207c1620","updated":"2017-03-13 21:12:20.000000000","message":"I agree. I will move it there","commit_id":"962d028bc26746ee8dc2bcd4bc5c07309fd10a4e"}]}