)]}'
{"cinder/tests/unit/api/v3/test_group_snapshots.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a8158cdb59f93aee3b60df8ed5c981a32354d5f8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.assertEqual(1, len(res_dict))"},{"line_number":112,"context_line":"        self.assertEqual(3, len(res_dict[\u0027group_snapshots\u0027]))"},{"line_number":113,"context_line":"        index \u003d 0"},{"line_number":114,"context_line":"        for snapshot in self.g_snapshots_array:"},{"line_number":115,"context_line":"            self.assertEqual(snapshot.id,"},{"line_number":116,"context_line":"                             res_dict[\u0027group_snapshots\u0027][index][\u0027id\u0027])"},{"line_number":117,"context_line":"            self.assertIsNotNone(res_dict[\u0027group_snapshots\u0027][index][\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_472225a4","line":114,"updated":"2017-03-13 10:06:21.000000000","message":"nit: Since we are going to increase the index on each loop we should use:\n\n for index, snapshot in enumerate(self.g_snapshots_array):","commit_id":"5d66137de0cb0efdee2a613b2d6ba288475d4e54"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a8158cdb59f93aee3b60df8ed5c981a32354d5f8","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            self.assertIsNotNone(res_dict[\u0027group_snapshots\u0027][index][\u0027name\u0027])"},{"line_number":118,"context_line":"            if is_detail:"},{"line_number":119,"context_line":"                self.assertIn(\u0027description\u0027,"},{"line_number":120,"context_line":"                              res_dict[\u0027group_snapshots\u0027][index].keys())"},{"line_number":121,"context_line":"            snapshot.destroy()"},{"line_number":122,"context_line":"            index +\u003d 1"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_2740d106","line":120,"updated":"2017-03-13 10:06:21.000000000","message":"nit: Shouldn\u0027t we be checking that it\u0027s not present when we are not retrieving the detailed one?","commit_id":"5d66137de0cb0efdee2a613b2d6ba288475d4e54"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a8158cdb59f93aee3b60df8ed5c981a32354d5f8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            if is_detail:"},{"line_number":119,"context_line":"                self.assertIn(\u0027description\u0027,"},{"line_number":120,"context_line":"                              res_dict[\u0027group_snapshots\u0027][index].keys())"},{"line_number":121,"context_line":"            snapshot.destroy()"},{"line_number":122,"context_line":"            index +\u003d 1"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @mock.patch("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_07d66d4e","line":121,"updated":"2017-03-13 10:06:21.000000000","message":"-1: This is destroyed in ``_cleanup``","commit_id":"5d66137de0cb0efdee2a613b2d6ba288475d4e54"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a8158cdb59f93aee3b60df8ed5c981a32354d5f8","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    def test_create_group_snapshot_from_empty_group(self):"},{"line_number":213,"context_line":"        body \u003d {\"group_snapshot\": {\"name\": \"group_snapshot1\","},{"line_number":214,"context_line":"                                   \"description\":"},{"line_number":215,"context_line":"                                   \"Group Snapshot 1\"}}"},{"line_number":216,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v3/%s/group_snapshots\u0027 %"},{"line_number":217,"context_line":"                                      fake.PROJECT_ID,"},{"line_number":218,"context_line":"                                      version\u003dGROUP_MICRO_VERSION)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_270e11e5","line":215,"updated":"2017-03-13 10:06:21.000000000","message":"-1: This is not testing the same thing, we need and empty group and use it in the create call.","commit_id":"5d66137de0cb0efdee2a613b2d6ba288475d4e54"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"dbd33af488c9803778ebfb6cd7b7e7a4498b7879","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    def test_create_group_snapshot_from_empty_group(self):"},{"line_number":213,"context_line":"        body \u003d {\"group_snapshot\": {\"name\": \"group_snapshot1\","},{"line_number":214,"context_line":"                                   \"description\":"},{"line_number":215,"context_line":"                                   \"Group Snapshot 1\"}}"},{"line_number":216,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v3/%s/group_snapshots\u0027 %"},{"line_number":217,"context_line":"                                      fake.PROJECT_ID,"},{"line_number":218,"context_line":"                                      version\u003dGROUP_MICRO_VERSION)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_ee65ae1d","line":215,"updated":"2017-03-13 12:10:54.000000000","message":"-1: This test is still not testing what it should test, we need to create an empty groupe and use it in the create call.","commit_id":"47a944177560af8b3f260fb6b5dc8146ba876d62"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"18338ef021b20b62b04f6f10c11d1f7c868a5b93","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        empty_group \u003d utils.create_group("},{"line_number":214,"context_line":"            self.context,"},{"line_number":215,"context_line":"            group_type_id\u003dfake.GROUP_TYPE_ID,"},{"line_number":216,"context_line":"            volume_type_ids\u003d[fake.VOLUME_TYPE_ID], )"},{"line_number":217,"context_line":"        body \u003d {\"group_snapshot\": {\"name\": \"group_snapshot1\","},{"line_number":218,"context_line":"                                   \"description\":"},{"line_number":219,"context_line":"                                   \"Group Snapshot 1\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5a22e58a_53264617","line":216,"range":{"start_line":216,"start_character":50,"end_line":216,"end_character":51},"updated":"2017-03-14 12:19:51.000000000","message":"nit: unnecessary space added here","commit_id":"f35bb58318ae9ca483a502683683d3910a2f85a1"}]}