)]}'
{"cinder/tests/unit/api/v3/test_group_specs.py":[{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"a2b04d9fabbf163dc0ff1450c5f0293d65a5c7be","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        req.environ[\u0027cinder.context\u0027] \u003d self.ctxt"},{"line_number":80,"context_line":"        res_dict \u003d self.controller.index(req, fake.GROUP_ID)"},{"line_number":81,"context_line":"        group_specs_dict \u003d res_dict[\u0027group_specs\u0027]"},{"line_number":82,"context_line":"        self.assertTrue(mock_group_type_specs_get.called)"},{"line_number":83,"context_line":"        self.assertEqual(group_specs_dict[\u0027key1\u0027], \u0027value1\u0027)"},{"line_number":84,"context_line":"        self.assertEqual(group_specs_dict[\u0027key2\u0027], \u0027value2\u0027)"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_7749b3b6","line":82,"range":{"start_line":82,"start_character":50,"end_line":82,"end_character":56},"updated":"2017-03-10 21:50:37.000000000","message":"Better to perform a assert_called_with here","commit_id":"922fc3c721be79a7e7bbfec6f1370a08bac697e1"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"94788e75f802ee46d9b195447878f3a04ca56344","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        db,"},{"line_number":113,"context_line":"        \u0027group_type_specs_update_or_create\u0027,"},{"line_number":114,"context_line":"        return_value\u003d{})"},{"line_number":115,"context_line":"    def test_group_types_update("},{"line_number":116,"context_line":"            self,"},{"line_number":117,"context_line":"            mock_update_or_create,"},{"line_number":118,"context_line":"            mock_typ_specs_get,"},{"line_number":119,"context_line":"            mock_group_type_get,"},{"line_number":120,"context_line":"            mock_rpc_notifier):"},{"line_number":121,"context_line":"        req \u003d fakes.HTTPRequest.blank("},{"line_number":122,"context_line":"            \u0027v3/%s/group_specs\u0027 %"},{"line_number":123,"context_line":"            fake.PROJECT_ID,"},{"line_number":124,"context_line":"            use_admin_context\u003dTrue,"},{"line_number":125,"context_line":"            version\u003dGROUP_TYPE_MICRO_VERSION)"},{"line_number":126,"context_line":"        self.controller.update("},{"line_number":127,"context_line":"            req,"},{"line_number":128,"context_line":"            fake.GROUP_TYPE_ID,"},{"line_number":129,"context_line":"            \u0027id\u0027,"},{"line_number":130,"context_line":"            update_fake_group_specs)"},{"line_number":131,"context_line":"        self.assertTrue(mock_rpc_notifier.called)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @mock.patch.object("},{"line_number":134,"context_line":"        db,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_593f58b3","line":131,"range":{"start_line":115,"start_character":0,"end_line":131,"end_character":49},"updated":"2017-03-13 15:43:27.000000000","message":"It\u0027s unnecessary to make such an indent here. And in the other file\u0027s parts. For me it looks weird and it\u0027s very hard to read.","commit_id":"922fc3c721be79a7e7bbfec6f1370a08bac697e1"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"a2b04d9fabbf163dc0ff1450c5f0293d65a5c7be","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            req,"},{"line_number":212,"context_line":"            fake.GROUP_TYPE_ID,"},{"line_number":213,"context_line":"            \u0027id\u0027)"},{"line_number":214,"context_line":"        self.assertRaises("},{"line_number":215,"context_line":"            webob.exc.HTTPBadRequest,"},{"line_number":216,"context_line":"            self.controller.update,"},{"line_number":217,"context_line":"            req,"},{"line_number":218,"context_line":"            fake.GROUP_TYPE_ID,"},{"line_number":219,"context_line":"            \u0027id\u0027,"},{"line_number":220,"context_line":"            fake_group_specs)"},{"line_number":221,"context_line":"        self.assertRaises("},{"line_number":222,"context_line":"            webob.exc.HTTPBadRequest,"},{"line_number":223,"context_line":"            self.controller.update,"},{"line_number":224,"context_line":"            req,"},{"line_number":225,"context_line":"            fake.GROUP_TYPE_ID,"},{"line_number":226,"context_line":"            \u0027key1\u0027,"},{"line_number":227,"context_line":"            fake_group_specs)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    @mock.patch.object("},{"line_number":230,"context_line":"        db,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_52be7dff","line":227,"range":{"start_line":214,"start_character":2,"end_line":227,"end_character":29},"updated":"2017-03-10 21:50:37.000000000","message":"Suggestion: You could look a param value in for a loop and run this in lesser code\n\nfor param in (\u0027id\u0027,\u0027 key1\u0027):\n    self.assertRaises(\n            webob.exc.HTTPBadRequest,\n            self.controller.update,\n            req,\n            fake.GROUP_TYPE_ID,\n            param,\n            fake_group_specs)","commit_id":"922fc3c721be79a7e7bbfec6f1370a08bac697e1"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"bee83d8cdc5dfc1a6d780fec181ac18e09fd72d2","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"GROUP_TYPE_MICRO_VERSION \u003d \u00273.11\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"fake_group_specs \u003d {"},{"line_number":31,"context_line":"    \u0027key1\u0027: \u0027value1\u0027,"},{"line_number":32,"context_line":"    \u0027key2\u0027: \u0027value2\u0027"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"create_fake_group_specs \u003d {"},{"line_number":36,"context_line":"    \u0027group_specs\u0027: {"},{"line_number":37,"context_line":"        \u0027key1\u0027: \u0027value1\u0027,"},{"line_number":38,"context_line":"        \u0027key2\u0027: \u0027value2\u0027"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"update_fake_group_specs \u003d {"},{"line_number":43,"context_line":"    \u0027id\u0027: \u0027any_string\u0027"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"incorrect_fake_group_specs \u003d {"},{"line_number":47,"context_line":"    \u0027group_specs\u0027: {"},{"line_number":48,"context_line":"        \u0027key#\u0027: \u0027value1\u0027,"},{"line_number":49,"context_line":"        \u0027key2\u0027: \u0027value2\u0027"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":"}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class GroupSpecsTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a1ff146_3a48625b","line":51,"range":{"start_line":30,"start_character":0,"end_line":51,"end_character":1},"updated":"2017-03-16 15:39:51.000000000","message":"i would suggest you to put this in a new file and import it.\n \n:cinder/blob/master/cinder/tests/unit/fake_groupspecs.py\n\nOtherwise looks good to me :)","commit_id":"7ecc0aa19514ad1843c1d990de9b11e15f52c0f7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"976418531a5a40a15f6b451009dbadbd7c7b4675","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                                      use_admin_context\u003dTrue,"},{"line_number":127,"context_line":"                                      version\u003dGROUP_TYPE_MICRO_VERSION)"},{"line_number":128,"context_line":"        res_dict \u003d self.controller.show(req, fake.GROUP_TYPE_ID, \u0027key1\u0027)"},{"line_number":129,"context_line":"        self.assertEqual(res_dict[\u0027key1\u0027], \u0027value1\u0027)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @mock.patch.object(rpc, \u0027get_notifier\u0027)"},{"line_number":132,"context_line":"    @mock.patch.object(db, \u0027group_type_specs_delete\u0027, return_value\u003d{})"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_5de32433","line":129,"range":{"start_line":129,"start_character":25,"end_line":129,"end_character":51},"updated":"2017-03-21 16:51:56.000000000","message":"Please keep the order of arguments in the order (EXPECTED, ACTUAL).","commit_id":"7ecc0aa19514ad1843c1d990de9b11e15f52c0f7"},{"author":{"_account_id":25233,"name":"Satyajeet Shahane","email":"satyajeet.shahane@intel.com","username":"satya1304"},"change_message_id":"979d698fed69206801189b0c89789322658802a5","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                                      use_admin_context\u003dTrue,"},{"line_number":127,"context_line":"                                      version\u003dGROUP_TYPE_MICRO_VERSION)"},{"line_number":128,"context_line":"        res_dict \u003d self.controller.show(req, fake.GROUP_TYPE_ID, \u0027key1\u0027)"},{"line_number":129,"context_line":"        self.assertEqual(res_dict[\u0027key1\u0027], \u0027value1\u0027)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @mock.patch.object(rpc, \u0027get_notifier\u0027)"},{"line_number":132,"context_line":"    @mock.patch.object(db, \u0027group_type_specs_delete\u0027, return_value\u003d{})"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_0353ae6d","line":129,"range":{"start_line":129,"start_character":25,"end_line":129,"end_character":51},"in_reply_to":"1a1ced50_5de32433","updated":"2017-03-23 15:26:55.000000000","message":"Done","commit_id":"7ecc0aa19514ad1843c1d990de9b11e15f52c0f7"}]}