)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/test_vmax.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7f240d643eb2e54f2601cd3072a78ae72a5e0496","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        host\u003dfake_host_v3, provider_location\u003dsix.text_type(provider_location))"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    test_volume_type_QOS \u003d qos_specs.QualityOfServiceSpecs("},{"line_number":495,"context_line":"        id\u003d\u0027944ccfd9-d4c9-4fd3-9d21-4c00b54757e2\u0027,"},{"line_number":496,"context_line":"        name\u003d\u0027qosName\u0027,"},{"line_number":497,"context_line":"        consumer\u003dfields.QoSConsumerValues.BACK_END,"},{"line_number":498,"context_line":"        specs\u003d{\u0027maxIOPS\u0027: \u00276000\u0027, \u0027maxMBPS\u0027: \u00276000\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a22e58a_073acd36","line":495,"updated":"2017-03-14 10:36:49.000000000","message":"-1: We should use cinder.tests.unit.fake_constants.QOS_SPEC_ID","commit_id":"6ec0d52c81cc0e18909fd51fa68db44ed9b2c30b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"92e774138daf8861fa30cde3ab9d20eaf96489bf","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        host\u003dfake_host_v3, provider_location\u003dsix.text_type(provider_location))"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    test_volume_type_QOS \u003d qos_specs.QualityOfServiceSpecs("},{"line_number":495,"context_line":"        id\u003d\u0027944ccfd9-d4c9-4fd3-9d21-4c00b54757e2\u0027,"},{"line_number":496,"context_line":"        name\u003d\u0027qosName\u0027,"},{"line_number":497,"context_line":"        consumer\u003dfields.QoSConsumerValues.BACK_END,"},{"line_number":498,"context_line":"        specs\u003d{\u0027maxIOPS\u0027: \u00276000\u0027, \u0027maxMBPS\u0027: \u00276000\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_fd6d1d33","line":495,"in_reply_to":"3a1ff146_94ca454e","updated":"2017-03-15 13:26:18.000000000","message":"I debated commenting on this too when I reviewed. I kind of agree with Gorka\u0027s last statement. Since we have it, we probably should just use it. Would you mind updating Eric?","commit_id":"6ec0d52c81cc0e18909fd51fa68db44ed9b2c30b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3a28cb85b9eecc0f04be09f3b885b276d98eab29","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        host\u003dfake_host_v3, provider_location\u003dsix.text_type(provider_location))"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    test_volume_type_QOS \u003d qos_specs.QualityOfServiceSpecs("},{"line_number":495,"context_line":"        id\u003d\u0027944ccfd9-d4c9-4fd3-9d21-4c00b54757e2\u0027,"},{"line_number":496,"context_line":"        name\u003d\u0027qosName\u0027,"},{"line_number":497,"context_line":"        consumer\u003dfields.QoSConsumerValues.BACK_END,"},{"line_number":498,"context_line":"        specs\u003d{\u0027maxIOPS\u0027: \u00276000\u0027, \u0027maxMBPS\u0027: \u00276000\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_94ca454e","line":495,"in_reply_to":"3a1ff146_e75bfc2c","updated":"2017-03-15 12:36:15.000000000","message":"I was never in favor of having the fake_constants file to begin with, but once we have it I\u0027d rather have our code consistently using it.","commit_id":"6ec0d52c81cc0e18909fd51fa68db44ed9b2c30b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b039459fe039a71b1675a3d1848895b46559907b","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        host\u003dfake_host_v3, provider_location\u003dsix.text_type(provider_location))"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    test_volume_type_QOS \u003d qos_specs.QualityOfServiceSpecs("},{"line_number":495,"context_line":"        id\u003d\u0027944ccfd9-d4c9-4fd3-9d21-4c00b54757e2\u0027,"},{"line_number":496,"context_line":"        name\u003d\u0027qosName\u0027,"},{"line_number":497,"context_line":"        consumer\u003dfields.QoSConsumerValues.BACK_END,"},{"line_number":498,"context_line":"        specs\u003d{\u0027maxIOPS\u0027: \u00276000\u0027, \u0027maxMBPS\u0027: \u00276000\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_e75bfc2c","line":495,"in_reply_to":"5a22e58a_073acd36","updated":"2017-03-14 14:06:00.000000000","message":"We never reference this id again in the tests, so I\u0027m not sure it matters much.","commit_id":"6ec0d52c81cc0e18909fd51fa68db44ed9b2c30b"}]}
