)]}'
{"cinder/volume/drivers/dell/dell_storagecenter_common.py":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"de8fee659c1fdca013115603d4160ee10c4b58eb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                default\u003dFalse,"},{"line_number":46,"context_line":"                help\u003d\u0027Enable HTTPS SC certificate verification\u0027),"},{"line_number":47,"context_line":"    cfg.HostAddressOpt(\u0027secondary_san_ip\u0027,"},{"line_number":48,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":49,"context_line":"               help\u003d\u0027IP address of secondary DSM controller\u0027),"},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027secondary_san_login\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027Admin\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_5179ca92","line":48,"range":{"start_line":48,"start_character":23,"end_line":48,"end_character":26},"updated":"2017-03-15 07:41:27.000000000","message":"ditto","commit_id":"3116bafe83162ab51b7f31278e5f4fa639c4027c"}],"cinder/volume/drivers/nexenta/options.py":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"de8fee659c1fdca013115603d4160ee10c4b58eb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"               help\u003d\u0027NexentaEdge logical path of directory to store symbolic \u0027"},{"line_number":23,"context_line":"                    \u0027links to NBDs\u0027),"},{"line_number":24,"context_line":"    cfg.HostAddressOpt(\u0027nexenta_rest_address\u0027,"},{"line_number":25,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":26,"context_line":"               help\u003d\u0027IP address of NexentaEdge management REST API endpoint\u0027),"},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027nexenta_rest_user\u0027,"},{"line_number":28,"context_line":"               default\u003d\u0027admin\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_11491260","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":26},"updated":"2017-03-15 07:41:27.000000000","message":"ditto","commit_id":"3116bafe83162ab51b7f31278e5f4fa639c4027c"}],"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"de8fee659c1fdca013115603d4160ee10c4b58eb","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"nas_opts \u003d ["},{"line_number":45,"context_line":"    cfg.HostAddressOpt(\u0027nas_host\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027IP address or Hostname of NAS system.\u0027,"},{"line_number":48,"context_line":"               deprecated_name\u003d\u0027nas_ip\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027nas_login\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_f14b9657","line":46,"range":{"start_line":46,"start_character":23,"end_line":46,"end_character":26},"updated":"2017-03-15 07:41:27.000000000","message":"ditto","commit_id":"3116bafe83162ab51b7f31278e5f4fa639c4027c"}],"cinder/volume/drivers/san/san.py":[{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"de8fee659c1fdca013115603d4160ee10c4b58eb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                default\u003dTrue,"},{"line_number":41,"context_line":"                help\u003d\u0027Use thin provisioning for SAN volumes?\u0027),"},{"line_number":42,"context_line":"    cfg.HostAddressOpt(\u0027san_ip\u0027,"},{"line_number":43,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":44,"context_line":"               help\u003d\u0027IP address of SAN controller\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027san_login\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027admin\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_314d2e73","line":43,"range":{"start_line":43,"start_character":15,"end_line":43,"end_character":25},"updated":"2017-03-15 07:41:27.000000000","message":"\u0027\u0027 is not a valid default value for either hostname or IP address. \n\n\n\nPlease refer:\nhttps://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L1405\nhttps://github.com/openstack/oslo.config/blob/master/oslo_config/types.py#L763\nhttps://www.ietf.org/rfc/rfc1912.txt\n\n\n\nYou will need to change the default value.","commit_id":"3116bafe83162ab51b7f31278e5f4fa639c4027c"},{"author":{"_account_id":24564,"name":"qtlu","email":"qtlu@fiberhome.com","username":"qtlu"},"change_message_id":"77ce409028571493230a7e7ab831dda400a3c0a3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                default\u003dTrue,"},{"line_number":41,"context_line":"                help\u003d\u0027Use thin provisioning for SAN volumes?\u0027),"},{"line_number":42,"context_line":"    cfg.HostAddressOpt(\u0027san_ip\u0027,"},{"line_number":43,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":44,"context_line":"               help\u003d\u0027IP address of SAN controller\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027san_login\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027admin\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_7c413d0b","line":43,"range":{"start_line":43,"start_character":15,"end_line":43,"end_character":25},"in_reply_to":"3a1ff146_314d2e73","updated":"2017-03-15 08:38:41.000000000","message":"Thanks for your review, I have changed in my new patch.","commit_id":"3116bafe83162ab51b7f31278e5f4fa639c4027c"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"c8a1ffd20af3cdd43db34870e78b28b890400211","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                default\u003dTrue,"},{"line_number":41,"context_line":"                help\u003d\u0027Use thin provisioning for SAN volumes?\u0027),"},{"line_number":42,"context_line":"    cfg.HostAddressOpt(\u0027san_ip\u0027,"},{"line_number":43,"context_line":"                       default\u003d\u0027127.0.0.1\u0027,"},{"line_number":44,"context_line":"                       help\u003d\u0027IP address of SAN controller\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027san_login\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027admin\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_cf58b259","line":43,"range":{"start_line":43,"start_character":31,"end_line":43,"end_character":42},"updated":"2017-03-15 10:11:18.000000000","message":"Will it make sense to use oslo_utils.netutils.get_my_ipv4() instead of hard-coding 127.0.0.1?\n\n\n\n\nAlso as you are changing the default value you also need to make changes to the test cases where the old default value was getting asserted otherwise test cases will not pass. \n\nFor ex: \n\nhttps://github.com/openstack/cinder/blob/master/cinder/tests/unit/volume/drivers/dell_emc/unity/test_driver.py#L134","commit_id":"e98c077957da30d5eb6338ef2991492457bc72ee"}]}