)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"2c6879c1bbdd9e635db20efbb1d53dde92dec4b7","unresolved":false,"context_lines":[{"line_number":2500,"context_line":""},{"line_number":2501,"context_line":"            try:"},{"line_number":2502,"context_line":"                model_update \u003d self.driver.create_group(context, group)"},{"line_number":2503,"context_line":"            except NotImplementedError:"},{"line_number":2504,"context_line":"                cgsnap_type \u003d group_types.get_default_cgsnapshot_type()"},{"line_number":2505,"context_line":"                if group.group_type_id !\u003d cgsnap_type[\u0027id\u0027]:"},{"line_number":2506,"context_line":"                    model_update \u003d self._create_group_generic(context, group)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_45eda389","line":2503,"range":{"start_line":2503,"start_character":12,"end_line":2503,"end_character":39},"updated":"2017-03-27 08:54:30.000000000","message":"This exception is also used to move the control from the driver\u0027s \"create_group\" method to the manager \"create_group\" method.\nMaybe, it is better to add a new type of exception for this case where the driver has a \"create_group\" method, but in some cases choose to move the control flow to the manager.\nThis would be more understandable to the reader/user of this code.","commit_id":"c979bdac87d5e97a5b3e2cb7ad2d6a26b505a99c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b7d04dd744f6ecce6888b3d32cbf5e0377618342","unresolved":false,"context_lines":[{"line_number":2500,"context_line":""},{"line_number":2501,"context_line":"            try:"},{"line_number":2502,"context_line":"                model_update \u003d self.driver.create_group(context, group)"},{"line_number":2503,"context_line":"            except NotImplementedError:"},{"line_number":2504,"context_line":"                cgsnap_type \u003d group_types.get_default_cgsnapshot_type()"},{"line_number":2505,"context_line":"                if group.group_type_id !\u003d cgsnap_type[\u0027id\u0027]:"},{"line_number":2506,"context_line":"                    model_update \u003d self._create_group_generic(context, group)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_96ad1533","line":2503,"range":{"start_line":2503,"start_character":12,"end_line":2503,"end_character":39},"in_reply_to":"ffe62b97_45eda389","updated":"2017-03-27 13:22:00.000000000","message":"I\u0027m catching the NotImplementedError exception thrown by the driver here.  This is the exact exception needed here.  Without this, the NotImplementedError exception thrown by the driver will not lead to the default generic volume groups implementation.","commit_id":"c979bdac87d5e97a5b3e2cb7ad2d6a26b505a99c"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"2c6879c1bbdd9e635db20efbb1d53dde92dec4b7","unresolved":false,"context_lines":[{"line_number":2506,"context_line":"                    model_update \u003d self._create_group_generic(context, group)"},{"line_number":2507,"context_line":"                else:"},{"line_number":2508,"context_line":"                    cg, __ \u003d self._convert_group_to_cg(group, [])"},{"line_number":2509,"context_line":"                    model_update \u003d self.driver.create_consistencygroup("},{"line_number":2510,"context_line":"                        context, cg)"},{"line_number":2511,"context_line":""},{"line_number":2512,"context_line":"            if model_update:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_a5146fa1","line":2509,"range":{"start_line":2509,"start_character":35,"end_line":2509,"end_character":70},"updated":"2017-03-27 08:54:30.000000000","message":"This method should not be part of the driver code in Pike.\nIf you leave it here you should wrap it with try...except.","commit_id":"c979bdac87d5e97a5b3e2cb7ad2d6a26b505a99c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b7d04dd744f6ecce6888b3d32cbf5e0377618342","unresolved":false,"context_lines":[{"line_number":2506,"context_line":"                    model_update \u003d self._create_group_generic(context, group)"},{"line_number":2507,"context_line":"                else:"},{"line_number":2508,"context_line":"                    cg, __ \u003d self._convert_group_to_cg(group, [])"},{"line_number":2509,"context_line":"                    model_update \u003d self.driver.create_consistencygroup("},{"line_number":2510,"context_line":"                        context, cg)"},{"line_number":2511,"context_line":""},{"line_number":2512,"context_line":"            if model_update:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_3151b30f","line":2509,"range":{"start_line":2509,"start_character":35,"end_line":2509,"end_character":70},"in_reply_to":"ffe62b97_a5146fa1","updated":"2017-03-27 13:22:00.000000000","message":"This is still needed because there are still drivers not converted yet.  It can only be deleted when all drivers have converted over.","commit_id":"c979bdac87d5e97a5b3e2cb7ad2d6a26b505a99c"}]}